7211 0 true 2009-08-15T21:52:46+01:00 49226 64 contributing-to-rails 19701 16213 published 2009-08-15T21:55:17+01:00 85 Jeremy Kemper Larkware Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/64 Adding this one to the project today. Feedback welcome. Adding this one to the project today. Feedback welcome. <div><p>Adding this one to the project today. Feedback welcome.</p></div> 7211 0 Adding this one to the project today. Feedback welcome. <div><p>Adding this one to the project today. Feedback welcome.</p></div> false 2009-03-02T16:23:16+00:00 49226 --- {} 64 contributing-to-rails 0 16213 available 2009-03-02T16:23:18+00:00 49226 Larkware Larkware Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/64 7211 0 true 2009-03-11T12:05:45+00:00 49226 --- :state: available 64 contributing-to-rails 0 16213 published 2009-03-11T12:06:40+00:00 1366 Pratik Larkware Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/64 7211 0 Damn good guide. Well written and easy to follow. As someone who's just read it (along with the contributor guide here in Lighthouse) before cloning rails for the first time I have the following comments. * I also needed to have memcached up and running for some of the tests to run. * Some of the tests are pending. It may be worthwhile reassuring people that this is okay. * I feel the sentence "You can change sqlite3 with jdbcmysql, jdbcsqlite3, jdbcpostgresql, mysql or postgresql." would read better as "You can swap sqlite3 for jdbcmysql, jdbcsqlite3, jdbcpostgresql, mysql or postgresql.". When I know a bit more about git I'll look to make these changes myself if someone hasn't beaten me to it. <div><p>Damn good guide. Well written and easy to follow. As someone who's just read it (along with the contributor guide here in Lighthouse) before cloning rails for the first time I have the following comments.</p> <ul> <li>I also needed to have memcached up and running for some of the tests to run.</li> <li>Some of the tests are pending. It may be worthwhile reassuring people that this is okay.</li> <li>I feel the sentence "You can change sqlite3 with jdbcmysql, jdbcsqlite3, jdbcpostgresql, mysql or postgresql." would read better as "You can swap sqlite3 for jdbcmysql, jdbcsqlite3, jdbcpostgresql, mysql or postgresql.".</li> </ul> <p>When I know a bit more about git I'll look to make these changes myself if someone hasn't beaten me to it.</p></div> true 2009-06-14T08:53:34+01:00 49226 --- {} 64 contributing-to-rails 0 16213 published 2009-06-14T08:53:34+01:00 55143 Paul Gillard Larkware Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/64 7211 0 Good article and helpful IRC responses on #railsbridge <div><p>Good article and helpful IRC responses on #railsbridge</p></div> true 2009-08-01T11:23:11+01:00 49226 --- {} 64 contributing-to-rails 0 16213 published 2009-08-01T11:23:17+01:00 25697 Karl Doody Larkware Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/64 7211 0 I think this guide is OK right now, but I recently found that tests were failing for me locally and I couldn't quite figure out what it was. I would have found a "troubleshooting" section helpful. I think that section should urge users to: - check ci to see if it's green. If it's green, and you are failing locally, it's your fault - run geminstaller, by first installing geminstaller (or manually install all of the gems and their appropriate versions, using geminstaller as the guide) <div><p>I think this guide is OK right now, but I recently found that tests were failing for me locally and I couldn't quite figure out what it was. I would have found a "troubleshooting" section helpful. I think that section should urge users to:</p> <ul> <li>check ci to see if it's green. If it's green, and you are failing locally, it's your fault</li> <li>run geminstaller, by first installing geminstaller (or manually install all of the gems and their appropriate versions, using geminstaller as the guide)</li> </ul></div> true 2009-08-09T07:03:12+01:00 49226 --- {} 64 contributing-to-rails 0 16213 published 2009-08-09T07:03:15+01:00 5060 Jeff Dean Larkware Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/64 7211 0 Some more git-fu would help on this one: * Encourage branching before every patch. Easy to rebase, easy to do multiple patches, easy to delete, easy to publish to github. * Demonstrate how to cherry-pick from master to stable branch. Follows our git workflow of all dev on master with bugfixes and small enhancements backported to stable. * Show how to add to a patch without losing the original authorship. Play friendly with other contributors by not inadvertently "claiming" their work. <div><p>Some more git-fu would help on this one:</p> <ul> <li> <p>Encourage branching before every patch. Easy to rebase, easy to do multiple patches, easy to delete, easy to publish to github.</p> </li> <li> <p>Demonstrate how to cherry-pick from master to stable branch. Follows our git workflow of all dev on master with bugfixes and small enhancements backported to stable.</p> </li> <li> <p>Show how to add to a patch without losing the original authorship. Play friendly with other contributors by not inadvertently "claiming" their work.</p> </li> </ul></div> true 2009-08-15T21:52:46+01:00 49226 --- {} 64 contributing-to-rails 0 16213 published 2009-08-15T21:55:17+01:00 85 Jeremy Kemper Larkware Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/64