1366 0 true 2008-11-03T17:54:42+00:00 1366 2009-01-12T00:00:00+00:00 21487 23 rails-i18 5 16213 published guides i18n 2010-02-04T00:21:21+00:00 25224 omarqureshi Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 Guide that covers all public facing features of Rails I18 that'll help people to write plugins on top of them or use it directly in theor apps. Also cover the best practices and useful plugins. Guide that covers all public facing features of Rails I18 that'll help people to write plugins on top of them or use it directly in theor apps. Also cover the best practices and useful plugins. <div><p>Guide that covers all public facing features of Rails I18 that'll help people to write plugins on top of them or use it directly in theor apps. Also cover the best practices and useful plugins.</p></div> 1366 0 Guide that covers all public facing features of Rails I18 that'll help people to write plugins on top of them or use it directly in theor apps. Also cover the best practices and useful plugins. <div><p>Guide that covers all public facing features of Rails I18 that'll help people to write plugins on top of them or use it directly in theor apps. Also cover the best practices and useful plugins.</p></div> false 2008-11-03T17:54:42+00:00 1366 --- {} 21487 23 rails-i18 0 16213 available 2008-11-03T17:54:45+00:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 This is being worked on by Sven. <div><p>This is being worked on by Sven.</p></div> false 2008-11-03T17:54:58+00:00 1366 --- :state: available 21487 23 rails-i18 0 16213 taken 2008-11-03T17:55:01+00:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Ping <div><p>Ping</p></div> false 2008-12-31T14:49:32+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken 2008-12-31T14:49:35+00:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 I've updated the introduction section a bit and am starting re-writing the "Setting and passing locale" section. Any feedback appreciated. <div><p>I've updated the introduction section a bit and am starting re-writing the "Setting and passing locale" section. Any feedback appreciated.</p></div> false 2009-01-17T21:08:09+00:00 1366 --- :tag: 21487 23 rails-i18 0 16213 taken guides i18n 2009-01-17T21:08:11+00:00 16364 Karel Minařík Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Some notes : - This guide needs to talk about http://github.com/rails/rails/commit/a98cd7ca9b2f24a4500963e58ba5c37d6bdf9259 somewhere - Browser screenshots need to get rid of the shadow - The current TODO has "Using GeoIP (or similar) database" and "User profile". I don't think those belong to the guide. Probably just 1-2 lines without code. - "request.env['HTTP_ACCEPT_LANGUAGE'].scan(/^[a-z]{2}/).first" -- maybe that should be in core ? <div><p>Some notes :</p> <ul> <li>This guide needs to talk about <a href="http://github.com/rails/rails/commit/a98cd7ca9b2f24a4500963e58ba5c37d6bdf9259"> http://github.com/rails/rails/co...</a> somewhere</li> <li>Browser screenshots need to get rid of the shadow</li> <li>The current TODO has "Using GeoIP (or similar) database" and "User profile". I don't think those belong to the guide. Probably just 1-2 lines without code.</li> <li>"request.env['HTTP_ACCEPT_LANGUAGE'].scan(/^[a-z]{2}/).first" -- maybe that should be in core ?</li> </ul></div> false 2009-01-26T15:22:28+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-01-26T15:22:32+00:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 hi guys, regarding this part of the guide : "(For instance, in the :en-US locale you would have $ as a currency symbol, while in :en-UK, you would have €." I don't think en-UK buddies will appreciate have € as their official money :D Looks like it's more £ thanks Philippe <div><p>hi guys,</p> <p>regarding this part of the guide :</p> <p>"(For instance, in the :en-US locale you would have $ as a currency symbol, while in :en-UK, you would have &#8364;."</p> <p>I don't think en-UK buddies will appreciate have &#8364; as their official money :D Looks like it's more &pound;</p> <p>thanks Philippe</p></div> false 2009-02-04T10:42:01+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-04T10:42:05+00:00 19160 Gravis Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 @Gravis -- Thanks, fixed in http://github.com/lifo/docrails/commit/e0d79fbf041033b5dc97aaf2df8a84fefdb91470 --karmi <div><p>@Gravis -- Thanks, fixed in <a href="http://github.com/lifo/docrails/commit/e0d79fbf041033b5dc97aaf2df8a84fefdb91470"> http://github.com/lifo/docrails/...</a></p> <p>--karmi</p></div> false 2009-02-04T11:11:35+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-04T11:11:37+00:00 16364 Karel Minařík Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Hey, I'm still waiting for the fixes on my feedback. Thanks :) <div><p>Hey,</p> <p>I'm still waiting for the fixes on my feedback.</p> <p>Thanks :)</p></div> false 2009-02-07T03:07:29+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-07T03:07:30+00:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Hi Pratik, sorry, you're right. > Localized templates Hm... I was asking on #docrails -- should we put this in when it's still in flux and appears to be buggy as well (http://groups.google.com/group/rubyonrails-core/browse_thread/thread/391fac6373e0fbf9?hl=en). I am waiting for how things settle down in release. > Browser screenshots need to get rid of the shadow O rlly? :) OK, will try. > The current TODO has "Using GeoIP (or similar) database" and "User profile" As you see in the guide, I've put just some basic info there, so people know you've got more options with regard to locale then to stick ?locale=en into every URL. > "request.env['HTTP_ACCEPT_LANGUAGE'].scan(/^[a-z]{2}/).first" -- maybe that should be in core ? That's just a naive implementation for the guide. Iaian's plugin and Ryan's middleware solve that very well... I plan to incorporate also this feedback: http://groups.google.com/group/rails-i18n/msg/7b4513b3ca8abbf5?hl=en into it. Cheers, Karel <div><p>Hi Pratik,</p> <p>sorry, you're right.</p> <blockquote> <p>Localized templates Hm... I was asking on #docrails -- should we put this in when it's still in flux and appears to be buggy as well (<a href="http://groups.google.com/group/rubyonrails-core/browse_thread/thread/391fac6373e0fbf9?hl=en">http://groups.google.com/group/r...</a>). I am waiting for how things settle down in release.</p> <p>&nbsp;Browser screenshots need to get rid of the shadow</p> </blockquote> <p>O rlly? :) OK, will try.</p> <blockquote> <p>&nbsp;The current TODO has "Using GeoIP (or similar) database" and "User profile"</p> </blockquote> <p>As you see in the guide, I've put just some basic info there, so people know you've got more options with regard to locale then to stick ?locale=en into every URL.</p> <blockquote> <p> &nbsp;"request.env['HTTP_ACCEPT_LANGUAGE'].scan(/^[a-z]{2}/).first" -- maybe that should be in core ?</p> </blockquote> <p>That's just a naive implementation for the guide. Iaian's plugin and Ryan's middleware solve that very well...</p> <p>I plan to incorporate also this feedback: <a href="http://groups.google.com/group/rails-i18n/msg/7b4513b3ca8abbf5?hl=en"> http://groups.google.com/group/r...</a> into it.</p> <p>Cheers,</p> <p>Karel</p></div> false 2009-02-07T09:38:16+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-07T09:38:19+00:00 16364 Karel Minařík Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 About the "5.1.1 Error message scopes", I think this part is not very clear for first readers really. <div><p>About the "5.1.1 Error message scopes", I think this part is not very clear for first readers really.</p></div> false 2009-02-16T00:05:13+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-16T00:05:14+00:00 31905 droide Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Is the application supposed to reset I18n.locale after each request? The guide doesn't mention this. People are reporting that, if they set I18n.locale in a before filter, subsequent requests that don't have that before filter will have the same locale as the one last set. This doesn't happen in Mongrel because Mongrel uses a different thread for each request, and I18n.locale is thread-local, so people think that this is a Passenger bug. I think it's not. In any case, Rails doesn't seem to reset I18n.locale automatically after every request. This makes me wonder whether this behavior is intentional or a bug. <div><p>Is the application supposed to reset I18n.locale after each request? The guide doesn't mention this.</p> <p>People are reporting that, if they set I18n.locale in a before filter, subsequent requests that don't have that before filter will have the same locale as the one last set. This doesn't happen in Mongrel because Mongrel uses a different thread for each request, and I18n.locale is thread-local, so people think that this is a Passenger bug. I think it's not.</p> <p>In any case, Rails doesn't seem to reset I18n.locale automatically after every request. This makes me wonder whether this behavior is intentional or a bug.</p></div> false 2009-02-19T21:43:16+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-19T21:43:23+00:00 10679 Hongli Lai Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Take a look at http://groups.google.com/group/phusion-passenger/t/6202fb4d8f750c31?hl=en for the Phusion Passenger problem report by users. <div><p>Take a look at <a href="http://groups.google.com/group/phusion-passenger/t/6202fb4d8f750c31?hl=en"> http://groups.google.com/group/p...</a> for the Phusion Passenger problem report by users.</p></div> false 2009-02-19T21:48:12+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-19T21:48:15+00:00 10679 Hongli Lai Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Please consider reading this post: http://www.ruby-forum.com/topic/... Brief: hash paths from the guide seem to be different from the actual ones being used. Full description of the issue is in the post at ruby-forum. Alex <div><p>Please consider reading this post: <a href="http://www.ruby-forum.com/topic/...%3C/p">http://www.ruby-forum.com/topic/...</a>&gt;</p> <p>Brief: hash paths from the guide seem to be different from the actual ones being used.</p> <p>Full description of the issue is in the post at ruby-forum.</p> <p>Alex</p></div> false 2009-02-23T02:03:42+00:00 1366 --- :title: Rails I18 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-23T02:03:43+00:00 48352 Alex Fortuna Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 false 2009-02-23T02:04:08+00:00 1366 --- :title: I18n hash lookup paths seem to be wrong 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-23T02:04:10+00:00 48352 Alex Fortuna Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Sorry for occasionally changing the title. I thought that was my comment's title. Please fix as appropriate. Alex <div><p>Sorry for occasionally changing the title. I thought that was my comment's title. Please fix as appropriate.</p> <p>Alex</p></div> false 2009-02-23T02:05:51+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-23T02:05:54+00:00 48352 Alex Fortuna Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 @Alex: Please post correct URL for the discussion or paste here... Thanks! <div><p>@Alex: Please post correct URL for the discussion or paste here... Thanks!</p></div> false 2009-02-23T08:27:39+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-23T08:27:43+00:00 16364 Karel Minařík Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Karel This is the post: http://www.ruby-forum.com/topic/179273 If it fails this time, I'll re-post the body here. <div><p>Karel</p> <p>This is the post: <a href="http://www.ruby-forum.com/topic/179273">http://www.ruby-forum.com/topic/...</a></p> <p>If it fails this time, I'll re-post the body here.</p></div> false 2009-02-23T16:03:02+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-23T16:03:08+00:00 48352 Alex Fortuna Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 > 3.3 Organization of locale files @@@ For example, your config/locale directory could look like this: |-defaults |---es.rb |---en.rb |-models |---book |-----es.rb |-----en.rb |-views |---defaults |-----es.rb |-----en.rb ... @@@ Anyone tried that kind of structure? I tried placing those `.rb` files under listed locations -- it looks like nobody's reading them. `I18n.load_path` doesn't seem to be anyhow aware. What is meant by the words _could look like this_? If it isn't available by default, I guess we should write what's needed to make it work. <div><blockquote> <p>3.3 Organization of locale files</p> </blockquote> <pre><code> For example, your config/locale directory could look like this: |-defaults |---es.rb |---en.rb |-models |---book |-----es.rb |-----en.rb |-views |---defaults |-----es.rb |-----en.rb ... </code></pre> <p>Anyone tried that kind of structure? I tried placing those <code>.rb</code> files under listed locations -- it looks like nobody's reading them. <code>I18n.load_path</code> doesn't seem to be anyhow aware.</p> <p>What is meant by the words <em>could look like this</em>? If it isn't available by default, I guess we should write what's needed to make it work.</p></div> false 2009-02-23T18:40:25+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-23T18:40:26+00:00 48352 Alex Fortuna Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 We have a structure that is similar to that for our 2.2 app, and added a line (in locale.rb initializer) to do: @@@ I18n.load_path += Dir.glob(File.join(RAILS_ROOT, 'config', 'locales', '**', '*.{rb,yml}')) @@@ <div><p>We have a structure that is similar to that for our 2.2 app, and added a line (in locale.rb initializer) to do:</p> <pre><code> I18n.load_path += Dir.glob(File.join(RAILS_ROOT, 'config', 'locales', '**', '*.{rb,yml}')) </code></pre></div> false 2009-02-23T19:09:17+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-23T19:09:20+00:00 22258 Mike Champion Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 @Alex: Indeed, the default Rails loading mechanism does not load nested locales like this. You have to add the glob `**` like @Mike was kind enough to advice. I'll update the guide accordingly. Your locale organization _could_ look like this, if you'd need such deeply nested structure. There're uses when single `es.yml` file would be more than enough. Please report any other issues you would have with the guide, best, Karel <div><p>@Alex: Indeed, the default Rails loading mechanism does not load nested locales like this. You have to add the glob <code>**</code>&nbsp;like @Mike was kind enough to advice. I'll update the guide accordingly.</p> <p>Your locale organization <em>could</em> look like this, if you'd need such deeply nested structure. There're uses when single <code>es.yml</code> file would be more than enough.</p> <p>Please report any other issues you would have with the guide,</p> <p>best,</p> <p>Karel</p></div> false 2009-02-25T07:46:35+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-25T07:46:39+00:00 16364 Karel Minařík Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 @Alex: Regarding the ActiveRecord namespace lookup, there is probably some issue or bug in implementation. It should work as the guide states, but it does not. Please file a separate ticket for this... Karel <div><p>@Alex: Regarding the ActiveRecord namespace lookup, there is probably some issue or bug in implementation. It should work as the guide states, but it does not. Please file a separate ticket for this...</p> <p>Karel</p></div> false 2009-02-25T08:15:36+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-25T08:15:42+00:00 16364 Karel Minařík Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Thanks, good guide. Couple things though. Following code didn't work as such when pasted to console (raises undefined method error when trying to test): @@@ module I18n def just_raise_that_exception(*args) raise args.first end end I18n.exception_handler = :just_raise_that_exception @@@ It could be e.g.: @@@ module I18n class << self def just_raise_that_exception(*args) raise args.first end end end I18n.exception_handler = 'just_raise_that_exception' @@@ I would also add links to different backends. You mention globalize so you could also link to that one, i.e. http://github.com/joshmh/globalize2/tree/master <div><p>Thanks, good guide. Couple things though.</p> <p>Following code didn't work as such when pasted to console (raises undefined method error when trying to test):</p> <pre><code> module I18n def just_raise_that_exception(*args) raise args.first end end I18n.exception_handler = :just_raise_that_exception </code></pre> <p>It could be e.g.:</p> <pre><code> module I18n class &lt;&lt; self def just_raise_that_exception(*args) raise args.first end end end I18n.exception_handler = 'just_raise_that_exception' </code></pre> <p>I would also add links to different backends. You mention globalize so you could also link to that one, i.e. <a href="http://github.com/joshmh/globalize2/tree/master">http://github.com/joshmh/globali...</a></p></div> false 2009-02-26T21:50:25+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-02-26T21:50:30+00:00 48866 holli Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 @Alex: The issue with AR error messages lookup has been fixed now: http://github.com/lifo/docrails/commit/61656cf7702f46fcbb810a70bf0298ac5ea6c0d3 Many thanks for the bug report. --karmi <div><p>@Alex: The issue with AR error messages lookup has been fixed now: <a href="http://github.com/lifo/docrails/commit/61656cf7702f46fcbb810a70bf0298ac5ea6c0d3"> http://github.com/lifo/docrails/...</a></p> <p>Many thanks for the bug report.</p> <p>--karmi</p></div> false 2009-03-01T12:05:11+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-03-01T12:05:14+00:00 16364 Karel Minařík Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Hello all, I have put some fixes in: * [Fixed incorrect examples of ActiveRecord error message lookup in the I18N guide [Thanks Alex Fortuna]](http://github.com/lifo/docrails/commit/61656cf7702f46fcbb810a70bf0298ac5ea6c0d3) * [Added information about "lazy lookup" inside views (`t '.foo'`) in I18N guide](http://github.com/lifo/docrails/commit/a6f1e42c096a626b8a071094545d35f90d19ab55) * [Clarified info about "pragmatic approach to locale codes" and removed speculation about "locale inheritance" in the I18N guide [thanks Kip]](http://github.com/lifo/docrails/commit/959b827e40248691864221d9d8561f17fb5755a6) * [Added information about "Localized views" into I18N guide](http://github.com/lifo/docrails/commit/92dd9b3e9f7bffe16ec53aeefd048d7da4eb1543) * [Added note how to configure Rails loading mechanism to look for nested locale files (+config/locales/models/book/es.yml+, etc) to the I18N guide](http://github.com/lifo/docrails/commit/48d4c0f0116117e45fd268f9fa8ae502d7f15cc7) * [Get rid of drop shadows in screenshots for the I18N guide](http://github.com/lifo/docrails/commit/e1c0763e47f76b916324c5a062b50ede41a51e3c) More feedback appreciated! --karmi <div><p>Hello all,</p> <p>I have put some fixes in:</p> <ul> <li> <p><a href="http://github.com/lifo/docrails/commit/61656cf7702f46fcbb810a70bf0298ac5ea6c0d3"> Fixed incorrect examples of ActiveRecord error message lookup in the I18N guide [Thanks Alex Fortuna]</a></p> </li> <li> <p><a href="http://github.com/lifo/docrails/commit/a6f1e42c096a626b8a071094545d35f90d19ab55"> Added information about "lazy lookup" inside views (<code>t '.foo'</code>) in I18N guide</a></p> </li> <li> <p><a href="http://github.com/lifo/docrails/commit/959b827e40248691864221d9d8561f17fb5755a6"> Clarified info about "pragmatic approach to locale codes" and removed speculation about "locale inheritance" in the I18N guide [thanks Kip]</a></p> </li> <li> <p><a href="http://github.com/lifo/docrails/commit/92dd9b3e9f7bffe16ec53aeefd048d7da4eb1543"> Added information about "Localized views" into I18N guide</a></p> </li> <li> <p><a href="http://github.com/lifo/docrails/commit/48d4c0f0116117e45fd268f9fa8ae502d7f15cc7"> Added note how to configure Rails loading mechanism to look for nested locale files (+config/locales/models/book/es.yml+, etc) to the I18N guide</a></p> </li> <li> <p><a href="http://github.com/lifo/docrails/commit/e1c0763e47f76b916324c5a062b50ede41a51e3c"> Get rid of drop shadows in screenshots for the I18N guide</a></p> </li> </ul> <p>More feedback appreciated!</p> <p>--karmi</p></div> false 2009-03-01T14:57:57+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-03-01T14:57:59+00:00 16364 Karel Minařík Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Karel, thanks for all the awesome work on the guide. You totally rock :) Pratik, I think the guide is ready. <div><p>Karel, thanks for all the awesome work on the guide. You totally rock :)</p> <p>Pratik, I think the guide is ready.</p></div> false 2009-03-08T23:07:01+00:00 1366 --- {} 21487 23 rails-i18 0 16213 taken guides i18n 2009-03-08T23:07:05+00:00 7400 Sven Fuchs Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 7211 0 false 2009-03-14T16:47:39+00:00 1366 --- :assigned_user: 1366 21487 23 rails-i18 0 16213 taken guides i18n 2009-03-14T16:47:42+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 7211 0 true 2009-03-14T22:04:50+00:00 1366 --- :state: taken 21487 23 rails-i18 0 16213 published guides i18n 2009-03-14T22:04:53+00:00 7211 Mike Gunderloy Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 7211 0 Well written guide. Couple of things though: * Guide mentions relative path of 'config/locale' in some places and 'config/locales' in others. Looking at the comment in enviroment.rb and from experience it should be 'config/locales' in all instances. * The sentence which reads 'The default environment.rb files has instruction how to add locales from another directory and how to set a different default locale.' would read better as 'The default environment.rb file has instructions on how to add locales from another directory and how to set a different default locale.' * The sentence beginning 'As a user you should always only access the public methods...' _may_ read better as 'As a user you should only ever access the public methods...' <div><p>Well written guide. Couple of things though:</p> <ul> <li>Guide mentions relative path of 'config/locale' in some places and 'config/locales' in others. Looking at the comment in enviroment.rb and from experience it should be 'config/locales' in all instances.</li> <li>The sentence which reads 'The default environment.rb files has instruction how to add locales from another directory and how to set a different default locale.' would read better as 'The default environment.rb file has instructions on how to add locales from another directory and how to set a different default locale.'</li> <li>The sentence beginning 'As a user you should always only access the public methods...' <em>may</em> read better as 'As a user you should only ever access the public methods...'</li> </ul></div> true 2009-04-24T21:23:48+01:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-04-24T21:23:51+01:00 55143 Paul Gillard Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 7211 0 Paul would you like to contribute those changes yourself? If that was the case please just PM lifo to join docrails. <div><p>Paul would you like to contribute those changes yourself? If that was the case please just PM lifo to join docrails.</p></div> true 2009-04-24T22:36:31+01:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-04-24T22:36:32+01:00 11378 Xavier Noria Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 7211 0 Hello Paul, thanks for the report! I have fixed the `config/locale(s)` issue, and put your better wording of environment.rb example in. * http://github.com/lifo/docrails/commit/7163b64d32fa57ce9bd78710aea2fe0d2283522f * http://github.com/lifo/docrails/commit/4f623f5f89b5d2e3299f16314880e3c75d6b2c6a I would keep the last item as it is now. As a user one definitely _should_ only access public methods, but there are quite valid cases for "disobeying" .). Eg. force-initializing the locale loading/parsing, etc. Thanks again!, Karel <div><p>Hello Paul,</p> <p>thanks for the report! I have fixed the <code>config/locale(s)</code> issue, and put your better wording of environment.rb example in.</p> <ul> <li><a href="http://github.com/lifo/docrails/commit/7163b64d32fa57ce9bd78710aea2fe0d2283522f"> http://github.com/lifo/docrails/...</a></li> <li><a href="http://github.com/lifo/docrails/commit/4f623f5f89b5d2e3299f16314880e3c75d6b2c6a"> http://github.com/lifo/docrails/...</a></li> </ul> <p>I would keep the last item as it is now. As a user one definitely <em>should</em> only access public methods, but there are quite valid cases for "disobeying" .). Eg. force-initializing the locale loading/parsing, etc.</p> <p>Thanks again!,</p> <p>Karel</p></div> true 2009-04-25T10:36:24+01:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-04-25T10:36:27+01:00 16364 Karel Minařík Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 7211 0 One thing the guide doesn't mention is the use of I18n in model constant during production mode. When the models are loaded, I18n hasn't loaded the app locales, so a translation missing text gets put there instead. Then the model is cached in production mode and every subsequent request returns that missing text. I haven't found a solution that works without modification to all calls to the constant. Any ideas? <div><p>One thing the guide doesn't mention is the use of I18n in model constant during production mode.</p> <p>When the models are loaded, I18n hasn't loaded the app locales, so a translation missing text gets put there instead.</p> <p>Then the model is cached in production mode and every subsequent request returns that missing text.</p> <p>I haven't found a solution that works without modification to all calls to the constant. Any ideas?</p></div> true 2009-07-08T00:21:02+01:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-07-08T00:21:07+01:00 26790 Kieran P Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 7211 0 Furthermore, the above issues with translations not being loaded also affects validations. :message => I18n.t('') doesn't work for example (missing translation). Not sure whether this is a bug, or something to work around... <div><p>Furthermore, the above issues with translations not being loaded also affects validations. :message =&gt; I18n.t('') doesn't work for example (missing translation). Not sure whether this is a bug, or something to work around...</p></div> true 2009-07-08T00:38:51+01:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-07-08T00:38:57+01:00 26790 Kieran P Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 7211 0 @Kieran using constants for storing strings won't work, since as you point out it won't observe the current locale. A similar issue with the message validations, since the "I18n.t" is evaluated to form the message at class-loading time. <div><p>@Kieran using constants for storing strings won't work, since as you point out it won't observe the current locale. A similar issue with the message validations, since the "I18n.t" is evaluated to form the message at class-loading time.</p></div> true 2009-07-08T01:09:28+01:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-07-08T01:09:34+01:00 22258 Mike Champion Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 0 Hi, small chages, work's for me on rails 2.3.2: http://guides.rubyonrails.org/i18n.html#setting-the-locale-from-the-domain-name <code> def set_locale I18n.locale = extract_locale_from_tld end def extract_locale_from_tld # !! there is _uri call and _tld definition in guide parsed_domain = request.host.split('.').last locale = DOMAIN_LOCALE_MAP.has_key?(parsed_domain) ? DOMAIN_LOCALE_MAP[parsed_domain] : parsed_domain (I18n.available_locales.include? locale.to_sym) ? locale : nil end </code> Where DOMAIN_LOCALE_MAP is hash in environment: <code> # Map 1. level domain on locale DOMAIN_LOCALE_MAP = { 'com' => 'cz', 'eu' => 'en' } </code> <div><p>Hi, small chages, work's for me on rails 2.3.2:<br> <a href= "http://guides.rubyonrails.org/i18n.html#setting-the-locale-from-the-domain-name"> http://guides.rubyonrails.org/i18n.html#setting-the-locale-from-the...</a><br> <code><br> def set_locale<br> I18n.locale = extract_locale_from_tld end</code></p> <p>def extract_locale_from_tld # !! there is <em>uri call and</em> tld definition in guide<br> parsed_domain = request.host.split('.').last locale = DOMAIN_LOCALE_MAP.has_key?(parsed_domain) ? DOMAIN_LOCALE_MAP[parsed_domain] : parsed_domain (I18n.available_locales.include? locale.to_sym) ? locale : nil end<br> <br> Where DOMAIN_LOCALE_MAP is hash in environment:<br> <code><br></code></p> <h1>Map 1. level domain on locale</h1> <p>= { 'com' =&gt; 'cz', 'eu' =&gt; 'en' }</p></div> true 2009-07-23T15:52:39+01:00 1366 --- :assigned_user: 7211 21487 23 rails-i18 0 16213 published guides i18n 2009-07-23T15:52:43+01:00 63782 PEpe Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 0 my first post, sorry for formatting, again: Hi, small chages, work's for me on rails 2.3.2: http://guides.rubyonrails.org/i18n.html#setting-the-locale-from-the-domain-name @@@ ruby def set_locale I18n.locale = extract_locale_from_tld end def extract_locale_from_tld # !! there is uri call and tld definition in guide parsed_domain = request.host.split('.').last locale = DOMAIN_LOCALE_MAP.has_key?(parsed_domain) ? DOMAIN_LOCALE_MAP[parsed_domain] : parsed_domain (I18n.available_locales.include? locale.to_sym) ? locale : nil end @@@ Where DOMAIN_LOCALE_MAP is hash in environment: @@@ ruby # Map 1. level domain on locale DOMAIN_LOCALE_MAP = { 'com' => 'cz', 'eu' => 'en' } @@@ <div><p>my first post, sorry for formatting, again:</p> <p>Hi, small chages, work's for me on rails 2.3.2: <a href= "http://guides.rubyonrails.org/i18n.html#setting-the-locale-from-the-domain-name"> http://guides.rubyonrails.org/i18n.html#setting-the-locale-from-the...</a></p> <pre> <code class="ruby">def set_locale I18n.locale = extract_locale_from_tld end def extract_locale_from_tld # !! there is uri call and tld definition in guide parsed_domain = request.host.split('.').last locale = DOMAIN_LOCALE_MAP.has_key?(parsed_domain) ? DOMAIN_LOCALE_MAP[parsed_domain] : parsed_domain (I18n.available_locales.include? locale.to_sym) ? locale : nil end</code> </pre> <p>Where DOMAIN_LOCALE_MAP is hash in environment:</p> <pre> <code class="ruby"># Map 1. level domain on locale DOMAIN_LOCALE_MAP = { 'com' =&gt; 'cz', 'eu' =&gt; 'en' }</code> </pre></div> true 2009-07-23T15:58:11+01:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-07-23T15:58:14+01:00 63782 PEpe Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 I think the existing example in the guide is both clear and brief. It is written in a way that supports ".com" by returning nil. If the reader has specific needs for other TLDs like ".eu" I think she can extend the example easily like your did. In my opinion the example is fine as is. Nevertheless, I added the .to_sym bits and removed some stuff related to Rails 2.2. Thanks! <div><p>I think the existing example in the guide is both clear and brief. It is written in a way that supports ".com" by returning nil.</p> <p>If the reader has specific needs for other TLDs like ".eu" I think she can extend the example easily like your did. In my opinion the example is fine as is.</p> <p>Nevertheless, I added the .to_sym bits and removed some stuff related to Rails 2.2.</p> <p>Thanks!</p></div> true 2009-07-25T10:09:13+01:00 1366 --- :assigned_user: 21487 23 rails-i18 0 16213 published guides i18n 2009-07-25T10:09:16+01:00 11378 Xavier Noria Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 detail, but there is still call extract_locale_from_**uri** and def extract_locale_from_**tld** method <div><p>detail, but there is still call extract_locale_from<em><strong>uri</strong> and def extract_locale_from</em><strong>tld</strong> method</p></div> true 2009-07-31T17:40:17+01:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-07-31T17:40:20+01:00 63782 PEpe Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Thanks for the great guide! One minor comment though: I guess something has changed in the URLs of the the I18n wiki pages, since all URLs starting with http://rails-i18n.org/wiki/pages/ are broken and work when replaced with http://rails-i18n.org/wiki/wikipages/ <div><p>Thanks for the great guide!</p> <p>One minor comment though: I guess something has changed in the URLs of the the I18n wiki pages, since all URLs starting with<br> <a href= "http://rails-i18n.org/wiki/pages/">http://rails-i18n.org/wiki/pages/</a> are broken and work when replaced with<br> <a href= "http://rails-i18n.org/wiki/wikipages/">http://rails-i18n.org/wiki/wikipages/</a></p></div> true 2009-12-24T20:47:42+00:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-12-24T20:47:47+00:00 80709 veger Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Thank you verger, it is fixed in the repo now. <div><p>Thank you verger, it is fixed in the repo now.</p></div> true 2009-12-25T22:06:00+00:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2009-12-25T22:06:03+00:00 11378 Xavier Noria Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2 1366 0 Rails 2.3.5 vendored activesupport i18n (comes with Rails 2.3.5) AND gem i18n (0.3.3) Reiterating what holli said (Feb 25th 2009) Example snippet taken from http://guides.rubyonrails.org/i18n.html @@@ ruby ## environment.rb module I18n def just_raise_that_exception(*args) raise args.first end end I18n.exception_handler = :just_raise_that_exception ## some_view_file.html.erb <%= t '.bad_key' %> @@@ Does not appear to re-raise the exception using the exception handler that I have just set, nor does it seem to use the default_exception_handler. Also did not work from the console when calling translate with a bad key: @@@ bash >> I18n.t '.bad_key' NoMethodError: undefined method `just_raise_that_exception' for I18n:Module from /Library/Ruby/Gems/1.8/gems/i18n-0.3.3/lib/i18n.rb:261:in `send' from /Library/Ruby/Gems/1.8/gems/i18n-0.3.3/lib/i18n.rb:261:in `handle_exception' from /Library/Ruby/Gems/1.8/gems/i18n-0.3.3/lib/i18n.rb:211:in `t' from (irb):1 @@@ First problem is that the exception handler needs to be defined as: @@@ ruby module I18n def self.just_raise_that_exception(*args) ... end end @@@ However, this STILL doesn't work in a Rails app proper when using the translate helper. The reason for this is due to ActionView helpers trying to rescue the exception as such: @@@ ruby ## ActionView::Helpers::TranslationHelper def translate(key, options = {}) options[:raise] = true I18n.translate(scope_key_by_partial(key), options) rescue I18n::MissingTranslationData => e keys = I18n.send(:normalize_translation_keys, e.locale, e.key, e.options[:scope]) content_tag('span', keys.join(', '), :class => 'translation_missing') end alias :t :translate @@@ There are two workarounds that I can see for this - either overwrite the existing helper method, or to use I18n.t instead Could the segment about exception handling please be rewritten to reflect the above? Thanks <div><p>Rails 2.3.5<br> vendored activesupport i18n (comes with Rails 2.3.5) AND gem i18n (0.3.3)</p> <p>Reiterating what holli said (Feb 25th 2009)</p> <p>Example snippet taken from <a href= "http://guides.rubyonrails.org/i18n.html">http://guides.rubyonrails.org/i18n.html</a></p> <pre> <code class="ruby"> ## environment.rb module I18n def just_raise_that_exception(*args) raise args.first end end I18n.exception_handler = :just_raise_that_exception ## some_view_file.html.erb &lt;%= t '.bad_key' %&gt;</code> </pre> <p>Does not appear to re-raise the exception using the exception handler that I have just set, nor does it seem to use the default_exception_handler.</p> <p>Also did not work from the console when calling translate with a bad key:</p> <pre> <code class="bash"> &gt;&gt; I18n.t '.bad_key' NoMethodError: undefined method `just_raise_that_exception' for I18n:Module from /Library/Ruby/Gems/1.8/gems/i18n-0.3.3/lib/i18n.rb:261:in `send' from /Library/Ruby/Gems/1.8/gems/i18n-0.3.3/lib/i18n.rb:261:in `handle_exception' from /Library/Ruby/Gems/1.8/gems/i18n-0.3.3/lib/i18n.rb:211:in `t' from (irb):1</code> </pre> <p>First problem is that the exception handler needs to be defined as:</p> <pre> <code class="ruby"> module I18n def self.just_raise_that_exception(*args) ... end end</code> </pre> <p>However, this STILL doesn't work in a Rails app proper when using the translate helper.</p> <p>The reason for this is due to ActionView helpers trying to rescue the exception as such:</p> <pre> <code class="ruby"> ## ActionView::Helpers::TranslationHelper def translate(key, options = {}) options[:raise] = true I18n.translate(scope_key_by_partial(key), options) rescue I18n::MissingTranslationData =&gt; e keys = I18n.send(:normalize_translation_keys, e.locale, e.key, e.options[:scope]) content_tag('span', keys.join(', '), :class =&gt; 'translation_missing') end alias :t :translate</code> </pre> <p>There are two workarounds that I can see for this - either overwrite the existing helper method, or to use I18n.t instead</p> <p>Could the segment about exception handling please be rewritten to reflect the above?</p> <p>Thanks</p></div> true 2010-02-04T00:21:18+00:00 1366 --- {} 21487 23 rails-i18 0 16213 published guides i18n 2010-02-04T00:21:21+00:00 25224 omarqureshi Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/23 Guides Batch 2