1366 0 false 2008-09-04T14:48:43+01:00 1366 2009-05-01T00:00:00+01:00 34116 8 update-testing-guide 2 16213 taken testcase testing unit 2009-11-08T07:08:46+00:00 75790 PizzaMan Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 * Cover all the new assert_* features * Intergration testing * Autotest * Useful plugins * A little bit about RSpec with links to detailed introductions * Cover all the new assert_* features * Intergration testing * Autotest * Useful plugins * A little bit about RSpec with links to detailed introductions <div><ul> <li>Cover all the new assert_* features</li> <li>Intergration testing</li> <li>Autotest</li> <li>Useful plugins</li> <li>A little bit about RSpec with links to detailed introductions</li> </ul></div> 1366 0 * Cover all the new assert_* features * Intergration testing * Autotest * Useful plugins * A little bit about RSpec with links to detailed introductions <div><ul> <li>Cover all the new assert_* features</li> <li>Intergration testing</li> <li>Autotest</li> <li>Useful plugins</li> <li>A little bit about RSpec with links to detailed introductions</li> </ul></div> false 2008-09-04T14:48:45+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-04T14:48:45+01:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 I have started work on this. Cheers! <div><p>I have started work on this. Cheers!</p></div> false 2008-09-04T23:43:05+01:00 1366 --- {} 8 update-testing-guide-2 0 16213 new 2008-09-04T23:43:05+01:00 31071 Akshay Surve Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 Though this ticket mentions *update* I would like to take this opportunity to restructure the testing guide in a more Rails centric way and also get it up-to date. I would also try to retain parts of this guide which are still relevant and fun to read. In the next couple of days I shall update this ticket first with the skeleton of the guide I am working on and then with the initial draft. Thanks. <div><p>Though this ticket mentions <em>update</em> I would like to take this opportunity to restructure the testing guide in a more Rails centric way and also get it up-to date. I would also try to retain parts of this guide which are still relevant and fun to read.</p> <p>In the next couple of days I shall update this ticket first with the skeleton of the guide I am working on and then with the initial draft. Thanks.</p></div> false 2008-09-09T00:38:30+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-09T00:38:36+01:00 31071 Akshay Surve Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 For what it's worth, the example in 3.1 should have return false if @password == 'stirred' return false if @password == 'password' As it is, it is missing the == on both lines, and it wrongly includes a curly quote before "password". In case that helps. Thanks for updating it! <div><p>For what it's worth, the example in 3.1 should have</p> <pre> <code>return false if @password == 'stirred' return false if @password == 'password' </code> </pre> <p>As it is, it is missing the == on both lines, and it wrongly includes a curly quote before "password".</p> <p>In case that helps.</p> <p>Thanks for updating it!</p></div> false 2008-09-09T03:55:27+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-09T03:55:32+01:00 31193 charliepark Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 Sure, feel free to restructure it if it improves things. <div><p>Sure, feel free to restructure it if it improves things.</p></div> false 2008-09-09T14:37:16+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-09T14:37:21+01:00 10679 Hongli Lai Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 Hey Akshay, Any updates on this ? Thanks. <div><p>Hey Akshay,</p> <p>Any updates on this ?</p> <p>Thanks.</p></div> false 2008-09-14T00:32:20+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-14T00:32:24+01:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 Since its a major change to the current guide, I haven't made any commits to docrails. You can find the latest version of the guide (with my notes) I am working on here: http://docs.google.com/Doc?id=dhgrdvkp_82dprb63d6 Summary: * Have tried to structure the guide in a more Rails centric order * Examples adhere to Rails 2.1.x * It doesn't adhere to asciidoc format as of now. Taking it forward: * I would be working towards freezing the guide till the point it could replace the current guide * Work on the additional areas (autotest, plugins, rspec) --- I am not sure if its the right time for me to *ask* for specific feedback but feel free to chip in with your suggestions and I would do my best to incorporate it. <div><p>Since its a major change to the current guide, I haven't made any commits to docrails. You can find the latest version of the guide (with my notes) I am working on here:</p> <p><a href="http://docs.google.com/Doc?id=dhgrdvkp_82dprb63d6">http://docs.google.com/Doc?id=dh...</a></p> <p>Summary: * Have tried to structure the guide in a more Rails centric order * Examples adhere to Rails 2.1.x * It doesn't adhere to asciidoc format as of now.</p> <p>Taking it forward: * I would be working towards freezing the guide till the point it could replace the current guide * Work on the additional areas (autotest, plugins, rspec)</p> <hr> <p>I am not sure if its the right time for me to <em>ask</em> for specific feedback but feel free to chip in with your suggestions and I would do my best to incorporate it.</p></div> false 2008-09-15T04:05:03+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-15T12:28:27+01:00 31071 Akshay Surve Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 You should just convert it to ASCIIdoc and commit to docrails. Shouldn't really focus on "additional areas". It's fine to mention rspec/plugins etc. and what they do in a very brief fashion, though. And just link to external pages giving more details. <div><p>You should just convert it to ASCIIdoc and commit to docrails.</p> <p>Shouldn't really focus on "additional areas". It's fine to mention rspec/plugins etc. and what they do in a very brief fashion, though. And just link to external pages giving more details.</p></div> false 2008-09-17T17:06:48+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-17T17:06:51+01:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 Yes, that makes sense. I shall convert and commit it. <div><p>Yes, that makes sense. I shall convert and commit it.</p></div> false 2008-09-20T16:24:16+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-20T16:24:22+01:00 31071 Akshay Surve Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 I have converted most of it to ASCIIdoc and update some sections. Shall be committing it later tonight. <div><p>I have converted most of it to ASCIIdoc and update some sections. Shall be committing it later tonight.</p></div> false 2008-09-24T10:17:50+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-24T10:17:53+01:00 31071 Akshay Surve Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 Committed the initial changes. Iterations shall be quick and more regular. <div><p>Committed the initial changes. Iterations shall be quick and more regular.</p></div> false 2008-09-25T14:17:46+01:00 1366 --- {} 8 update-testing-guide 0 16213 new 2008-09-25T14:17:50+01:00 31071 Akshay Surve Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 1366 0 false 2008-09-30T00:08:48+01:00 1366 --- :milestone: 20253 8 update-testing-guide 0 16213 new 2008-09-30T00:08:53+01:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 1366 0 I have made a series of updates to the testing guide. Highlights: * The sections have been re-organized * All sample codes have been updated to Rails 2.1 * Adds a section for Integration testing Todo: * Additional notes regarding rspec etc. that anyone would like to suggest. I look forward for your suggestions and review. <div><p>I have made a series of updates to the testing guide.</p> <p>Highlights:</p> <ul> <li>The sections have been re-organized</li> <li>All sample codes have been updated to Rails 2.1</li> <li>Adds a section for Integration testing</li> </ul> <p>Todo:</p> <ul> <li>Additional notes regarding rspec etc. that anyone would like to suggest.</li> </ul> <p>I look forward for your suggestions and review.</p></div> false 2008-10-12T14:21:33+01:00 1366 --- {} 20253 8 update-testing-guide 0 16213 new 2008-10-12T14:21:38+01:00 31071 Akshay Surve Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 1366 0 I just pushed up an edit/formatting pass over this one. <div><p>I just pushed up an edit/formatting pass over this one.</p></div> false 2008-10-15T02:30:33+01:00 1366 --- {} 20253 8 update-testing-guide 0 16213 new 2008-10-15T02:30:39+01:00 7211 Mike Gunderloy Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 7211 0 false 2008-10-15T02:31:31+01:00 1366 --- :assigned_user: 1366 20253 8 update-testing-guide 0 16213 new 2008-10-15T02:31:35+01:00 7211 Mike Gunderloy Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 7211 0 Thanks Mike, it reads much better now. <div><p>Thanks Mike, it reads much better now.</p></div> false 2008-10-21T19:47:14+01:00 1366 --- {} 20253 8 update-testing-guide 0 16213 new 2008-10-21T19:47:16+01:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 7211 0 Suggestion on testing controllers. I think an example on how to test nested resources would be welcome as well. Before you know it's as simple as setting an additional :parent_id in the first hash, it's not necessarily obvious. <div><p>Suggestion on testing controllers.</p> <p>I think an example on how to test nested resources would be welcome as well. Before you know it's as simple as setting an additional :parent_id in the first hash, it's not necessarily obvious.</p></div> false 2008-10-22T16:17:42+01:00 1366 --- {} 20253 8 update-testing-guide 0 16213 new 2008-10-22T16:17:46+01:00 14677 webmat Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 7211 0 Hey, Sorry for the long feedback! But here we go https://gist.github.com/0a5a916f50fedb9cf995 <div><p>Hey,</p> <p>Sorry for the long feedback! But here we go <a href="https://gist.github.com/0a5a916f50fedb9cf995">https://gist.github.com/0a5a916f...</a></p></div> false 2008-10-26T19:36:02+00:00 1366 --- {} 20253 8 update-testing-guide 0 16213 new 2008-10-26T19:36:03+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 7211 0 Thanks webmat and Pratik. I shall go through and try to incorporate your feedback. Cheers <div><p>Thanks webmat and Pratik. I shall go through and try to incorporate your feedback. Cheers</p></div> false 2008-10-29T11:15:17+00:00 1366 --- {} 20253 8 update-testing-guide 0 16213 new 2008-10-29T11:15:19+00:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 7211 0 false 2008-11-03T16:59:04+00:00 1366 --- :state: new 20253 8 update-testing-guide 0 16213 taken 2008-11-03T16:59:08+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides batch 1 7211 0 false 2008-11-03T17:00:54+00:00 1366 --- :milestone: 20253 21487 8 update-testing-guide 0 16213 taken 2008-11-03T17:00:55+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Marking the guide as "available" making it up for grab again as there hasn't been any progress, as decided by Rails guides team. <div><p>Marking the guide as "available" making it up for grab again as there hasn't been any progress, as decided by Rails guides team.</p></div> false 2008-11-11T00:42:20+00:00 1366 --- :state: taken 21487 8 update-testing-guide 0 16213 available 2008-11-11T00:42:23+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Pratik, if the guide team allows me I would like to pick this up again and do the final honors of tidying up the loose ends and escorting it upto the resolved state. <div><p>Pratik, if the guide team allows me I would like to pick this up again and do the final honors of tidying up the loose ends and escorting it upto the resolved state.</p></div> false 2008-11-11T01:10:06+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 available 2008-11-11T01:10:09+00:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Mike, if the guide team allows me I would like to pick this up again and do the final honors of tidying up the loose ends and escorting it upto the resolved state. <div><p>Mike, if the guide team allows me I would like to pick this up again and do the final honors of tidying up the loose ends and escorting it upto the resolved state.</p></div> false 2008-11-11T01:10:20+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 available 2008-11-11T01:10:26+00:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Keeping it on hold. <div><p>Keeping it on hold.</p></div> false 2008-11-11T01:16:01+00:00 1366 --- :state: available 21487 8 update-testing-guide 0 16213 taken 2008-11-11T01:16:02+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Akshay, we'd be happy to have you finish things. Can you make some commitment as to when you'll have a draft incorporating the feedback from Pratik? <div><p>Akshay, we'd be happy to have you finish things. Can you make some commitment as to when you'll have a draft incorporating the feedback from Pratik?</p></div> false 2008-11-12T18:22:28+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2008-11-12T18:22:34+00:00 7211 Mike Gunderloy Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Thanks, I really appreciate it. I have incorporated feedback from Pratik in my latest commit because of which this guide now feels really closer to completion. Also, I would like to mention here that I have intentionally kept the section on Test::Unit later in the guide to keep the focus on getting started with testing in Rails. Later in the guide I have briefly mentioned Test::Unit so that adventurous user can explore further. Feel free to share your views and feedback. Thanks <div><p>Thanks, I really appreciate it. I have incorporated feedback from Pratik in my latest commit because of which this guide now feels really closer to completion.</p> <p>Also, I would like to mention here that I have intentionally kept the section on Test::Unit later in the guide to keep the focus on getting started with testing in Rails. Later in the guide I have briefly mentioned Test::Unit so that adventurous user can explore further.</p> <p>Feel free to share your views and feedback. Thanks</p></div> false 2008-11-13T04:16:15+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2008-11-13T04:16:20+00:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Feedback from earlier comments has been incorporated with which the guide has really come together. Feel free to share you opinion. <div><p>Feedback from earlier comments has been incorporated with which the guide has really come together. Feel free to share you opinion.</p></div> false 2008-11-21T12:44:04+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2008-11-21T12:44:05+00:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 The source code formatting in "3.1.1. Rake Tasks for Preparing you Application for Testing" is off. <div><p>The source code formatting in "3.1.1. Rake Tasks for Preparing you Application for Testing" is off.</p></div> false 2008-12-11T02:24:36+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2008-12-11T02:24:38+00:00 12529 Luke Amdor Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Thanks Luke. This has been fixed and should appear right on the guides website once the guide is re-generated and deployed. <div><p>Thanks Luke. This has been fixed and should appear right on the guides website once the guide is re-generated and deployed.</p></div> false 2008-12-11T08:31:31+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2008-12-11T08:31:35+00:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Hey Akshay, Sorry we've been slacking. Will get this guide done for 2.3 final release. Thanks. <div><p>Hey Akshay,</p> <p>Sorry we've been slacking. Will get this guide done for 2.3 final release.</p> <p>Thanks.</p></div> false 2009-02-04T03:40:09+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-04T03:40:11+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Great no worries. Let me know if I can be of any help; I shall try to keep up with 2.3 and try to address any changes in it. Cheers. <div><p>Great no worries. Let me know if I can be of any help; I shall try to keep up with 2.3 and try to address any changes in it. Cheers.</p></div> false 2009-02-04T11:57:09+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-04T11:57:15+00:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 The Test::Unit section currently shows def test_truth. Should it be test "the truth" do to match more recent versions of Rails? <div><p>The Test::Unit section currently shows def test_truth. Should it be test "the truth" do to match more recent versions of Rails?</p></div> false 2009-02-04T14:06:47+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-04T14:06:52+00:00 10900 Dan Croak Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 A later example is: @@@def test_should_not_save_post_without_title post = Post.new assert !post.save end @@@ Should this also be changed to use the test "name" &block style? Given the name of the test, I would also argue good practice is to explicitly set the Post's title to nil: @@@test "should not save post without title" do post = Post.new(:title => nil) assert !post.save end @@@ <div><p>A later example is:</p> <p>@@@def test_should_not_save_post_without_title post = Post.new assert !post.save end</p> <pre><code> Should this also be changed to use the test &quot;name&quot; &amp;block style? Given the name of the test, I would also argue good practice is to explicitly set the Post's title to nil: @@@test &quot;should not save post without title&quot; do post = Post.new(:title =&gt; nil) assert !post.save end </code></pre></div> false 2009-02-04T14:11:23+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-04T14:11:25+00:00 10900 Dan Croak Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Dan, You raise valid issues. Do you want to make the changes to the guide straight away ? I could add you to docrails if you tell me your github username. Thanks! <div><p>Dan,</p> <p>You raise valid issues. Do you want to make the changes to the guide straight away ? I could add you to docrails if you tell me your github username.</p> <p>Thanks!</p></div> false 2009-02-04T14:16:12+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-04T14:16:13+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 At 3.1.1. in the tip you read: You can see all these rake tasks and their descriptions by running rake \-\-tasks \-\-describe It should be: You can see all these rake tasks and their descriptions by running rake --tasks --describe Thanks for your work! <div><p>At 3.1.1. in the tip you read: You can see all these rake tasks and their descriptions by running rake --tasks --describe</p> <p>It should be: You can see all these rake tasks and their descriptions by running rake --tasks --describe</p> <p>Thanks for your work!</p></div> false 2009-02-04T23:34:25+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-04T23:34:28+00:00 24994 Rafa G. Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Ouch! It eats the slashes. Repeat myself, At 3.1.1 section in the tip you read: You can see all these rake tasks and their descriptions by running rake {slash}-{slash}-tasks {slash}-{slash}-describe It should be the same without slahes. Again, thanks. <div><p>Ouch! It eats the slashes. Repeat myself, At 3.1.1 section in the tip you read: You can see all these rake tasks and their descriptions by running rake {slash}-{slash}-tasks {slash}-{slash}-describe</p> <p>It should be the same without slahes. Again, thanks.</p></div> false 2009-02-04T23:40:41+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-04T23:40:46+00:00 24994 Rafa G. Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 @Rafa: Thanks, for pointing that out. I am a lil confused for the right syntax to display it. Any ideas? <div><p>@Rafa: Thanks, for pointing that out. I am a lil confused for the right syntax to display it. Any ideas?</p></div> false 2009-02-05T00:16:45+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-05T00:16:49+00:00 31071 Akshay Surve Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 <tt>rake --tasks --describe</tt> should work, I think <div><p><tt>rake --tasks --describe</tt></p> <p>should work, I think</p></div> false 2009-02-05T00:22:06+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-05T00:22:11+00:00 7211 Mike Gunderloy Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Oh, bah. Stupid formatting.... <pre><code>&lt;tt&gt;rake --tasks --describe&lt;/tt&gt;</code></pre> <div><p>Oh, bah. Stupid formatting....</p> <pre> <code>&lt;tt&gt;rake --tasks --describe&lt;/tt&gt;</code> </pre></div> false 2009-02-05T00:23:10+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-05T00:23:15+00:00 7211 Mike Gunderloy Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 As said Mike Gunderloy it's ok. <div><p>As said Mike Gunderloy it's ok.</p></div> false 2009-02-05T16:19:57+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-05T16:20:02+00:00 24994 Rafa G. Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Pratik, Sure, I can make the changes to the guide. My github name is dancroak. Thanks, Dan <div><p>Pratik,</p> <p>Sure, I can make the changes to the guide.</p> <p>My github name is dancroak.</p> <p>Thanks, Dan</p></div> false 2009-02-07T20:34:50+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-07T20:34:55+00:00 10900 Dan Croak Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 Hey Dan, Added you to docrails. Guides are inside railties/guides/source. Lemme know if you have any trouble updating the guide. Thanks! <div><p>Hey Dan,</p> <p>Added you to docrails. Guides are inside railties/guides/source. Lemme know if you have any trouble updating the guide.</p> <p>Thanks!</p></div> false 2009-02-07T20:36:27+00:00 1366 --- {} 21487 8 update-testing-guide 0 16213 taken 2009-02-07T20:36:28+00:00 1366 Pratik Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 2 7211 0 false 2009-03-15T00:26:44+00:00 1366 --- :milestone: 21487 34116 8 update-testing-guide 0 16213 taken 2009-03-15T00:26:46+00:00 7211 Mike Gunderloy Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 7211 0 assert_valid has been deprecated - thanks! http://github.com/rails/rails/commit/d4754677a34d34d4a0955a04f2cc6571bdc5e82d <div><p>assert_valid has been deprecated - thanks! <a href="http://github.com/rails/rails/commit/d4754677a34d34d4a0955a04f2cc6571bdc5e82d"> http://github.com/rails/rails/co...</a></p></div> false 2009-03-19T09:26:06+00:00 1366 --- {} 34116 8 update-testing-guide 0 16213 taken 2009-03-19T09:26:09+00:00 51218 David Kahn Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 7211 0 The [functional testing section of this guide][1] should show an example including the necessary class definition: class FooControllerTest < ActionController::TestCase The only examples in the guide currently show inheriting from either `ActiveSupport::TestCase` (for unit tests) or `ActionController::IntegrationTest` (for integration tests). I was trying to use the former for a controller test and was faced with a "undefined method `get`" error. I finally found the correct class in a random discussion thread. [1]: http://guides.rubyonrails.org/testing.html#functional-tests-for-your-controllers <div><p>The [functional testing section of this guide][1] should show an example including the necessary class definition:</p> <pre> <code>class FooControllerTest &lt; ActionController::TestCase </code> </pre> <p>The only examples in the guide currently show inheriting from either <code>ActiveSupport::TestCase</code> (for unit tests) or <code>ActionController::IntegrationTest</code> (for integration tests). I was trying to use the former for a controller test and was faced with a "undefined method <code>get</code>" error. I finally found the correct class in a random discussion thread.</p> <p><a href="/projects/16213/changesets/1" title="Changeset #1">[1]</a>: <a href="http://guides.rubyonrails.org/testing.html#functional-tests-for-your-controllers"> http://guides.rubyonrails.org/te...</a></p></div> false 2009-04-14T01:50:55+01:00 1366 --- {} 34116 8 update-testing-guide 0 16213 taken 2009-04-14T01:50:56+01:00 12388 Brad Fults Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 7211 0 I think the Testing Routes section should be significantly expanded (covering complicated routing situations, etc.). If nothing else, it should at least suggest _where_ you should put your routing tests (unit, functional, integration, etc.). <div><p>I think the Testing Routes section should be significantly expanded (covering complicated routing situations, etc.).</p> <p>If nothing else, it should at least suggest <em>where</em> you should put your routing tests (unit, functional, integration, etc.).</p></div> false 2009-05-14T20:57:56+01:00 1366 --- {} 34116 8 update-testing-guide 0 16213 taken 2009-05-14T20:58:00+01:00 17425 Alderete Pratik Mike Gunderloy http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 0 As I user, I find it confusing that the default test generated by rails 2.3.2 does not match what is in the guide. In particular where the guide shows this code @@@ ruby class PostTest < ActiveSupport::TestCase # Replace this with your real tests. def test_truth assert true end end @@@ code generated by Rails 2.3.2 script/generate looks like this: @@@ ruby class PostTest < ActiveSupport::TestCase # Replace this with your real tests. test "the truth" do assert true end end @@@ <div><p>As I user, I find it confusing that the default test generated by rails 2.3.2 does not match what is in the guide. In particular where the guide shows this code</p> <pre> <code class="ruby">class PostTest &lt; ActiveSupport::TestCase # Replace this with your real tests. def test_truth assert true end end</code> </pre> <p>code generated by Rails 2.3.2 script/generate looks like this:</p> <pre> <code class="ruby">class PostTest &lt; ActiveSupport::TestCase # Replace this with your real tests. test "the truth" do assert true end end</code> </pre></div> false 2009-06-10T14:26:51+01:00 1366 --- :tag: :assigned_user: 7211 34116 8 update-testing-guide 0 16213 taken testcase testing unit 2009-06-10T14:26:51+01:00 52980 Gustavo Delfino Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 1366 0 rake test:uncommitted now supposedly has Git support (from rake -T). <div><p>rake test:uncommitted now supposedly has Git support (from rake -T).</p></div> false 2009-06-19T04:27:16+01:00 1366 --- :assigned_user: 34116 8 update-testing-guide 0 16213 taken testcase testing unit 2009-06-19T04:27:21+01:00 49833 Ben Carpenter Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 1366 0 Could a section on testing helpers be added too? Thanks! <div><p>Could a section on testing helpers be added too? Thanks!</p></div> false 2009-07-17T18:34:39+01:00 1366 --- {} 34116 8 update-testing-guide 0 16213 taken testcase testing unit 2009-07-17T19:56:56+01:00 21548 George Montana Harkin Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 1366 0 (from [a7f09bc12236d9e7bdc2ee34d5fe3c782d6ad385]) docrails [#8] changed old def test_ methods to new test(name, block) style in testing guide http://github.com/lifo/docrails/commit/a7f09bc12236d9e7bdc2ee34d5fe3c782d6ad385 <div><p>(from <a href= "/projects/16213/changesets/a7f09bc12236d9e7bdc2ee34d5fe3c782d6ad385" title= "Changeset [a7f09bc12236d9e7bdc2ee34d5fe3c782d6ad385]">[a7f09bc12236d9e7bdc2ee34d5fe3c782d6ad385]</a>) docrails [<a href="/projects/16213/tickets/8" title= "Ticket #8">#8</a>] changed old def test_ methods to new test(name, block) style in testing guide <a href= "http://github.com/lifo/docrails/commit/a7f09bc12236d9e7bdc2ee34d5fe3c782d6ad385"> http://github.com/lifo/docrails/commit/a7f09bc12236d9e7bdc2ee34d5fe...</a></p></div> false 2009-08-09T18:35:51+01:00 1366 --- {} 34116 8 update-testing-guide 0 16213 taken testcase testing unit 2009-08-09T18:35:52+01:00 1366 Pratik Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 1366 0 Pratik, This is way old (my comments were from February), but the patch still needed to be made: http://github.com/lifo/docrails/commit/a7f09bc12236d9e7bdc2ee34d5fe3c782d6ad385 changed old def test_ methods to new test(name, block) style in testing guide <div><p>Pratik,</p> <p>This is way old (my comments were from February), but the patch still needed to be made:</p> <p><a href= "http://github.com/lifo/docrails/commit/a7f09bc12236d9e7bdc2ee34d5fe3c782d6ad385"> http://github.com/lifo/docrails/commit/a7f09bc12236d9e7bdc2ee34d5fe...</a></p> <p>changed old def test_ methods to new test(name, block) style in testing guide</p></div> false 2009-08-09T18:36:48+01:00 1366 --- {} 34116 8 update-testing-guide 0 16213 taken testcase testing unit 2009-08-09T18:36:54+01:00 10900 Dan Croak Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 1366 0 The code examples does not show any linebreaks on my machine. Windows Vista with SP 1 and Iternet explorer 8. Hmm... Same happens with the "Getting started" tutorial. Both works fine in Firefox on the same machine. <div><p>The code examples does not show any linebreaks on my machine.<br> Windows Vista with SP 1 and Iternet explorer 8.</p> <p>Hmm... Same happens with the "Getting started" tutorial. Both works fine in Firefox on the same machine.</p></div> false 2009-10-29T00:07:29+00:00 1366 --- {} 34116 8 update-testing-guide 0 16213 taken testcase testing unit 2009-10-29T00:07:34+00:00 74618 Samuel Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3 1366 0 I'm new to Rails testing and reading http://guides.rubyonrails.org/testing.html and have a couple suggestions. 1) Section 2.1 - I had a slight problem when I tried the command "rake db:test:prepare" because my test database was not already created in mysql. It might be good to add a note about that. Another option might be to hold off on that command until Section 3.1 which lists the various rake db: commands so then I would have more information about how to create my test database, and then also mention the database create issue there. As it was, as I read Section 2.1 and the command failed there wasn't anything else around it to help me so I had to go to google, if I had seen it in Section 3.1 it would have shown me other options that might help get my test database ready. And now that I reread the last paragraph of Section 2.1, rake db:test:prepare doesn't seem like the correct command if you want to "rebuild it from scratch" (but I'm sill learning all this so I could be wrong). 2) Section 3 is about unit tests but Section 3.5 lists several asserts related to routing that are (no longer?) available from ActiveSupport::TestCase but instead (I think) are in ActionController::TestCase. From the name this would seem to be about testing Controllers but I don't see it mentioned in "Section 4 Functional Tests for Your Controllers". It is shown in Section 5 which is about integration testing. Suggestions: include the class declaration in the first code snippet in Section 4.1 and in Section 9 so the reader knows what class to derive from. Mention somewhere, but preferably when you first list them, that some asserts are not always available and what Class you must derive from to be able to use which assert if it isn't available in all TestCase classes. And, maybe list somewhere early what are the available TestCase classes that can be subclassed. Thanks for all the work on the guides. <div><p>I'm new to Rails testing and reading <a href= "http://guides.rubyonrails.org/testing.html">http://guides.rubyonrails.org/testing.html</a> and have a couple suggestions.</p> <p>1) Section 2.1 - I had a slight problem when I tried the command "rake db:test:prepare" because my test database was not already created in mysql. It might be good to add a note about that. Another option might be to hold off on that command until Section 3.1 which lists the various rake db: commands so then I would have more information about how to create my test database, and then also mention the database create issue there. As it was, as I read Section 2.1 and the command failed there wasn't anything else around it to help me so I had to go to google, if I had seen it in Section 3.1 it would have shown me other options that might help get my test database ready. And now that I reread the last paragraph of Section 2.1, rake db:test:prepare doesn't seem like the correct command if you want to "rebuild it from scratch" (but I'm sill learning all this so I could be wrong).</p> <p>2) Section 3 is about unit tests but Section 3.5 lists several asserts related to routing that are (no longer?) available from ActiveSupport::TestCase but instead (I think) are in ActionController::TestCase. From the name this would seem to be about testing Controllers but I don't see it mentioned in "Section 4 Functional Tests for Your Controllers". It is shown in Section 5 which is about integration testing. Suggestions: include the class declaration in the first code snippet in Section 4.1 and in Section 9 so the reader knows what class to derive from. Mention somewhere, but preferably when you first list them, that some asserts are not always available and what Class you must derive from to be able to use which assert if it isn't available in all TestCase classes. And, maybe list somewhere early what are the available TestCase classes that can be subclassed.</p> <p>Thanks for all the work on the guides.</p></div> false 2009-11-08T07:08:43+00:00 1366 --- {} 34116 8 update-testing-guide 0 16213 taken testcase testing unit 2009-11-08T07:08:46+00:00 75790 PizzaMan Pratik Pratik http://rails.lighthouseapp.com/projects/16213/tickets/8 Guides Batch 3