Immediate flash values not accessible in tests

I modified the test to assert_equal flash.now, but it still doesn't seem to work (patch attached).

I also created a new rails project with a controller action that sets a flash.now message, but wasn't able to access that message in the corresponding functional test. It looks like flash.now is an ActionController::Flash::FlashNow object in the test, but its @flash is empty...

New patch with git metainfo

I dug a little deeper into this problem and found out, that the flash is swept in process_cleanup. A view can display immediate flash values, because it accesses the flash before being swept. However, with test assertions, process_cleanup is done before and therefore the immediate values have been swept already.

So my goal was to make the same flash values available to the test that are used in views. Attached is a patch, that modified flash.rb to do the sweep before processing the request instead on cleanup, plus tests that make sure that normal flash values as well as immediate flash values can be asserted in tests.

Ouch. Even though all tests pass fine, it seems that the flash isn't swept in real applications with this patch.

Attached a new patch where flash sweeping is done after assign_shortcuts, so that @_session can be checked. The previous patch had a problem accessing the session since assign_shortcut wasn't run before.

It now works as expected.

Unfortunately, I can't reopen the ticket.

We took a slightly different approach to the same sorts of problems in ticket 121. Our goal with assert_showing_flash was to confirm that the app uses flash versus flash.now correctly.

I'm getting some failing tests now. I have a feeling its related to one of Pratik's deprecate instance variables commits.

  1) Failure:
test_flash(ComponentsTest)
    [./test/controller/components_test.rb:114:in `test_flash'
     ./test/../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `__send__'
     ./test/../lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:59:in `run']:
<"My stoney baby"> expected but was
<"no flash">.

Looks like my patched flash.rb wasn't aware of component processing. I'm not used to components, but they seem to work by calling process of the component's controller. Previously, that call swept the flash. I modified flash.rb to not sweep the flash if processing a component. I'm not sure why this didn't occur in earlier revisions of rails, but now it looks correct and all tests pass. New patch attached.

Why does the new patch switch to if @_session rather than @_request?

Mmh, not sure. I guess I accidently mixed it up. I changed it back to @_session (attached patch updated).

I'm not sure if the @_session check is needed anyway (except for a tiny runtime improvement if sessions are disabled because the sweep method isn't run). I tried to remove the @_session check and all tests still passed.