424 3 true 2008-11-19T19:07:34+00:00 37059 1419 massive-memory-leak-in-assettag 24 8994 resolved 2.2 actionpack assets patch 2008-11-20T00:03:00+00:00 85 Jeremy Kemper aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 Every time you use a asset tag helper referencing a new asset url, references to the controller/template objects are stored in the AssetTag::Cache and never released. If you render thousands of 3rd party images on your site, each image_tag call creates a hard reference in the AssetTag::Cache, which in turn references the controller/template, not allowing anything created in that request to leave scope, hence you have a massive memory leak. The objects are cached b/c of filesystem access to determine the modified source string. E.g. "foo" -> "/stylesheets/foo.css" The attached patch solves the issue by caching only the modified source strings, which is similar to the previous implementation, with a further optimization of caching only asset paths that are relative. Every time you use a asset tag helper referencing a new asset url, references to the controller/template objects are stored in the AssetTag::Cache and never released. If you render thousands of 3rd party images on your site, each image_tag call creates a hard reference in the AssetTag::Cache, which in turn references the controller/template, not allowing anything created in that request to leave scope, hence you have a massive memory leak. The objects are cached b/c of filesystem access to determine the modified source string. E.g. "foo" -> "/stylesheets/foo.css" The attached patch solves the issue by caching only the modified source strings, which is similar to the previous implementation, with a further optimization of caching only asset paths that are relative. <div><p>Every time you use a asset tag helper referencing a new asset url, references to the controller/template objects are stored in the AssetTag::Cache and never released.</p> <p>If you render thousands of 3rd party images on your site, each image_tag call creates a hard reference in the AssetTag::Cache, which in turn references the controller/template, not allowing anything created in that request to leave scope, hence you have a massive memory leak.</p> <p>The objects are cached b/c of filesystem access to determine the modified source string. E.g. "foo" -&gt; "/stylesheets/foo.css"</p> <p>The attached patch solves the issue by caching only the modified source strings, which is similar to the previous implementation, with a further optimization of caching only asset paths that are relative.</p></div> 0 Every time you use a asset tag helper referencing a new asset url, references to the controller/template objects are stored in the AssetTag::Cache and never released. If you render thousands of 3rd party images on your site, each image_tag call creates a hard reference in the AssetTag::Cache, which in turn references the controller/template, not allowing anything created in that request to leave scope, hence you have a massive memory leak. The objects are cached b/c of filesystem access to determine the modified source string. E.g. "foo" -> "/stylesheets/foo.css" The attached patch solves the issue by caching only the modified source strings, which is similar to the previous implementation, with a further optimization of caching only asset paths that are relative. <div><p>Every time you use a asset tag helper referencing a new asset url, references to the controller/template objects are stored in the AssetTag::Cache and never released.</p> <p>If you render thousands of 3rd party images on your site, each image_tag call creates a hard reference in the AssetTag::Cache, which in turn references the controller/template, not allowing anything created in that request to leave scope, hence you have a massive memory leak.</p> <p>The objects are cached b/c of filesystem access to determine the modified source string. E.g. "foo" -&gt; "/stylesheets/foo.css"</p> <p>The attached patch solves the issue by caching only the modified source strings, which is similar to the previous implementation, with a further optimization of caching only asset paths that are relative.</p></div> false 2008-11-19T19:07:35+00:00 37059 --- {} 9903 1419 massive-memory-leak-in-assettag 0 8994 new 2.2 actionpack assets patch 2008-11-19T19:07:38+00:00 37059 aaronbatalion aaronbatalion http://rails.lighthouseapp.com/projects/8994/tickets/1419 2.x 424 1 false 2008-11-19T19:14:27+00:00 37059 --- :state: new :assigned_user: :milestone: 9903 1419 massive-memory-leak-in-assettag 0 8994 open 2.2 actionpack assets patch 2008-11-19T19:14:30+00:00 85 Jeremy Kemper aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 1 Change looks good to me, josh? <div><p>Change looks good to me, josh?</p></div> false 2008-11-19T19:17:25+00:00 37059 --- {} 1419 massive-memory-leak-in-assettag 0 8994 open 2.2 actionpack assets patch 2008-11-19T19:17:27+00:00 141 Michael Koziarski aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 1 Wrote a quick blog post explaining the issue in more detail. http://blog.hungrymachine.com/2008/11/19/are-your-mongrels-growing-to-600mb-blame-assettag Also, I believe AssetTagCollection has the same problem, and isnt covered in my patch. <div><p>Wrote a quick blog post explaining the issue in more detail. <a href="http://blog.hungrymachine.com/2008/11/19/are-your-mongrels-growing-to-600mb-blame-assettag"> http://blog.hungrymachine.com/20...</a></p> <p>Also, I believe AssetTagCollection has the same problem, and isnt covered in my patch.</p></div> false 2008-11-19T21:11:47+00:00 37059 --- {} 1419 massive-memory-leak-in-assettag 0 8994 open 2.2 actionpack assets patch 2008-11-19T21:11:51+00:00 37059 aaronbatalion aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 1 Attached is an updated patch that accounts for the assettag type being included in the cache key. Including the name of the class is better than self itself, against for hard references. Also added a failing test that now passes. <div><p>Attached is an updated patch that accounts for the assettag type being included in the cache key. Including the name of the class is better than self itself, against for hard references.</p> <p>Also added a failing test that now passes.</p></div> false 2008-11-19T23:15:58+00:00 37059 --- {} 1419 massive-memory-leak-in-assettag 0 8994 open 2.2 actionpack assets patch 2008-11-19T23:16:00+00:00 37059 aaronbatalion aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 2 ah, I hate this cache. I should def look into preloading the asset folder contents on boot. <div><p>ah, I hate this cache. I should def look into preloading the asset folder contents on boot.</p></div> false 2008-11-19T23:22:43+00:00 37059 --- {} 1419 massive-memory-leak-in-assettag 0 8994 open 2.2 actionpack assets patch 2008-11-19T23:22:48+00:00 424 Joshua Peek aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 2 (from [24dbd4b9581ba2affef9e8e96570200ee1e3266c]) Fixed asset host to not cache objects [#1419 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> http://github.com/rails/rails/commit/24dbd4b9581ba2affef9e8e96570200ee1e3266c <div><p>(from [24dbd4b9581ba2affef9e8e96570200ee1e3266c]) Fixed asset host to not cache objects [<a href="/projects/8994/tickets/1419" title="Ticket #1419">#1419</a> state:resolved]</p> <p>Signed-off-by: Joshua Peek <a href="mailto:josh@joshpeek.com">josh@joshpeek.com</a> <a href="http://github.com/rails/rails/commit/24dbd4b9581ba2affef9e8e96570200ee1e3266c"> http://github.com/rails/rails/co...</a></p></div> true 2008-11-19T23:29:11+00:00 37059 --- :state: open 1419 massive-memory-leak-in-assettag 0 8994 resolved 2.2 actionpack assets patch 2008-11-19T23:29:12+00:00 17393 Repository aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 2 (from [d7f4921a9a852da7c1075275eaf73822edb7acff]) Fixed asset host to not cache objects [#1419 state:resolved] Signed-off-by: Joshua Peek <josh@joshpeek.com> http://github.com/rails/rails/commit/d7f4921a9a852da7c1075275eaf73822edb7acff <div><p>(from [d7f4921a9a852da7c1075275eaf73822edb7acff]) Fixed asset host to not cache objects [<a href="/projects/8994/tickets/1419" title="Ticket #1419">#1419</a> state:resolved]</p> <p>Signed-off-by: Joshua Peek <a href="mailto:josh@joshpeek.com">josh@joshpeek.com</a> <a href="http://github.com/rails/rails/commit/d7f4921a9a852da7c1075275eaf73822edb7acff"> http://github.com/rails/rails/co...</a></p></div> true 2008-11-19T23:29:27+00:00 37059 --- {} 1419 massive-memory-leak-in-assettag 0 8994 resolved 2.2 actionpack assets patch 2008-11-19T23:29:28+00:00 17393 Repository aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 2 Josh, Please commit the 2nd patch. I found a bug that will mix js/css files and cache them as the same keys. This bug is still open. <div><p>Josh, Please commit the 2nd patch. I found a bug that will mix js/css files and cache them as the same keys. This bug is still open.</p></div> true 2008-11-19T23:35:53+00:00 37059 --- {} 1419 massive-memory-leak-in-assettag 0 8994 resolved 2.2 actionpack assets patch 2008-11-19T23:35:55+00:00 37059 aaronbatalion aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 2 rebased patch committed. <div><p>rebased patch committed.</p></div> true 2008-11-19T23:54:21+00:00 37059 --- {} 1419 massive-memory-leak-in-assettag 0 8994 resolved 2.2 actionpack assets patch 2008-11-19T23:54:24+00:00 37059 aaronbatalion aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 424 3 applied <div><p>applied</p></div> true 2008-11-20T00:02:55+00:00 37059 --- {} 1419 massive-memory-leak-in-assettag 0 8994 resolved 2.2 actionpack assets patch 2008-11-20T00:03:00+00:00 85 Jeremy Kemper aaronbatalion Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/1419 0cd57b6b6367d99fa5ecc37c961ef48bb15c375f text/plain 2008-11-19T19:07:35+00:00 stop_asset_tag_memory_leak.diff 63764 6273 37059 http://rails.lighthouseapp.com/attachments/63764/stop_asset_tag_memory_leak.diff 983e01a8c4d71234761d3ca5f559b1b32fe83074 text/plain 2008-11-19T23:15:58+00:00 fixed_formatting_including_previously_failing_test.diff 63864 8340 37059 http://rails.lighthouseapp.com/attachments/63864/fixed_formatting_including_previously_failing_test.diff 6593b6eca97aa2931f0aa908ef18f3334e14d1c6 text/plain 2008-11-19T23:54:21+00:00 cache_key_file_with_test.diff 63874 2066 37059 http://rails.lighthouseapp.com/attachments/63874/cache_key_file_with_test.diff