1366 2 false 2008-12-26T21:58:41+00:00 41923 27004 1639 adds-an-on-option-to-activerecord-observers 976 8994 open activerecord observers patch 2010-01-20T11:11:21+00:00 65556 Rizwan Reza Gabriel Gironda Pratik http://rails.lighthouseapp.com/projects/8994/tickets/1639 3.0 I needed to use an observer to observe multiple models, but only wanted to observe certain sets of changes on each one. There was also a bug where calling `observe` twice in an ActiveRecord Observer would clear out any previous list of observed classes. This patch adds both the :on option and refactors the workings of the `observe` method to not clear out models from previous declarations I needed to use an observer to observe multiple models, but only wanted to observe certain sets of changes on each one. There was also a bug where calling `observe` twice in an ActiveRecord Observer would clear out any previous list of observed classes. This patch adds both the :on option and refactors the workings of the `observe` method to not clear out models from previous declarations <div><p>I needed to use an observer to observe multiple models, but only wanted to observe certain sets of changes on each one. There was also a bug where calling <code>observe</code> twice in an ActiveRecord Observer would clear out any previous list of observed classes. This patch adds both the :on option and refactors the workings of the <code>observe</code> method to not clear out models from previous declarations</p></div> 0 I needed to use an observer to observe multiple models, but only wanted to observe certain sets of changes on each one. There was also a bug where calling `observe` twice in an ActiveRecord Observer would clear out any previous list of observed classes. This patch adds both the :on option and refactors the workings of the `observe` method to not clear out models from previous declarations <div><p>I needed to use an observer to observe multiple models, but only wanted to observe certain sets of changes on each one. There was also a bug where calling <code>observe</code> twice in an ActiveRecord Observer would clear out any previous list of observed classes. This patch adds both the :on option and refactors the workings of the <code>observe</code> method to not clear out models from previous declarations</p></div> false 2008-12-26T21:58:41+00:00 41923 --- {} 9903 1639 adds-an-on-option-to-activerecord-observers 0 8994 new patch 2008-12-26T21:58:47+00:00 41923 Gabriel Gironda Gabriel Gironda http://rails.lighthouseapp.com/projects/8994/tickets/1639 2.x 1 The would read much better if you could do: observe :comment, :photo, :after => :create -or- observe :comment, :photo, :on => [:create, :update] <div><p>The would read much better if you could do:</p> <p>observe :comment, :photo, :after =&gt; :create</p> <p>-or-</p> <p>observe :comment, :photo, :on =&gt; [:create, :update]</p></div> false 2008-12-27T01:12:13+00:00 41923 --- {} 9903 1639 adds-an-on-option-to-activerecord-observers 0 8994 new patch 2008-12-27T01:12:17+00:00 5443 Bryan Liles Gabriel Gironda http://rails.lighthouseapp.com/projects/8994/tickets/1639 2.x 1 Thanks for the comments, Bryan! The former, I agree with. When I get a moment I'll add that functionality to the patch. The latter would be a problem because there's cases where you might want `before_update` rather than `after_update`. Defaulting it to use `after_` by convention would cause problems in the case where a custom callback is being used - `notify(:before_some_domain_specific_event)` in your models, for example. <div><p>Thanks for the comments, Bryan!</p> <p>The former, I agree with. When I get a moment I'll add that functionality to the patch.</p> <p>The latter would be a problem because there's cases where you might want <code>before_update</code> rather than <code>after_update</code>. Defaulting it to use <code>after_</code> by convention would cause problems in the case where a custom callback is being used - <code>notify(:before_some_domain_specific_event)</code> in your models, for example.</p></div> false 2008-12-27T01:24:53+00:00 41923 --- {} 9903 1639 adds-an-on-option-to-activerecord-observers 0 8994 new patch 2008-12-27T01:24:55+00:00 41923 Gabriel Gironda Gabriel Gironda http://rails.lighthouseapp.com/projects/8994/tickets/1639 2.x 1 Here's a new patch that adds the :after => :create kind of syntax. <div><p>Here's a new patch that adds the :after =&gt; :create kind of syntax.</p></div> false 2009-01-27T22:45:14+00:00 41923 --- {} 9903 1639 adds-an-on-option-to-activerecord-observers 0 8994 new patch 2009-01-27T22:45:19+00:00 41923 Gabriel Gironda Gabriel Gironda http://rails.lighthouseapp.com/projects/8994/tickets/1639 2.x 2 false 2009-08-04T18:14:05+01:00 41923 --- :tag: patch 9903 1639 adds-an-on-option-to-activerecord-observers 0 8994 new bugmash patch 2009-08-04T18:14:10+01:00 7211 Mike Gunderloy Gabriel Gironda http://rails.lighthouseapp.com/projects/8994/tickets/1639 2.x 2 +1 this is nice syntax having trouble applying the patch - will try to apply to master and modify as necessary <div><p>+1 this is nice syntax</p> <p>having trouble applying the patch - will try to apply to master and modify as necessary</p></div> false 2009-08-08T22:44:16+01:00 41923 --- {} 9903 1639 adds-an-on-option-to-activerecord-observers 0 8994 new bugmash patch 2009-08-08T22:44:22+01:00 22242 Dan Pickett Gabriel Gironda http://rails.lighthouseapp.com/projects/8994/tickets/1639 2.x 1366 2 false 2010-01-20T11:11:16+00:00 41923 --- :state: new :tag: bugmash patch :assigned_user: :milestone: 9903 27004 1639 adds-an-on-option-to-activerecord-observers 0 8994 open activerecord observers patch 2010-01-20T11:11:21+00:00 65556 Rizwan Reza Gabriel Gironda Pratik http://rails.lighthouseapp.com/projects/8994/tickets/1639 3.0 6d927b0cf11d21563f5c46d3691d4be115086905 text/plain 2008-12-26T21:58:42+00:00 observer_on_option.diff 74005 7182 41923 http://rails.lighthouseapp.com/attachments/74005/observer_on_option.diff 7bb2dac4ab6daa2d8190bad892462bfd70b4cff0 text/plain 2009-01-27T22:45:14+00:00 observer_on_option.diff 82191 7771 41923 http://rails.lighthouseapp.com/attachments/82191/observer_on_option.diff