85 1 true 2009-02-24T17:29:17+00:00 15346 9903 2060 installation-of-miniunit-causes-test-to-fail 1291 8994 committed 2.3 activesupport testcase 2009-05-12T14:57:37+01:00 15346 Ken Collins Ken Collins Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x The issue appears to be related to Mocha. It loads MiniTest and when MiniTest is defined a total of 27 failures occur for me in actionpack. A summary of these errors can be seen here: http://pastie.org/398566 The biggest cluster of failing tests I can see are in AssertSelectTest that expect the Assertion constant, which is being assigned by active support's test case to "MiniTest::Assertion" to be raised. However, they are raising "Test::Unit::AssertionFailedError". Here is a small code snippet that shows the issue. Below it is a slimmed down version of what ActiveSupport::TestCase is doing when defined?(MiniTest) returns the constant. @@@ruby require 'rubygems' require 'mocha' require 'test/unit' class TestFailing < Test::Unit::TestCase Assertion = MiniTest::Assertion def test_raise assert_raise(Assertion) { flunk } end end # Loaded suite /Users/kencollins/Desktop/foo # Started # F # Finished in 0.007994 seconds. # # 1) Failure: # test_raise(TestFailing) # method test_raise in foo.rb at line 10 # method __send__ in test_case_adapter.rb at line 69 # method run in test_case_adapter.rb at line 69 # <MiniTest::Assertion> exception expected but was # Class: <Test::Unit::AssertionFailedError> # Message: <"Flunked."> # ---Backtrace--- # /Users/kencollins/Desktop/foo.rb:10:in `test_raise' # /Users/kencollins/Desktop/foo.rb:10:in `test_raise' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `__send__' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `run' # --------------- @@@ruby So is this a rails or mocha issue. The issue appears to be related to Mocha. It loads MiniTest and when MiniTest is defined a total of 27 failures occur for me in actionpack. A summary of these errors can be seen here: http://pastie.org/398566 The biggest cluster of failing tests I can see are in AssertSelectTest that expect the Assertion constant, which is being assigned by active support's test case to "MiniTest::Assertion" to be raised. However, they are raising "Test::Unit::AssertionFailedError". Here is a small code snippet that shows the issue. Below it is a slimmed down version of what ActiveSupport::TestCase is doing when defined?(MiniTest) returns the constant. @@@ruby require 'rubygems' require 'mocha' require 'test/unit' class TestFailing < Test::Unit::TestCase Assertion = MiniTest::Assertion def test_raise assert_raise(Assertion) { flunk } end end # Loaded suite /Users/kencollins/Desktop/foo # Started # F # Finished in 0.007994 seconds. # # 1) Failure: # test_raise(TestFailing) # method test_raise in foo.rb at line 10 # method __send__ in test_case_adapter.rb at line 69 # method run in test_case_adapter.rb at line 69 # <MiniTest::Assertion> exception expected but was # Class: <Test::Unit::AssertionFailedError> # Message: <"Flunked."> # ---Backtrace--- # /Users/kencollins/Desktop/foo.rb:10:in `test_raise' # /Users/kencollins/Desktop/foo.rb:10:in `test_raise' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `__send__' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `run' # --------------- @@@ruby So is this a rails or mocha issue. <div><p>The issue appears to be related to Mocha. It loads MiniTest and when MiniTest is defined a total of 27 failures occur for me in actionpack.</p> <p>A summary of these errors can be seen here: <a href="http://pastie.org/398566">http://pastie.org/398566</a></p> <p>The biggest cluster of failing tests I can see are in AssertSelectTest that expect the Assertion constant, which is being assigned by active support's test case to "MiniTest::Assertion" to be raised. However, they are raising "Test::Unit::AssertionFailedError".</p> <p>Here is a small code snippet that shows the issue. Below it is a slimmed down version of what ActiveSupport::TestCase is doing when defined?(MiniTest) returns the constant.</p> <p>@@@ruby require 'rubygems' require 'mocha' require 'test/unit'</p> <p>class TestFailing &lt; Test::Unit::TestCase</p> <p>Assertion = MiniTest::Assertion</p> <p>def test_raise</p> <pre> <code>assert_raise(Assertion) { flunk } </code> </pre> <p>end</p> <p>end</p> <h1>Loaded suite /Users/kencollins/Desktop/foo</h1> <h1>Started</h1> <p># F</p> <h1>Finished in 0.007994 seconds.</h1> <p>#</p> <h1>1) Failure:</h1> <h1>test_raise(TestFailing)</h1> <h1>method test_raise in foo.rb at line 10</h1> <h1>method <strong>send</strong> in test_case_adapter.rb at line 69</h1> <h1>method run in test_case_adapter.rb at line 69</h1> <h1>&lt;MiniTest::Assertion&gt; exception expected but was</h1> <h1>Class: &lt;Test::Unit::AssertionFailedError&gt;</h1> <h1>Message: &lt;"Flunked."&gt;</h1> <h1>---Backtrace---</h1> <h1>/Users/kencollins/Desktop/foo.rb:10:in <code>test_raise'</code></h1> <h1>/Users/kencollins/Desktop/foo.rb:10:in <code>test_raise'</code></h1> <h1> /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in <code>__send__'</code></h1> <h1> /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in <code>run'</code></h1> <h1>---------------</h1> <p>@@@ruby</p> <p>So is this a rails or mocha issue.</p></div> 0 The issue appears to be related to Mocha. It loads MiniTest and when MiniTest is defined a total of 27 failures occur for me in actionpack. A summary of these errors can be seen here: http://pastie.org/398566 The biggest cluster of failing tests I can see are in AssertSelectTest that expect the Assertion constant, which is being assigned by active support's test case to "MiniTest::Assertion" to be raised. However, they are raising "Test::Unit::AssertionFailedError". Here is a small code snippet that shows the issue. Below it is a slimmed down version of what ActiveSupport::TestCase is doing when defined?(MiniTest) returns the constant. @@@ruby require 'rubygems' require 'mocha' require 'test/unit' class TestFailing < Test::Unit::TestCase Assertion = MiniTest::Assertion def test_raise assert_raise(Assertion) { flunk } end end # Loaded suite /Users/kencollins/Desktop/foo # Started # F # Finished in 0.007994 seconds. # # 1) Failure: # test_raise(TestFailing) # method test_raise in foo.rb at line 10 # method __send__ in test_case_adapter.rb at line 69 # method run in test_case_adapter.rb at line 69 # <MiniTest::Assertion> exception expected but was # Class: <Test::Unit::AssertionFailedError> # Message: <"Flunked."> # ---Backtrace--- # /Users/kencollins/Desktop/foo.rb:10:in `test_raise' # /Users/kencollins/Desktop/foo.rb:10:in `test_raise' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `__send__' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `run' # --------------- @@@ruby So is this a rails or mocha issue. <div><p>The issue appears to be related to Mocha. It loads MiniTest and when MiniTest is defined a total of 27 failures occur for me in actionpack.</p> <p>A summary of these errors can be seen here: <a href="http://pastie.org/398566">http://pastie.org/398566</a></p> <p>The biggest cluster of failing tests I can see are in AssertSelectTest that expect the Assertion constant, which is being assigned by active support's test case to "MiniTest::Assertion" to be raised. However, they are raising "Test::Unit::AssertionFailedError".</p> <p>Here is a small code snippet that shows the issue. Below it is a slimmed down version of what ActiveSupport::TestCase is doing when defined?(MiniTest) returns the constant.</p> <p>@@@ruby require 'rubygems' require 'mocha' require 'test/unit'</p> <p>class TestFailing &lt; Test::Unit::TestCase</p> <p>Assertion = MiniTest::Assertion</p> <p>def test_raise</p> <pre> <code>assert_raise(Assertion) { flunk } </code> </pre> <p>end</p> <p>end</p> <h1>Loaded suite /Users/kencollins/Desktop/foo</h1> <h1>Started</h1> <p># F</p> <h1>Finished in 0.007994 seconds.</h1> <p>#</p> <h1>1) Failure:</h1> <h1>test_raise(TestFailing)</h1> <h1>method test_raise in foo.rb at line 10</h1> <h1>method <strong>send</strong> in test_case_adapter.rb at line 69</h1> <h1>method run in test_case_adapter.rb at line 69</h1> <h1>&lt;MiniTest::Assertion&gt; exception expected but was</h1> <h1>Class: &lt;Test::Unit::AssertionFailedError&gt;</h1> <h1>Message: &lt;"Flunked."&gt;</h1> <h1>---Backtrace---</h1> <h1>/Users/kencollins/Desktop/foo.rb:10:in <code>test_raise'</code></h1> <h1>/Users/kencollins/Desktop/foo.rb:10:in <code>test_raise'</code></h1> <h1> /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in <code>__send__'</code></h1> <h1> /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in <code>run'</code></h1> <h1>---------------</h1> <p>@@@ruby</p> <p>So is this a rails or mocha issue.</p></div> false 2009-02-24T17:29:17+00:00 15346 --- {} 9903 2060 installation-of-miniunit-causes-test-to-fail 0 8994 new 2.3 activesupport testcase 2009-02-24T17:29:21+00:00 15346 Ken Collins Ken Collins http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x 0 Sorry for the bad formatting. Let me try that again. Note, you have to have the MiniUnit gem installed for this and the rails test cases in the link above to fail. @@@ ruby require 'rubygems' # gem 'mocha', '>= 0.9.3' require 'mocha' require 'test/unit' class TestFailing < Test::Unit::TestCase Assertion = MiniTest::Assertion def test_raise assert_raise(Assertion) { flunk } end end # Loaded suite /Users/kencollins/Desktop/test_failing # Started # F # Finished in 0.007939 seconds. # # 1) Failure: # test_raise(TestFailing) # method test_raise in test_failing.rb at line 11 # method __send__ in test_case_adapter.rb at line 69 # method run in test_case_adapter.rb at line 69 # <MiniTest::Assertion> exception expected but was # Class: <Test::Unit::AssertionFailedError> # Message: <"Flunked."> # ---Backtrace--- # /Users/kencollins/Desktop/test_failing.rb:11:in `test_raise' # /Users/kencollins/Desktop/test_failing.rb:11:in `test_raise' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `__send__' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `run' # --------------- # # 1 tests, 1 assertions, 1 failures, 0 errors @@@ ruby <div><p>Sorry for the bad formatting. Let me try that again. Note, you have to have the MiniUnit gem installed for this and the rails test cases in the link above to fail.</p> <pre><code class="ruby"> require 'rubygems' # gem 'mocha', '&gt;= 0.9.3' require 'mocha' require 'test/unit' class TestFailing &lt; Test::Unit::TestCase Assertion = MiniTest::Assertion def test_raise assert_raise(Assertion) { flunk } end end # Loaded suite /Users/kencollins/Desktop/test_failing # Started # F # Finished in 0.007939 seconds. # # 1) Failure: # test_raise(TestFailing) # method test_raise in test_failing.rb at line 11 # method __send__ in test_case_adapter.rb at line 69 # method run in test_case_adapter.rb at line 69 # &lt;MiniTest::Assertion&gt; exception expected but was # Class: &lt;Test::Unit::AssertionFailedError&gt; # Message: &lt;&quot;Flunked.&quot;&gt; # ---Backtrace--- # /Users/kencollins/Desktop/test_failing.rb:11:in `test_raise' # /Users/kencollins/Desktop/test_failing.rb:11:in `test_raise' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `__send__' # /opt/local/lib/ruby/gems/1.8/gems/mocha-0.9.5/lib/mocha/test_case_adapter.rb:69:in `run' # --------------- # # 1 tests, 1 assertions, 1 failures, 0 errors </code></pre></div> false 2009-02-24T18:17:18+00:00 15346 --- {} 9903 2060 installation-of-miniunit-causes-test-to-fail 0 8994 new 2.3 activesupport testcase 2009-02-24T18:17:20+00:00 15346 Ken Collins Ken Collins http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x 0 Hopefully this commit [1] resolves the Mocha aspects of this problem. Let me know if not. Thanks, James. [1] http://github.com/floehopper/mocha/commit/4e41149f1624f4ae48a54e3b68ff4ca8b6b865db <div><p>Hopefully this commit <a href="/projects/8994/changesets/1" title="Changeset #1">[1]</a> resolves the Mocha aspects of this problem. Let me know if not.</p> <p>Thanks, James.</p> <p><a href="/projects/8994/changesets/1" title="Changeset #1">[1]</a> <a href="http://github.com/floehopper/mocha/commit/4e41149f1624f4ae48a54e3b68ff4ca8b6b865db"> http://github.com/floehopper/moc...</a></p></div> false 2009-03-04T19:17:33+00:00 15346 --- {} 9903 2060 installation-of-miniunit-causes-test-to-fail 0 8994 new 2.3 activesupport testcase 2009-03-04T19:17:37+00:00 27133 James Mead Ken Collins http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x 0 Well it does fix it but this commit in Mocha... http://github.com/floehopper/mocha/commit/03f86943eb26a2c3cac01a9775f29658bd05aa6b ... breaks active support since it calls on Mocha::TestCaseAdapter::AssertionCounter. I'll upload a patch for active support to work with the upcoming Mocha code org. <div><p>Well it does fix it but this commit in Mocha...</p> <p><a href="http://github.com/floehopper/mocha/commit/03f86943eb26a2c3cac01a9775f29658bd05aa6b"> http://github.com/floehopper/moc...</a></p> <p>... breaks active support since it calls on Mocha::TestCaseAdapter::AssertionCounter. I'll upload a patch for active support to work with the upcoming Mocha code org.</p></div> false 2009-03-10T20:19:36+00:00 15346 --- {} 9903 2060 installation-of-miniunit-causes-test-to-fail 0 8994 new 2.3 activesupport testcase 2009-03-10T20:32:20+00:00 15346 Ken Collins Ken Collins http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x 85 1 false 2009-03-10T20:38:23+00:00 15346 --- :assigned_user: 9903 2060 installation-of-miniunit-causes-test-to-fail 0 8994 new 2.3 activesupport testcase 2009-03-10T20:53:57+00:00 1366 Pratik Ken Collins Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x 85 1 (from [4b4e7caffa361a1a3317586d8f498b4ba353adba]) The latest trunk of Mocha > 0.9.5 which addresses issue with MiniUnit compatibility uses namespaced integration classes. [#2060 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> http://github.com/rails/rails/commit/4b4e7caffa361a1a3317586d8f498b4ba353adba <div><p>(from [4b4e7caffa361a1a3317586d8f498b4ba353adba]) The latest trunk of Mocha &gt; 0.9.5 which addresses issue with MiniUnit compatibility uses namespaced integration classes.</p> <p>[<a href="/projects/8994/tickets/2060" title="Ticket #2060">#2060</a> state:committed]</p> <p>Signed-off-by: Jeremy Kemper <a href="mailto:jeremy@bitsweat.net">jeremy@bitsweat.net</a> <a href="http://github.com/rails/rails/commit/4b4e7caffa361a1a3317586d8f498b4ba353adba"> http://github.com/rails/rails/co...</a></p></div> true 2009-03-10T21:24:35+00:00 15346 --- :state: new 9903 2060 installation-of-miniunit-causes-test-to-fail 0 8994 committed 2.3 activesupport testcase 2009-03-10T21:44:53+00:00 17393 Repository Ken Collins Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x 85 1 Do you need some particular version of mocha to be able to run the tests now? I'm experiencing something very similar (http://pastie.org/417598) on the latest edge. Using mocha 0.9.5, via "gem1.9 install mocha". <div><p>Do you need some particular version of mocha to be able to run the tests now? I'm experiencing something very similar (<a href="http://pastie.org/417598)">http://pastie.org/417598)</a> on the latest edge. Using mocha 0.9.5, via "gem1.9 install mocha".</p></div> true 2009-03-16T13:14:15+00:00 15346 --- {} 9903 2060 installation-of-miniunit-causes-test-to-fail 0 8994 committed 2.3 activesupport testcase 2009-03-16T13:14:18+00:00 1998 augustl Ken Collins Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x 85 1 This can be marked invalid. It is moot under the release of 1.9.1 and rails 2.3.2. <div><p>This can be marked invalid. It is moot under the release of 1.9.1 and rails 2.3.2.</p></div> true 2009-05-12T14:57:34+01:00 15346 --- {} 9903 2060 installation-of-miniunit-causes-test-to-fail 0 8994 committed 2.3 activesupport testcase 2009-05-12T14:57:37+01:00 15346 Ken Collins Ken Collins Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2060 2.x a08ff80fcafeb3e07ba1ce94440a519d15d39013 text/plain 2009-03-10T20:27:28+00:00 mocha_compatibility.diff 98184 1459 15346 http://rails.lighthouseapp.com/attachments/98184/mocha_compatibility.diff