[patch] Ensure necessary included tables are joined in construct_finder_sql_for_association_limiting
Reported by John Devine | May 4th, 2008 @ 07:25 PM
Currently selecting limited ids for eager loading associations is broken when there is a condition or an order-by based on a table that is not directly joined to the main active record table.
so if I have:
class Person
has_many :items
end
class Item
belongs_to :person
has_one :another_item
end
class AnotherItem
belongs_to :item
end
Person.find(:all,
:include=>{:items=>:another_item},
:order=>" another_items.name ASC ",
:limit=>4)
The find will fail because the join to table items will not be included.
The patch adds methods to the join_dependency to look up joins by aliased table name, and get an array of the joins required to reach that table.
Comments and changes to this ticket
-
Frederick Cheung May 6th, 2008 @ 10:26 AM
+1. tests all pass, looks sane (also see discussion on trac)
-
Repository May 6th, 2008 @ 11:01 AM
- → State changed from “new” to “resolved”
(from [8ded457b1b31b157d6fe89b553749579e5ac4a27]) Added logic to associations.rb to make sure select_for_limited_ids
includes joins that are needed to reach tables listed in the :order
or :conditions options if they are not joined directly to the main
active_record table.
Signed-off-by: Michael Koziarski
[#109 state:resolved]
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
Ruy Asan