0 true 2008-10-07T22:16:01+01:00 18996 9903 1187 binary-files-are-attempted-to-be-pre-compiled-as-erb 596 8994 resolved bug bug edge 2008-12-03T16:57:42+00:00 17393 Repository Roger http://rails.lighthouseapp.com/projects/8994/tickets/1187 2.x With edge rails, I get the following error when trying to compile binary files which are in the views directory: @filename="[...]/app/views/simplegrey2/original/grey2/din_mittle.swf" Here's one I get [fatal]: /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:469:in `scan': undefined method `empty?' for nil:NilClass (NoMethodError) from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:525:in `compile' from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:692:in `initialize' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `new' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `compile' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handler.rb:11:in `call' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/renderable.rb:21:in `_unmemoized_compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:57:in `compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `__send__' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `memoize_all' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `each' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `memoize_all' ... Possible fix: rescue and ignore? With edge rails, I get the following error when trying to compile binary files which are in the views directory: @filename="[...]/app/views/simplegrey2/original/grey2/din_mittle.swf" Here's one I get [fatal]: /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:469:in `scan': undefined method `empty?' for nil:NilClass (NoMethodError) from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:525:in `compile' from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:692:in `initialize' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `new' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `compile' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handler.rb:11:in `call' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/renderable.rb:21:in `_unmemoized_compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:57:in `compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `__send__' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `memoize_all' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `each' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `memoize_all' ... Possible fix: rescue and ignore? <div><p>With edge rails, I get the following error when trying to compile binary files which are in the views directory:</p> <p> @filename="[...]/app/views/simplegrey2/original/grey2/din_mittle.swf"</p> <p>Here's one I get [fatal]:</p> <p> /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:469:in <code>scan': undefined method</code>empty?' for nil:NilClass (NoMethodError)</p> <pre> <code>from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:525:in `compile' from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:692:in `initialize' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `new' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `compile' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handler.rb:11:in `call' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/renderable.rb:21:in `_unmemoized_compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:57:in `compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `__send__' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `memoize_all' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `each' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `memoize_all' </code> </pre> <p>...</p> <p>Possible fix: rescue and ignore?</p></div> 0 With edge rails, I get the following error when trying to compile binary files which are in the views directory: @filename="[...]/app/views/simplegrey2/original/grey2/din_mittle.swf" Here's one I get [fatal]: /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:469:in `scan': undefined method `empty?' for nil:NilClass (NoMethodError) from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:525:in `compile' from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:692:in `initialize' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `new' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `compile' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handler.rb:11:in `call' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/renderable.rb:21:in `_unmemoized_compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:57:in `compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `__send__' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `memoize_all' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `each' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `memoize_all' ... Possible fix: rescue and ignore? <div><p>With edge rails, I get the following error when trying to compile binary files which are in the views directory:</p> <p> @filename="[...]/app/views/simplegrey2/original/grey2/din_mittle.swf"</p> <p>Here's one I get [fatal]:</p> <p> /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:469:in <code>scan': undefined method</code>empty?' for nil:NilClass (NoMethodError)</p> <pre> <code>from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:525:in `compile' from /Users/rogerpack/dev/ruby_186_installed/lib/ruby/1.8/erb.rb:692:in `initialize' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `new' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handlers/erb.rb:51:in `compile' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/template_handler.rb:11:in `call' from /Users/rogerpack/dev/degreesearch/vendor/rails/actionpack/lib/action_view/renderable.rb:21:in `_unmemoized_compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:57:in `compiled_source' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `__send__' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:25:in `memoize_all' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `each' from /Users/rogerpack/dev/degreesearch/vendor/rails/activesupport/lib/active_support/memoizable.rb:22:in `memoize_all' </code> </pre> <p>...</p> <p>Possible fix: rescue and ignore?</p></div> false 2008-10-07T22:16:01+01:00 18996 --- {} 9903 1187 binary-files-are-attempted-to-be-pre-compiled-as-erb 0 8994 new bug edge 2008-10-07T22:16:03+01:00 18996 Roger Roger http://rails.lighthouseapp.com/projects/8994/tickets/1187 2.x 0 --- a/actionpack/lib/action_view/template_handlers/erb.rb +++ b/actionpack/lib/action_view/template_handlers/erb.rb @@ -48,11 +48,14 @@ module ActionView self.erb_trim_mode = '-' def compile(template) + begin src = ::ERB.new("<% __in_erb_template=true %>#{template.source}", nil, erb_trim_mode, '@output_buffer').src # Ruby 1.9 prepends an encoding to the source. However this is # useless because you can only set an encoding on the first line RUBY_VERSION >= '1.9' ? src.sub(/\A#coding:.*\n/, '') : src + rescue Exception + end end end end seems to be a temporary fix. Better might be to only erb compile .rhtml or .html.erb files :) <div><p>--- a/actionpack/lib/action_view/template_handlers/erb.rb +++ b/actionpack/lib/action_view/template_handlers/erb.rb @@ -48,11 +48,14 @@ module ActionView</p> <pre> <code> self.erb_trim_mode = '-' def compile(template) </code> </pre> <ul> <li> <pre> <code>begin src = ::ERB.new("&lt;% __in_erb_template=true %&gt;#{template.source}", nil, erb_trim_mode, '@output_buffer').src # Ruby 1.9 prepends an encoding to the source. However this is # useless because you can only set an encoding on the first line RUBY_VERSION &gt;= '1.9' ? src.sub(/\A#coding:.*\n/, '') : src </code> </pre></li> <li> <pre> <code>rescue Exception </code> </pre></li> <li> <pre> <code>end </code> </pre> end end end</li> </ul> <p>seems to be a temporary fix. Better might be to only erb compile .rhtml or .html.erb files :)</p></div> false 2008-10-10T19:47:02+01:00 18996 --- :tag: bug edge 9903 1187 binary-files-are-attempted-to-be-pre-compiled-as-erb 0 8994 new bug bug edge 2008-10-10T19:47:05+01:00 18996 Roger Roger http://rails.lighthouseapp.com/projects/8994/tickets/1187 2.x 0 Is there a good reason why you don't put this static content in /public/simplegrey2/original/grey2/din_mittle.swf Putting it inside /app/views makes rails deal with it, putting it in public makes the web server deal with it. Basically, if you don't need rails to handle it, stick it in public, otherwise you are wasting valuable mongrel/whatever time dealing with stuff that apache/nginx is better at shifting. <div><p>Is there a good reason why you don't put this static content in /public/simplegrey2/original/grey2/din_mittle.swf</p> <p>Putting it inside /app/views makes rails deal with it, putting it in public makes the web server deal with it.</p> <p>Basically, if you don't need rails to handle it, stick it in public, otherwise you are wasting valuable mongrel/whatever time dealing with stuff that apache/nginx is better at shifting.</p></div> false 2008-10-11T16:07:15+01:00 18996 --- {} 9903 1187 binary-files-are-attempted-to-be-pre-compiled-as-erb 0 8994 new bug bug edge 2008-10-11T16:07:19+01:00 28420 Tom Lea Roger http://rails.lighthouseapp.com/projects/8994/tickets/1187 2.x 0 Nope. I was just pointing out a difference ["gotcha"] between 2.1 and edge. If it's a good gotcha then I guess leave it in there ? I'm not sure :) <div><p>Nope. I was just pointing out a difference ["gotcha"] between 2.1 and edge. If it's a good gotcha then I guess leave it in there ? I'm not sure :)</p></div> false 2008-10-11T18:53:30+01:00 18996 --- {} 9903 1187 binary-files-are-attempted-to-be-pre-compiled-as-erb 0 8994 new bug bug edge 2008-10-11T18:53:35+01:00 18996 Roger Roger http://rails.lighthouseapp.com/projects/8994/tickets/1187 2.x 0 (from [2fc6c7dd05b9481ed81fe19c8fc0cc7915868404]) Validate template extensions [#1187 state:resolved] http://github.com/rails/rails/commit/2fc6c7dd05b9481ed81fe19c8fc0cc7915868404 <div><p>(from [2fc6c7dd05b9481ed81fe19c8fc0cc7915868404]) Validate template extensions [<a href="/projects/8994/tickets/1187" title="Ticket #1187">#1187</a> state:resolved] <a href="http://github.com/rails/rails/commit/2fc6c7dd05b9481ed81fe19c8fc0cc7915868404"> http://github.com/rails/rails/co...</a></p></div> true 2008-12-03T16:57:41+00:00 18996 --- :state: new 9903 1187 binary-files-are-attempted-to-be-pre-compiled-as-erb 0 8994 resolved bug bug edge 2008-12-03T16:57:42+00:00 17393 Repository Roger http://rails.lighthouseapp.com/projects/8994/tickets/1187 2.x