85 1 false 2008-10-21T19:15:07+01:00 17222 9903 1244 caches_page-does-not-respect-accept-header 649 8994 new cache caches_page caching format patch respond_to 2009-05-30T23:47:37+01:00 51923 Andrew Bloomgarden Mike Burns Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/1244 2.x This little snippet in our JobsController was causing an issue: caches_page :index, :if => Proc.new {|c| c.request.format.xml?} When requested as /jobs.xml it would create the file public/jobs.xml . However, when requested as /jobs with a header of 'Accept: text/xml' it would render the XML but cache to public/jobs.html . This meant GET /jobs.html would now produce XML. Attached is a patch with tests and a possible solution to the problem. This little snippet in our JobsController was causing an issue: caches_page :index, :if => Proc.new {|c| c.request.format.xml?} When requested as /jobs.xml it would create the file public/jobs.xml . However, when requested as /jobs with a header of 'Accept: text/xml' it would render the XML but cache to public/jobs.html . This meant GET /jobs.html would now produce XML. Attached is a patch with tests and a possible solution to the problem. <div><p>This little snippet in our JobsController was causing an issue:</p> <p>caches_page :index, :if =&gt; Proc.new {|c| c.request.format.xml?}</p> <p>When requested as /jobs.xml it would create the file public/jobs.xml . However, when requested as /jobs with a header of 'Accept: text/xml' it would render the XML but cache to public/jobs.html . This meant GET /jobs.html would now produce XML.</p> <p>Attached is a patch with tests and a possible solution to the problem.</p></div> 0 This little snippet in our JobsController was causing an issue: caches_page :index, :if => Proc.new {|c| c.request.format.xml?} When requested as /jobs.xml it would create the file public/jobs.xml . However, when requested as /jobs with a header of 'Accept: text/xml' it would render the XML but cache to public/jobs.html . This meant GET /jobs.html would now produce XML. Attached is a patch with tests and a possible solution to the problem. <div><p>This little snippet in our JobsController was causing an issue:</p> <p>caches_page :index, :if =&gt; Proc.new {|c| c.request.format.xml?}</p> <p>When requested as /jobs.xml it would create the file public/jobs.xml . However, when requested as /jobs with a header of 'Accept: text/xml' it would render the XML but cache to public/jobs.html . This meant GET /jobs.html would now produce XML.</p> <p>Attached is a patch with tests and a possible solution to the problem.</p></div> false 2008-10-21T19:15:07+01:00 17222 --- {} 9903 1244 caches_page-does-not-respect-accept-header 0 8994 new cache caches_page caching format respond_to 2008-10-21T19:15:13+01:00 17222 Mike Burns Mike Burns http://rails.lighthouseapp.com/projects/8994/tickets/1244 2.x 85 1 false 2009-03-10T11:18:10+00:00 17222 --- :tag: cache caches_page caching format respond_to :assigned_user: 9903 1244 caches_page-does-not-respect-accept-header 0 8994 new cache caches_page caching format patch respond_to 2009-03-10T11:18:16+00:00 1366 Pratik Mike Burns Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/1244 2.x 85 1 +1 We're encountering this problem on Rails 2.3. I'd like to fix it temporarily with an around_filter, but since caching happens after that I can't. Fixing it with a before_filter will change the type forever in production. <div><p>+1</p> <p>We're encountering this problem on Rails 2.3. I'd like to fix it temporarily with an around_filter, but since caching happens after that I can't. Fixing it with a before_filter will change the type forever in production.</p></div> false 2009-05-30T23:47:32+01:00 17222 --- {} 9903 1244 caches_page-does-not-respect-accept-header 0 8994 new cache caches_page caching format patch respond_to 2009-05-30T23:47:37+01:00 51923 Andrew Bloomgarden Mike Burns Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/1244 2.x 8d236759c4f9fd9b1db4560ea67627b83f201f2e text/plain 2008-10-21T19:15:07+01:00 caching-extension.patch 55823 4578 17222 http://rails.lighthouseapp.com/attachments/55823/caching-extension.patch