0
true
2008-12-18T16:44:27+00:00
18793
9903
1596
rfc822-shouldnt-be-localized
942
8994
invalid
i18n
RFC822 shouldn't be localized
2009-06-03T09:38:13+01:00
3117
Bart Zonneveld
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
Hi,
I've found that a date formatted as RFC822 is localized like any other format, and as far as I can tell this format should not be localized.
I've found the problem when I tried to have my RSS feeds localized in my freshly internationalized app.
In english, the "pubDate" is well formed (Wed, 17 Dec 2008 11:07:01 +0100), but in other languages (french by exemple), the date looks like this : "jeu, 18 déc 2008 09:48:34 +0100"
The Feed validator (http://feedvalidator.org/) tells me that the feed is invalid and my RSS agregator (NetNewsWire) is not showing the correct date (the last synced date)
Strangely, this behavour is permanent on a Debian server with Nginx/Mongrel/Rails2.2.2/... but it's not permanent on my local MacBookPro using Passenger. I've struggled quitea long time to stop the localization before I've started to write this ticket, and now it's working with not code change at all.
Maybe there is something wrong on my side. I'm confused.
Hi,
I've found that a date formatted as RFC822 is localized like any other format, and as far as I can tell this format should not be localized.
I've found the problem when I tried to have my RSS feeds localized in my freshly internationalized app.
In english, the "pubDate" is well formed (Wed, 17 Dec 2008 11:07:01 +0100), but in other languages (french by exemple), the date looks like this : "jeu, 18 déc 2008 09:48:34 +0100"
The Feed validator (http://feedvalidator.org/) tells me that the feed is invalid and my RSS agregator (NetNewsWire) is not showing the correct date (the last synced date)
Strangely, this behavour is permanent on a Debian server with Nginx/Mongrel/Rails2.2.2/... but it's not permanent on my local MacBookPro using Passenger. I've struggled quitea long time to stop the localization before I've started to write this ticket, and now it's working with not code change at all.
Maybe there is something wrong on my side. I'm confused.
<div><p>Hi,</p>
<p>I've found that a date formatted as RFC822 is localized like any
other format, and as far as I can tell this format should not be
localized.</p>
<p>I've found the problem when I tried to have my RSS feeds
localized in my freshly internationalized app. In english, the
"pubDate" is well formed (Wed, 17 Dec 2008 11:07:01 +0100), but in
other languages (french by exemple), the date looks like this :
"jeu, 18 déc 2008 09:48:34 +0100"</p>
<p>The Feed validator (<a href="http://feedvalidator.org/)">http://feedvalidator.org/)</a> tells
me that the feed is invalid and my RSS agregator (NetNewsWire) is
not showing the correct date (the last synced date)</p>
<p>Strangely, this behavour is permanent on a Debian server with
Nginx/Mongrel/Rails2.2.2/... but it's not permanent on my local
MacBookPro using Passenger. I've struggled quitea long time to stop
the localization before I've started to write this ticket, and now
it's working with not code change at all.</p>
<p>Maybe there is something wrong on my side. I'm confused.</p></div>
0
Hi,
I've found that a date formatted as RFC822 is localized like any other format, and as far as I can tell this format should not be localized.
I've found the problem when I tried to have my RSS feeds localized in my freshly internationalized app.
In english, the "pubDate" is well formed (Wed, 17 Dec 2008 11:07:01 +0100), but in other languages (french by exemple), the date looks like this : "jeu, 18 déc 2008 09:48:34 +0100"
The Feed validator (http://feedvalidator.org/) tells me that the feed is invalid and my RSS agregator (NetNewsWire) is not showing the correct date (the last synced date)
Strangely, this behavour is permanent on a Debian server with Nginx/Mongrel/Rails2.2.2/... but it's not permanent on my local MacBookPro using Passenger. I've struggled quitea long time to stop the localization before I've started to write this ticket, and now it's working with not code change at all.
Maybe there is something wrong on my side. I'm confused.
<div><p>Hi,</p>
<p>I've found that a date formatted as RFC822 is localized like any
other format, and as far as I can tell this format should not be
localized.</p>
<p>I've found the problem when I tried to have my RSS feeds
localized in my freshly internationalized app. In english, the
"pubDate" is well formed (Wed, 17 Dec 2008 11:07:01 +0100), but in
other languages (french by exemple), the date looks like this :
"jeu, 18 déc 2008 09:48:34 +0100"</p>
<p>The Feed validator (<a href="http://feedvalidator.org/)">http://feedvalidator.org/)</a> tells
me that the feed is invalid and my RSS agregator (NetNewsWire) is
not showing the correct date (the last synced date)</p>
<p>Strangely, this behavour is permanent on a Debian server with
Nginx/Mongrel/Rails2.2.2/... but it's not permanent on my local
MacBookPro using Passenger. I've struggled quitea long time to stop
the localization before I've started to write this ticket, and now
it's working with not code change at all.</p>
<p>Maybe there is something wrong on my side. I'm confused.</p></div>
false
2008-12-18T16:44:27+00:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
new
RFC822 shouldn't be localized
2008-12-18T16:44:31+00:00
18793
Jérémy
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
Could you please pastie the code that leads to this?
<div><p>Could you please pastie the code that leads to this?</p></div>
false
2008-12-18T18:18:23+00:00
18793
---
:tag:
9903
1596
rfc822-shouldnt-be-localized
0
8994
new
i18n
RFC822 shouldn't be localized
2008-12-18T18:18:28+00:00
11102
Yaroslav Markin
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
Freaking strange ! I can't reproce my own bug today, sorry.
If I see it again and can nail it precisely, I'll warn you. Thanks anyway.
<div><p>Freaking strange ! I can't reproce my own bug today, sorry.</p>
<p>If I see it again and can nail it precisely, I'll warn you.
Thanks anyway.</p></div>
false
2008-12-19T11:49:47+00:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
new
i18n
RFC822 shouldn't be localized
2008-12-19T11:49:50+00:00
18793
Jérémy
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
Will reopen once we have a test case.
<div><p>Will reopen once we have a test case.</p></div>
true
2008-12-19T13:50:26+00:00
18793
---
:state: new
9903
1596
rfc822-shouldnt-be-localized
0
8994
invalid
i18n
RFC822 shouldn't be localized
2008-12-19T13:50:27+00:00
1366
Pratik
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
Hey,
I can see it again ! Like I said, on my local (OS X 10.5.6) it's always localized in english, but on my production/staging server (Debian stable up-to-date), it's always in french.
Here is the code involved : http://gist.github.com/41793
I've check for differences in the "locale" command in the shell,
Mac OS X: $ locale
LANG="fr_FR.UTF-8"
LC_COLLATE="fr_FR.UTF-8"
LC_CTYPE="fr_FR.UTF-8"
LC_MESSAGES="fr_FR.UTF-8"
LC_MONETARY="fr_FR.UTF-8"
LC_NUMERIC="fr_FR.UTF-8"
LC_TIME="fr_FR.UTF-8"
LC_ALL=
Debian: $ locale
LANG=fr_FR.UTF-8@euro
LC_CTYPE="fr_FR.UTF-8@euro"
LC_NUMERIC="fr_FR.UTF-8@euro"
LC_TIME="fr_FR.UTF-8@euro"
LC_COLLATE="fr_FR.UTF-8@euro"
LC_MONETARY="fr_FR.UTF-8@euro"
LC_MESSAGES="fr_FR.UTF-8@euro"
LC_PAPER="fr_FR.UTF-8@euro"
LC_NAME="fr_FR.UTF-8@euro"
LC_ADDRESS="fr_FR.UTF-8@euro"
LC_TELEPHONE="fr_FR.UTF-8@euro"
LC_MEASUREMENT="fr_FR.UTF-8@euro"
LC_IDENTIFICATION="fr_FR.UTF-8@euro"
LC_ALL=
I suspect this not to be related to rails, but to my environment, although I don't where to look at !
Thanks for any clue.
<div><p>Hey,</p>
<p>I can see it again ! Like I said, on my local (OS X 10.5.6) it's
always localized in english, but on my production/staging server
(Debian stable up-to-date), it's always in french.</p>
<p>Here is the code involved : <a href="http://gist.github.com/41793">http://gist.github.com/41793</a></p>
<p>I've check for differences in the "locale" command in the
shell,</p>
<p>Mac OS X: $ locale LANG="fr_FR.UTF-8" LC_COLLATE="fr_FR.UTF-8"
LC_CTYPE="fr_FR.UTF-8" LC_MESSAGES="fr_FR.UTF-8"
LC_MONETARY="fr_FR.UTF-8" LC_NUMERIC="fr_FR.UTF-8"
LC_TIME="fr_FR.UTF-8" LC_ALL=</p>
<p>Debian: $ locale LANG=fr_FR.UTF-8@euro
LC_CTYPE="fr_FR.UTF-8@euro" LC_NUMERIC="fr_FR.UTF-8@euro"
LC_TIME="fr_FR.UTF-8@euro" LC_COLLATE="fr_FR.UTF-8@euro"
LC_MONETARY="fr_FR.UTF-8@euro" LC_MESSAGES="fr_FR.UTF-8@euro"
LC_PAPER="fr_FR.UTF-8@euro" LC_NAME="fr_FR.UTF-8@euro"
LC_ADDRESS="fr_FR.UTF-8@euro" LC_TELEPHONE="fr_FR.UTF-8@euro"
LC_MEASUREMENT="fr_FR.UTF-8@euro"
LC_IDENTIFICATION="fr_FR.UTF-8@euro" LC_ALL=</p>
<p>I suspect this not to be related to rails, but to my
environment, although I don't where to look at !</p>
<p>Thanks for any clue.</p></div>
true
2008-12-30T23:01:19+00:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
invalid
i18n
RFC822 shouldn't be localized
2008-12-30T23:01:20+00:00
18793
Jérémy
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
On the production server, inside the console, it's in english (as it should, and not in french as it is in the real app)
@@@
$ script/console staging
Loading staging environment (Rails 2.2.2)
>> I18n.locale
=> :fr
>> Time.now
=> Wed Dec 31 00:10:17 +0100 2008
>> Time.now.to_s(:rfc822)
=> "Wed, 31 Dec 2008 00:10:28 +0100"
>>
@@@
<div><p>On the production server, inside the console, it's in english
(as it should, and not in french as it is in the real app)</p>
<pre><code>
$ script/console staging
Loading staging environment (Rails 2.2.2)
>> I18n.locale
=> :fr
>> Time.now
=> Wed Dec 31 00:10:17 +0100 2008
>> Time.now.to_s(:rfc822)
=> "Wed, 31 Dec 2008 00:10:28 +0100"
>>
</code></pre></div>
true
2008-12-30T23:12:18+00:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
invalid
i18n
RFC822 shouldn't be localized
2008-12-30T23:12:23+00:00
18793
Jérémy
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
Can't reproduce:
@@@
Loading development environment (Rails 2.3.0)
>> I18n.locale
=> :ru
>> Time.now
=> Thu Jan 01 22:14:11 +0300 2009
>> Time.now.to_s(:rfc822)
=> "Thu, 01 Jan 2009 22:14:21 +0200"
>> I18n.l Time.now
=> "Чт, 01 янв. 2009, 22:15:17 +0200"
@@@
AFAIK Time#to_s should not take I18n into account at all -- you can localize time using I18n.l, but to_s is not overloaded.
<div><p>Can't reproduce:</p>
<pre><code>
Loading development environment (Rails 2.3.0)
>> I18n.locale
=> :ru
>> Time.now
=> Thu Jan 01 22:14:11 +0300 2009
>> Time.now.to_s(:rfc822)
=> "Thu, 01 Jan 2009 22:14:21 +0200"
>> I18n.l Time.now
=> "Чт, 01 янв. 2009, 22:15:17 +0200"
</code></pre>
<p>AFAIK Time#to_s should not take I18n into account at all -- you
can localize time using I18n.l, but to_s is not overloaded.</p></div>
true
2009-01-01T19:15:35+00:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
invalid
i18n
RFC822 shouldn't be localized
2009-01-01T19:15:39+00:00
11102
Yaroslav Markin
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
You may have some kind of pre-I18n localization plugin/gem installed that overrides Time#to_s
<div><p>You may have some kind of pre-I18n localization plugin/gem
installed that overrides Time#to_s</p></div>
true
2009-01-01T19:16:25+00:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
invalid
i18n
RFC822 shouldn't be localized
2009-01-01T19:16:27+00:00
11102
Yaroslav Markin
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
Hello Yaroslav
Thanks for your help
I'm digging and have not found anything in installed plugins or gem.
I've noticed that in my views :
@@@
<% Date.today.strftime("%A") + " - " + Time.now.strftime("%A") %>
@@@
turns into
@@@
Saturday - samedi
@@@
I guess that the Date object is correctly handled (not localized) but the Time is not.
In irb, script/console, or straight ruby in the command line, the Time object is not localized.
I also tested this in another Rails app, running 2.1.1 (same server) and both Date and Time a strftime-ed correctly (ie not localized)
I continue to dig and try to look for the culprit, but if you have any idea with the details I gave you, you're welcome.
Thanks again for what you do
<div><p>Hello Yaroslav</p>
<p>Thanks for your help</p>
<p>I'm digging and have not found anything in installed plugins or
gem.</p>
<p>I've noticed that in my views :</p>
<pre><code>
<% Date.today.strftime("%A") + " - " + Time.now.strftime("%A") %>
</code></pre>
<p>turns into</p>
<pre><code>
Saturday - samedi
</code></pre>
<p>I guess that the Date object is correctly handled (not
localized) but the Time is not.</p>
<p>In irb, script/console, or straight ruby in the command line,
the Time object is not localized.</p>
<p>I also tested this in another Rails app, running 2.1.1 (same
server) and both Date and Time a strftime-ed correctly (ie not
localized)</p>
<p>I continue to dig and try to look for the culprit, but if you
have any idea with the details I gave you, you're welcome.</p>
<p>Thanks again for what you do</p></div>
true
2009-01-02T23:40:09+00:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
invalid
i18n
RFC822 shouldn't be localized
2009-01-02T23:40:10+00:00
18793
Jérémy
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
I've created a brand new app, with Rails 2.2.2 and a basic scaffold just to be able to call a view with some debug code in it.
Everything worked as expected. So I'vetried to move in piece by piece some stuff from my weird app : plugins (1 by 1), initializers, locales, libs, …
Then I remembered that I've seen something strange in Rails about the rfc822 method :
http://github.com/rails/rails/tree/2-2-stable/activesupport/lib/active_support/time_with_zone.rb (lines 145 -> 152
@@@
def to_s(format = :default)
return utc.to_s(format) if format == :db
if formatter = ::Time::DATE_FORMATS[format]
formatter.respond_to?(:call) ? formatter.call(self).to_s : strftime(formatter)
else
"#{time.strftime("%Y-%m-%d %H:%M:%S")} #{formatted_offset(false, 'UTC')}" # mimicking Ruby 1.9 Time#to_s format
end
end
@@@
I can see that it checks if the formatter respond_to? :call and if not it uses a basic strftime.
In my new app whre it's working great, I've got this :
@@@
I18n.locale : fr
I18n.default_locale : fr
Date.today.strftime("%A") : Saturday
Time.now.strftime("%A") : Saturday
Time.now.rfc822 : Sat, 03 Jan 2009 02:13:06 +0100
Time.now.strftime("%a, %d %b %Y %T %z") : Sat, 03 Jan 2009 02:13:06 +0100
I18n.l(Time.now, :format => "%a, %d %b %Y %T %z") : Sam, 03 Jan 2009 02:13:06 +0100
@@@
It shows that if I try to localize a Time with a strftime format it's indeed localized.
So I think that maybe it's going through a localized strftime instead of the normal call.
By the way I dont really understand what "formatter.call(self).to_s" does.
If it's calling a method named after the formatter if it exists, with self as paramater, it means that it tries to call a rfc822() method. Anyway, I don't get it !
<div><p>I've created a brand new app, with Rails 2.2.2 and a basic
scaffold just to be able to call a view with some debug code in
it.</p>
<p>Everything worked as expected. So I'vetried to move in piece by
piece some stuff from my weird app : plugins (1 by 1),
initializers, locales, libs, …</p>
<p>Then I remembered that I've seen something strange in Rails
about the rfc822 method :</p>
<p><a href="http://github.com/rails/rails/tree/2-2-stable/activesupport/lib/active_support/time_with_zone.rb">
http://github.com/rails/rails/tr...</a> (lines 145 -> 152</p>
<pre><code>
def to_s(format = :default)
return utc.to_s(format) if format == :db
if formatter = ::Time::DATE_FORMATS[format]
formatter.respond_to?(:call) ? formatter.call(self).to_s : strftime(formatter)
else
"#{time.strftime("%Y-%m-%d %H:%M:%S")} #{formatted_offset(false, 'UTC')}" # mimicking Ruby 1.9 Time#to_s format
end
end
</code></pre>
<p>I can see that it checks if the formatter respond_to? :call and
if not it uses a basic strftime.</p>
<p>In my new app whre it's working great, I've got this :</p>
<pre><code>
I18n.locale : fr
I18n.default_locale : fr
Date.today.strftime("%A") : Saturday
Time.now.strftime("%A") : Saturday
Time.now.rfc822 : Sat, 03 Jan 2009 02:13:06 +0100
Time.now.strftime("%a, %d %b %Y %T %z") : Sat, 03 Jan 2009 02:13:06 +0100
I18n.l(Time.now, :format => "%a, %d %b %Y %T %z") : Sam, 03 Jan 2009 02:13:06 +0100
</code></pre>
<p>It shows that if I try to localize a Time with a strftime format
it's indeed localized.</p>
<p>So I think that maybe it's going through a localized strftime
instead of the normal call.</p>
<p>By the way I dont really understand what
"formatter.call(self).to_s" does. If it's calling a method named
after the formatter if it exists, with self as paramater, it means
that it tries to call a rfc822() method. Anyway, I don't get it
!</p></div>
true
2009-01-03T01:27:41+00:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
invalid
i18n
RFC822 shouldn't be localized
2009-01-03T01:27:43+00:00
18793
Jérémy
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x
0
According to my findings, the localized_dates plugin causes Time.to_s(:rfc822) to be formatted. I'll file a bug report to the maintainers.
<div><p>According to my findings, the localized_dates plugin causes
Time.to_s(:rfc822) to be formatted. I'll file a bug report to the
maintainers.</p></div>
true
2009-06-03T09:38:08+01:00
18793
--- {}
9903
1596
rfc822-shouldnt-be-localized
0
8994
invalid
i18n
RFC822 shouldn't be localized
2009-06-03T09:38:13+01:00
3117
Bart Zonneveld
Jérémy
http://rails.lighthouseapp.com/projects/8994/tickets/1596
2.x