Small named_scope_test.rb fix
Reported by Rodrigo Kochenburger | May 14th, 2008 @ 02:31 AM | in 2.1.1
In the test that checks if named_scope is accessible through a has_many :through association was broken.
There is a typo in it and the appropriate fixtures aren't being loaded.
This patch fix it.
Comments and changes to this ticket
-
rick May 14th, 2008 @ 02:32 AM
- → Milestone changed from “” to “2.1.1”
- → State changed from “new” to “open”
- → Assigned user changed from “” to “rick”
-
Joshua Peek May 14th, 2008 @ 06:39 PM
It seems like an obvious typo, but why are the tests passing without the fix?
-
Rodrigo Kochenburger May 14th, 2008 @ 07:32 PM
Hm? The tests failed for me. That is the reason why i created the patch in the first place.
Can anybody else confirm this?
-
Joshua Peek May 14th, 2008 @ 09:03 PM
Maybe, I should of clarified what db. I tested on sqlite 3.4 and mysql 5.0.51a.
-
rick May 16th, 2008 @ 01:54 AM
How'd it fail? It seems like an array of posts should never equal a scoped array of comments.
-
Repository May 16th, 2008 @ 01:57 AM
- → State changed from “open” to “resolved”
(from [5a3fd46d42f05a241b3178af60d38fe5e0cebee6]) Fixing test for named_scope through a has_many :through
The test that checks if a has_many :through association has access to named_scope had a typo and
didn't have the proper fixtures loaded. [#190 state:resolved]
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
