#203 Added fragment_exist? method - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#203 ✓resolved

Added fragment_exist? method

Reported by José Valim | May 15th, 2008 @ 12:04 PM

Added fragment_exist? method.

This is most useful when using file_store cause You reduce the IO operations. And it's better then doing:

read_fragment(path).nil?

To this work properly, I also added an exist? method in all cache stores.

Tests included.

ps: For some strange reason, git format-patch doesn't work properly here (patch is not created).

fragment_exist_method.diff 7.5 KB

Comments and changes to this ticket

Tobias Lütke May 15th, 2008 @ 07:34 PM
Looks good, i'm inclined to apply the patch.
Can you guys add me to the rails project?
Pratik May 16th, 2008 @ 03:27 PM
Few things.
1. Could you please use git-format-patch ? It should be possible to get help in #git, #github or #rails-contrib if you're having troubles with that.
2. Your diff is changing permission of files, which is not needed.
Other than that, thanks for the patch!
@Tobias Lütke : Invited you to the project.
Pratik May 16th, 2008 @ 03:30 PM
- Assigned user set to “Tobias Lütke”
José Valim May 16th, 2008 @ 04:06 PM
1. I think that it's a problem with cygwin (yep, I'm using Windows =/)
2. What do You mean with changing permission of files?
Pratik May 16th, 2008 @ 04:10 PM
If you look at the generated diff files, you'll see things like :
diff --git a/activesupport/lib/active_support/cache.rb b/activesupport/lib/active_support/cache.rb
old mode 100644
new mode 100755
That's not needed.
José Valim May 16th, 2008 @ 06:16 PM
Ok, patch done in the right away!
Would be nice if someone adds to the tutorial http://rails.lighthouseapp.com/p..., that you have to do a commit to the working branch before create the patch with format-patch.
- 0001-Added-fragment_exist-method-and-a-exist-method-to.patch 8.3 KB
Repository May 19th, 2008 @ 10:47 AM
- State changed from “new” to “resolved”
(from [99860b72aebe0348f41e82d4710343498d89a84b]) Add fragment_exist? and exist? methods to cache stores. [#203 state:resolved]
Signed-off-by: Pratik Naik
http://github.com/rails/rails/co...