Improve Rails.env
Reported by Markús | May 16th, 2008 @ 08:51 AM | in 2.1.1
Hi
In this commit http://github.com/rails/rails/co..., you (Pratik), insert a serie of shortcuts for RAILS_* constants.
Well, I like this change, but I think it can be improved to make something like this:
Rails.env # => "production"
Rails.env.production? # => true
Rails.env.development? # => false
This can be achieved adding a few lines to the Rails.env method:
def self.env
env = RAILS_ENV
def env.production? # Or method_missing
self == "production"
end
def env.development?
self == "development"
end
def env.test?
self == "test"
end
end
env # returns the RAILS_ENV string
end
May be a "method_missing" could ba a better solution, but this is only an example.
Comments and changes to this ticket
-
DHH May 31st, 2008 @ 09:35 PM
- → State changed from new to incomplete
We'd definitely have to make a solution that would be general purpose enough to deal with all possible environments. Many people add their own environments, like benchmarking or staging. Please reopen if you come up with a implementation to do that.
-
Luke Redpath June 24th, 2008 @ 02:56 PM
I believe this ticket has been resolved as of this changeset.
-
Jeremy Kemper June 24th, 2008 @ 05:23 PM
- → Milestone changed from to 2.1.1
- → State changed from incomplete to resolved
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
