141 3 true 2008-04-19T08:31:31+01:00 949 2009-03-18T00:00:00+00:00 9901 22 default_url_options-is-being-ignored-by-named-route-optimisation 11107 8994 stale actionpack routing 2008-08-30T02:18:51+01:00 85 Jeremy Kemper Deepak Jois Michael Koziarski http://rails.lighthouseapp.com/projects/8994/tickets/22 2.1.1 This is basically the same as http://dev.rubyonrails.org/ticket/10925 It seems that the reeason it happens is that the optimisation code for named routes uses the request.host_with_string and request.protocol without calling default_url_option at any time (as in the url_for method) This is basically the same as http://dev.rubyonrails.org/ticket/10925 It seems that the reeason it happens is that the optimisation code for named routes uses the request.host_with_string and request.protocol without calling default_url_option at any time (as in the url_for method) <div><p> This is basically the same as </p><p> <a href="http://dev.rubyonrails.org/ticket/10925">http://dev.rubyonrails.org/ticke...</a> </p><p> It seems that the reeason it happens is that the optimisation code for named routes uses the request.host_with_string and request.protocol without calling default_url_option at any time (as in the url_for method) </p></div> 0 This is basically the same as http://dev.rubyonrails.org/ticket/10925 It seems that the reeason it happens is that the optimisation code for named routes uses the request.host_with_string and request.protocol without calling default_url_option at any time (as in the url_for method) <div><p> This is basically the same as </p><p> <a href="http://dev.rubyonrails.org/ticket/10925">http://dev.rubyonrails.org/ticke...</a> </p><p> It seems that the reeason it happens is that the optimisation code for named routes uses the request.host_with_string and request.protocol without calling default_url_option at any time (as in the url_for method) </p></div> false 2008-04-19T08:31:31+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 new 2008-04-19T08:31:31+01:00 949 Deepak Jois Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 0 Here's a patch that checks for the existence of a non-blank #default_url_options and bypasses named route optimization: http://github.com/chuyeow/rails/commit/3bb863d63198080e26afbdc72e483315c8bc1be8 <div><p> Here's a patch that checks for the existence of a non-blank #default_url_options and bypasses named route optimization: <a href="http://github.com/chuyeow/rails/commit/3bb863d63198080e26afbdc72e483315c8bc1be8">http://github.com/chuyeow/rails/...</a> </p></div> false 2008-04-20T06:02:33+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 new 2008-04-20T06:02:33+01:00 586 Cheah Chu Yeow Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 0 Attaching a patch instead - gonna delete my branch. <div><p> Attaching a patch instead - gonna delete my branch. </p></div> false 2008-04-27T12:44:57+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 new 2008-04-27T12:44:57+01:00 586 Cheah Chu Yeow Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 +1 applies cleanly on 6f20efd (Wed Apr 30 23:30:50 2008 -0500) I've been bitten by this one, thanks for the patch <div><p> +1 applies cleanly on 6f20efd (Wed Apr 30 23:30:50 2008 -0500) </p><p> I've been bitten by this one, thanks for the patch </p></div> false 2008-05-01T08:36:00+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 new 2008-05-01T08:36:00+01:00 1023 Ian White Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 +1 looks good, better than my local solution to the referenced ticket :) Patch applied fine to 74436d (Thu May 1 10:21:46 2008 +0100) after removing the empty line changes in action_controller/base.rb <div><p> +1 looks good, better than my local solution to the referenced ticket :) Patch applied fine to 74436d (Thu May 1 10:21:46 2008 +0100) after removing the empty line changes in action_controller/base.rb </p></div> false 2008-05-01T16:07:12+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 new 2008-05-01T16:07:12+01:00 2529 Daniel Guettler Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 (from [6a6b4392c16c665eb713705f2b38e959a658eeef]) Ensure that default_url_options, if defined, are used in named routes. Signed-off-by: Michael Koziarski <michael@koziarski.com> [#22 state:resolved] http://github.com/rails/rails/commit/6a6b4392c16c665eb713705f2b38e959a658eeef <div><p> (from [6a6b4392c16c665eb713705f2b38e959a658eeef]) Ensure that default_url_options, if defined, are used in named routes. </p><p> Signed-off-by: Michael Koziarski </p><p> [#22 state:resolved] </p><p> <a href="http://github.com/rails/rails/commit/6a6b4392c16c665eb713705f2b38e959a658eeef">http://github.com/rails/rails/co...</a> </p></div> true 2008-05-04T01:50:24+01:00 949 --- :state: new 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T01:50:24+01:00 17393 Repository Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 For the next major release we will probably deprecate / remove default_url_options. But in the meantime nice patch. <div><p> For the next major release we will probably deprecate / remove default_url_options. But in the meantime nice patch. </p></div> true 2008-05-04T01:51:07+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T01:51:07+01:00 141 Michael Koziarski Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 Hmm, pity to see it go. I found it useful in cases where you want to add some parameters to the urls based on if some methods on a controller return a value or return nil. E.g. an url may need a section_id to identify the area it's accessed from, but this is not needed always and can change dynamically. In this case you can add { :section_id => SomeController.section_id } to the default_url_options and don't have to worry about it anymore in each generated url. Is there are better way to archive this? Daniel <div><p> Hmm, pity to see it go. I found it useful in cases where you want to add some parameters to the urls based on if some methods on a controller return a value or return nil. </p><p> E.g. an url may need a section_id to identify the area it's accessed from, but this is not needed always and can change dynamically. In this case you can add { :section_id => SomeController.section_id } to the default_url_options and don't have to worry about it anymore in each generated url. </p><p> Is there are better way to archive this? </p><p> Daniel </p></div> true 2008-05-04T02:04:56+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T02:04:56+01:00 2529 Daniel Guettler Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 Thanks for applying the patch. I agree with Daniel. I found the default_url_options quite useful for my app where I had to redirect from a subdomain to the main domain name for some pages. Without default_url_options, I would have to insert a hash with hostname and port into every url call. It would be better to fix the optimisation of routes to take into account values from the default_url_options hash. <div><p> Thanks for applying the patch. </p><p> I agree with Daniel. I found the default_url_options quite useful for my app where I had to redirect from a subdomain to the main domain name for some pages. Without default_url_options, I would have to insert a hash with hostname and port into every url call. </p><p> It would be better to fix the optimisation of routes to take into account values from the default_url_options hash. </p></div> true 2008-05-04T05:33:30+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T05:33:30+01:00 949 Deepak Jois Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 We definitely need something else which is like default_url_options, which is why we haven't removed it yet :). <div><p> We definitely need something else which is like default_url_options, which is why we haven't removed it yet :). </p></div> true 2008-05-04T05:41:25+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T05:41:25+01:00 141 Michael Koziarski Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 Since this commit, all of my named_routes are failing with @@@ruby ArgumentError: wrong number of arguments (1 for 0) from (eval):2:in `default_url_options' @@@ Example: (On a clean rails app, with rails at 6a6b439) @@@ruby # (in routes.rb) map.resources :things @@@ @@@ruby $ script/console >> include ActionController::UrlWriter => Object >> things_path ArgumentError: wrong number of arguments (1 for 0) from (eval):2:in `default_url_options' from (eval):2:in `things_path' from (irb):3 @@@ I'm investigating a patch <div><p> Since this commit, all of my named_routes are failing with </p> <pre><code class="uby">ArgumentError: wrong number of arguments (1 for 0) from (eval):2:in `default_url_options' </code></pre> <p> Example: (On a clean rails app, with rails at 6a6b439) </p> <pre><code class="uby"> # (in routes.rb) map.resources :things </code></pre> <pre><code class="uby">$ script/console &gt;&gt; include ActionController::UrlWriter =&gt; Object &gt;&gt; things_path ArgumentError: wrong number of arguments (1 for 0) from (eval):2:in `default_url_options' from (eval):2:in `things_path' from (irb):3 </code></pre> <p> I'm investigating a patch </p></div> true 2008-05-04T16:27:54+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T16:27:54+01:00 1023 Ian White Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 1 Ack I see why that's a problem (and why it wasn't covered by existing tests nor my test in the applied patch) - default_url_options takes a single argument in AC::B but is simply a (hash) attribute in ActionController::UrlWriter. Ian thanks for spotting this! I'm attaching a patch that is a quick fix for this. Basically it gives AC::B#default_url_options a default argument. I didn't want to remove it since I imagine that would involve deprecation. <div><p> Ack I see why that's a problem (and why it wasn't covered by existing tests nor my test in the applied patch) - default_url_options takes a single argument in AC::B but is simply a (hash) attribute in ActionController::UrlWriter. </p><p> Ian thanks for spotting this! </p><p> I'm attaching a patch that is a quick fix for this. Basically it gives AC::B#default_url_options a default argument. I didn't want to remove it since I imagine that would involve deprecation. </p></div> true 2008-05-04T16:59:39+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T16:59:39+01:00 586 Cheah Chu Yeow Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 2 Btw, now I'm more convinced that default_url_options does need some cleaning up/re-thinking! <div><p> Btw, now I'm more convinced that default_url_options does need some cleaning up/re-thinking! </p></div> true 2008-05-04T17:00:48+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T17:00:48+01:00 586 Cheah Chu Yeow Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 2 Here's a testcase that fails on 6a6b43 but passes on the previous commit 437f918 (you have to paste the test into 437f918- the diff doesn't apply) <div><p> Here's a testcase that fails on 6a6b43 but passes on the previous commit 437f918 </p><p> (you have to paste the test into 437f918- the diff doesn't apply) </p></div> true 2008-05-04T17:23:04+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T17:23:04+01:00 1023 Ian White Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 3 No worries, uploaded my test patch without seeing Cheah Chu Yeow's updates updates on this ticket, you can just ignore it <div><p> No worries, uploaded my test patch without seeing Cheah Chu Yeow's updates updates on this ticket, you can just ignore it </p></div> true 2008-05-04T17:25:32+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T17:25:32+01:00 1023 Ian White Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 3 Does this need to re-opened as a new ticket? I notice that it's status is 'resolved'. <div><p> Does this need to re-opened as a new ticket? I notice that it's status is 'resolved'. </p></div> true 2008-05-04T20:20:02+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T20:20:02+01:00 1023 Ian White Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 3 apostrophe man commin to get me... I wish I could edit lighthouse comments <div><p> apostrophe man commin to get me... I wish I could edit lighthouse comments </p></div> true 2008-05-04T20:22:24+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T20:22:24+01:00 1023 Ian White Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 3 Actually I see that Cheah Chu Yeow's patch doesn't include a regression test, so it might be useful to use the diff I attached for that. <div><p> Actually I see that Cheah Chu Yeow's patch doesn't include a regression test, so it might be useful to use the diff I attached for that. </p></div> true 2008-05-04T20:24:58+01:00 949 --- {} 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-04T20:24:58+01:00 1023 Ian White Deepak Jois http://rails.lighthouseapp.com/projects/8994/tickets/22 141 3 I'll get to this today. <div><p> I'll get to this today. </p></div> false 2008-05-04T22:52:40+01:00 949 --- :state: resolved :assigned_user: :milestone: 9901 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 open 2008-05-04T22:52:40+01:00 141 Michael Koziarski Deepak Jois Michael Koziarski http://rails.lighthouseapp.com/projects/8994/tickets/22 2.1.1 141 3 Too slow! I got it... <div><p> Too slow! I got it... </p></div> false 2008-05-06T07:43:13+01:00 949 --- {} 9901 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 open 2008-05-06T07:43:13+01:00 1 Rick Deepak Jois Michael Koziarski http://rails.lighthouseapp.com/projects/8994/tickets/22 2.1.1 141 3 (from [37599d16f2374179ebf001aeb79ff121e3d67519]) regression test for bug introduced in [6a6b4392c16c665eb713705f2b38e959a658eeef] [Ian White] [#22 state:resolved] http://github.com/rails/rails/commit/37599d16f2374179ebf001aeb79ff121e3d67519 <div><p> (from [37599d16f2374179ebf001aeb79ff121e3d67519]) regression test for bug introduced in [6a6b4392c16c665eb713705f2b38e959a658eeef] [Ian White] [#22 state:resolved] </p><p> <a href="http://github.com/rails/rails/commit/37599d16f2374179ebf001aeb79ff121e3d67519">http://github.com/rails/rails/co...</a> </p></div> true 2008-05-06T07:46:33+01:00 949 --- :state: open 9901 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved 2008-05-06T07:46:33+01:00 17393 Repository Deepak Jois Michael Koziarski http://rails.lighthouseapp.com/projects/8994/tickets/22 2.1.1 141 3 This problem still arises for named routes used in views instead of controllers. I have default_url_options defined in app/controllers/application.rb; routes that are generated from the controller seem to be fine, whereas routes generated from the views do not. Adding the following to app/helpers/application_helper.rb works around the issue: @@@ruby def default_url_options(options = nil) @controller.send(:default_url_options, options) end @@@ <div><p> This problem still arises for named routes used in views instead of controllers. I have default_url_options defined in app/controllers/application.rb; routes that are generated from the controller seem to be fine, whereas routes generated from the views do not. </p><p> Adding the following to app/helpers/application_helper.rb works around the issue: </p> <pre><code class="uby">def default_url_options(options = nil) @controller.send(:default_url_options, options) end </code></pre></div> true 2008-07-18T01:13:29+01:00 949 --- :tag: 9901 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 resolved actionpack patch routing 2008-07-18T01:13:29+01:00 25003 Phil Orwig Deepak Jois Michael Koziarski http://rails.lighthouseapp.com/projects/8994/tickets/22 2.1.1 141 3 false 2008-07-18T17:55:55+01:00 949 --- :tag: actionpack patch routing :state: resolved 9901 22 default_url_options-is-being-ignored-by-named-route-optimisation 0 8994 open actionpack routing 2008-07-18T17:55:55+01:00 1366 Pratik Deepak Jois Michael Koziarski http://rails.lighthouseapp.com/projects/8994/tickets/22 2.1.1 141 3 This looks like a simple fix, but it's growing stale here. Please write a test and submit a patch. <div><p>This looks like a simple fix, but it's growing stale here. Please write a test and submit a patch.</p></div> true 2008-08-30T02:18:51+01:00 949 --- :state: open 9901 22 default_url_options-is-being-ignored-by-named-route-optimisation-2 0 8994 stale actionpack routing 2008-08-30T02:18:51+01:00 85 Jeremy Kemper Deepak Jois Michael Koziarski http://rails.lighthouseapp.com/projects/8994/tickets/22 2.1.1 9613af3bf28d1f24fcbd0df45f08b685be5cc404 text/plain 2008-04-27T12:44:57+01:00 default_url_options_named_routes.patch 20339 4751 586 http://rails.lighthouseapp.com/attachments/20339/default_url_options_named_routes.patch 23b24ac4705d5e85eab6f5053c41b55e4df066b0 text/plain 2008-05-04T16:59:39+01:00 fix_default_url_options_regression.diff 21394 3847 586 http://rails.lighthouseapp.com/attachments/21394/fix_default_url_options_regression.diff f6a72538d7174f7796ff6a81d0f1d9c2c6488698 text/plain 2008-05-04T17:23:04+01:00 ticket22_bug.diff 21396 782 1023 http://rails.lighthouseapp.com/attachments/21396/ticket22_bug.diff