Make auto_link accept parentheses in URLs
Reported by Adam Traver | May 21st, 2008 @ 09:24 PM
Currently, the regular expression used in auto_link_urls and, by association, auto_link, does not allow for parentheses in URLs.
While this is not a very common occurrence (nor proper, I don't believe, but I could be wrong), there are certain highly populated sites that use this format. Take Wikipedia, for instance:
http://en.wikipedia.org/wiki/Spr...(computer_graphics)
With the current implementation of auto_link, the link you get back looks like this:
<a href="http://en.wikipedia.org/wiki/Sprite_">http://en.wikipedia.org/wiki/Spr...</a>(computer_graphics)
This patch adds both opening and closing parentheses to the list of allowable characters for the path in the AUTO_LINK_RE regular expression.
P.S. This is my first submission, so if I've done anything wrong in the patch/ticket creation process, please don't freak out. :-p
Comments and changes to this ticket
-
Ryan Bates May 21st, 2008 @ 11:51 PM
+1, tested patch and looks good. Nice job on your first submission!
-
Repository May 22nd, 2008 @ 11:33 AM
- → State changed from “new” to “resolved”
(from [314e556e6fb7278e37f6105fedbe5fc51f7f848a]) Parentheses should be acceptable characters for auto_link_urls. [#234 state:resolved]
Signed-off-by: Pratik Naik
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
