better coloration on error messages
Reported by Roger | May 23rd, 2008 @ 10:53 PM
this patch makes it so that on rails' code based error messages, the filename is shown in red, so that people can identify more easily which file they need to go and edit. I like it for helping it stand out more, but not too much. Purely aesthetic, but nice.
-R
Comments and changes to this ticket
-
Roger May 23rd, 2008 @ 11:01 PM
to test this patch apply, then add a syntax error to a view, and go to that view. It should have a red filename now [dark red].
-
Roger May 23rd, 2008 @ 11:35 PM
This version of the patch [v2] now adds coloration for the line on which the error occurred.
-
-
Roger May 24th, 2008 @ 12:20 AM
v4 combine all commits into a single commit, add better colors. This is a nice patch for being able to instantly see which line your code erred on.
-
Adam S May 24th, 2008 @ 01:31 PM
+1
Errors can definitely be improved in Rails (see mod_rails errors for an example), these changes don't go a long way, but also don't hurt.
-
Pratik June 17th, 2008 @ 05:24 PM
- → Milestone cleared.
- → State changed from “new” to “incomplete”
- → Assigned user changed from “” to “Pratik”
I tried it and it was very difficult to see the red color. I think you should discuss this change in rails core mailing list. There might be other similar places where we can improve error reporting.
-
Roger June 20th, 2008 @ 07:22 PM
I almost wonder if it wouldn't be even more helpful to include more with the error messages. Like an inspection of the controller's local variables. My thought is to [eventually] post some prototype error pages so we can decide on a reasonable color scheme. mod_rails style might work, too. They're nice.
Thanks.
-R
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
