Shouldn't script/generate scaffold create partials?
Reported by soleone (at gmail) | May 25th, 2008 @ 07:04 PM
Whenever I use the scaffold-generator for a model, I always find me editing the New, Edit, Show and Index views to render partials.
Example:
I have a Post model. Then I always need:
-
_post.html.erbto view my Posts -
_edit_post.html.erbto edit/create my Posts
Is there any reasons the generator should not create these two partials and then call them in the CRUD-views?
It would also get new users into the habit of using partials, when they have been already created for them.
Maybe I could implement it myself - though I've never contributed anything yet and it could take my fairly long - if someone says it would be a welcome patch.
Comments and changes to this ticket
-
DHH May 31st, 2008 @ 09:28 PM
- → State changed from “new” to “resolved”
I don't think it should. Partials make it harder to follow and are great as a first "exercise for the reader". Scaffold code doesn't really need to be optimized, it's more important to teach some simple lessons and invite people to change it.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
