Model objects are falsely marked as not-new after transaction rollback
Reported by pdietrich | May 26th, 2008 @ 05:26 PM
Consider the following code from a controller action:
begin
@auction.transaction do
@auction.save!
@lot.auction = @auction
@lot.save!
flash[:notice] = 'Auction was successfully created.'
redirect_to(@auction)
end
rescue
render :action => "new"
end
If no validations fail on @auction ActiveRecord considers it saved even if the transaction cannot be finished successfully (e.g. when @lot.save raises an exception). Hence @auction.new_record? will return false although the record is not saved in the DB.
This leads a problem in the view:
form_for(@auction)
will generate a put (to controller action 'update') instead of a post (to controller action 'create').
I think the right way to fix this is to remember which model objects have been saved in a transaction and to revert their state after rollback. Any suggestions how this could be done the best?
Comments and changes to this ticket
-
Xavier Noria May 26th, 2008 @ 06:17 PM
Also timestamps are not rolled back, so the new record may have an initialized created_at. (Related to #93.)
-
Carl Porth May 28th, 2008 @ 06:05 AM
I'm attaching an update to TransactionTest#test_callback_rollback_in_create to expose this bug. Perhaps it will be of use to someone who knows the transaction code well.
-
Joshua Peek August 29th, 2008 @ 04:41 PM
- → Tag changed from “” to “2.0-stable activerecord activeresource tests transaction”
- → State changed from “new” to “stale”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
