Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

make count(:conditions => {}) work on has_many associations

#271

When using conditions from a variable, it can sometimes be an empty hash (at least in my projects). When using it with count on a ActiveRecord::Base:

User.count :conditions => {}
# => 3

But when working on a has_many association, this happens:

>> User.first.certificates.count :conditions => {}
ActiveRecord::StatementInvalid: Mysql::Error: #42000You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: SELECT count(*) AS count_all FROM `certificates`     WHERE (`certificates`.user_id = 442758120 AND ()) 

a patch to fix this has been attached

Reported by Jan De Poorter · May 28th, 2008 @ 08:01 PM

State: resolved
Milestone: none
Assigned to: nobody
Importance: none

Activity

  1. Repository
    Repository

    (from [abb1bd2efa43b8efbb3faf4ccfb9246704a9044c]) Ensure AssociationCollection#count works with empty condition. [#271 state:resolved] [Jan De Poorter]

    http://github.com/rails/rails/co...

    May 29th, 2008 @ 11:11 AM

  2. Pratik
    Pratik
    • State changed from new to resolved

    May 29th, 2008 @ 12:30 PM