3 true 2009-06-11T15:32:28+01:00 44567 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 1892 8994 duplicate activerecord batches find_in_batches master 2009-09-11T11:10:28+01:00 7211 Mike Gunderloy Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x When you use find_in_batches it turns out that there is a with_scope that gets executed, which could lead to unexpected behavior. See the attached unit test for an example. The idea of the test is to get all posts with body "hello" in batches of 2 and for each post get its author and count the number of posts he/she has. The easiest fix is to put with_exclusive_scope around the yield, but that could affect people who used with_scope around find_in_batches. The harder fix will be not to use with_scope. When you use find_in_batches it turns out that there is a with_scope that gets executed, which could lead to unexpected behavior. See the attached unit test for an example. The idea of the test is to get all posts with body "hello" in batches of 2 and for each post get its author and count the number of posts he/she has. The easiest fix is to put with_exclusive_scope around the yield, but that could affect people who used with_scope around find_in_batches. The harder fix will be not to use with_scope. <div><p>When you use find_in_batches it turns out that there is a with_scope that gets executed, which could lead to unexpected behavior. See the attached unit test for an example. The idea of the test is to get all posts with body "hello" in batches of 2 and for each post get its author and count the number of posts he/she has.</p> <p>The easiest fix is to put with_exclusive_scope around the yield, but that could affect people who used with_scope around find_in_batches. The harder fix will be not to use with_scope.</p></div> 0 When you use find_in_batches it turns out that there is a with_scope that gets executed, which could lead to unexpected behavior. See the attached unit test for an example. The idea of the test is to get all posts with body "hello" in batches of 2 and for each post get its author and count the number of posts he/she has. The easiest fix is to put with_exclusive_scope around the yield, but that could affect people who used with_scope around find_in_batches. The harder fix will be not to use with_scope. <div><p>When you use find_in_batches it turns out that there is a with_scope that gets executed, which could lead to unexpected behavior. See the attached unit test for an example. The idea of the test is to get all posts with body "hello" in batches of 2 and for each post get its author and count the number of posts he/she has.</p> <p>The easiest fix is to put with_exclusive_scope around the yield, but that could affect people who used with_scope around find_in_batches. The harder fix will be not to use with_scope.</p></div> false 2009-06-11T15:32:30+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-06-11T15:32:30+01:00 44567 Valentin Mihov Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 1 Here is the fix with adding with_exclusive_scope around the yield statement <div><p>Here is the fix with adding with_exclusive_scope around the yield statement</p></div> false 2009-06-11T15:34:49+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-06-11T15:34:49+01:00 44567 Valentin Mihov Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 2 Here is another fix of the problem. This time the with_scope is removed from the yield and no with_exclusive_scope is used. This one should be a better solution. There is some code duplication but I didn't figure out a way to remove it. Probably a private method could be made to avoid that? <div><p>Here is another fix of the problem. This time the with_scope is removed from the yield and no with_exclusive_scope is used. This one should be a better solution. There is some code duplication but I didn't figure out a way to remove it. Probably a private method could be made to avoid that?</p></div> false 2009-06-11T17:15:29+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-06-11T17:15:29+01:00 44567 Valentin Mihov Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 3 I don't understand why the exclusive scope is needed. Shouldn't you be able to do Shirt.red.find_each and find_each then do the right thing? <div><p>I don't understand why the exclusive scope is needed. Shouldn't you be able to do Shirt.red.find_each and find_each then do the right thing?</p></div> false 2009-08-01T21:21:44+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-08-01T21:21:48+01:00 34034 Elliot Winkler Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 3 The problem here is that when you make additional queries into a find_each block, the queries are affected in an unexpected behavior. Have a look at the unit test in the diff. In that example you have posts. Each post have a body and an author_id. You make a find_each for all posts with a given body (ex. "Hello world!"). In the find_each block imagine that you start processing a post from the author X. You want to count how many posts X has and you do Post.all(:conditions => { :author_id => id_of_author_X }). Unfortunately this query will return the number of posts from author X, which has a body equal to "Hello world!", which is obviously not the idea in that situation. <div><p>The problem here is that when you make additional queries into a find_each block, the queries are affected in an unexpected behavior.</p> <p>Have a look at the unit test in the diff. In that example you have posts. Each post have a body and an author_id. You make a find_each for all posts with a given body (ex. "Hello world!"). In the find_each block imagine that you start processing a post from the author X. You want to count how many posts X has and you do Post.all(:conditions =&gt; { :author_id =&gt; id_of_author_X }). Unfortunately this query will return the number of posts from author X, which has a body equal to "Hello world!", which is obviously not the idea in that situation.</p></div> false 2009-08-19T09:18:59+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-08-19T09:19:01+01:00 44567 Valentin Mihov Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 3 Ah, my bad, you were already one step ahead. +1, then -- makes sense to me. <div><p>Ah, my bad, you were already one step ahead. +1, then -- makes sense to me.</p></div> false 2009-08-19T11:13:30+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-08-19T11:13:36+01:00 34034 Elliot Winkler Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 3 There is a similar one at #2227 <div><p>There is a similar one at <a href="/projects/8994/tickets/2227" title="Ticket #2227">#2227</a></p></div> false 2009-09-08T12:09:09+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-09-08T12:09:13+01:00 69039 Thong Kuah Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 3 Yep... #2227 seems to be the same bug <div><p>Yep... <a href="/projects/8994/tickets/2227" title= "Ticket #2227">#2227</a> seems to be the same bug</p></div> false 2009-09-08T12:35:23+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-09-08T12:35:25+01:00 44567 Valentin Mihov Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 3 > Yep... #2227 seems to be the same bug would you be willing to merge this ticket into #2227 and review the patch there? We are only one short of getting patch verified and applied. Thanks <div><blockquote> <p>Yep... <a href="/projects/8994/tickets/2227" title= "Ticket #2227">#2227</a> seems to be the same bug</p> </blockquote> <p>would you be willing to merge this ticket into <a href= "/projects/8994/tickets/2227" title="Ticket #2227">#2227</a> and review the patch there? We are only one short of getting patch verified and applied. Thanks</p></div> false 2009-09-10T13:33:10+01:00 44567 --- {} 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 new activerecord batches find_in_batches master 2009-09-10T13:33:13+01:00 69039 Thong Kuah Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 3 Dupe of #2227 <div><p>Dupe of <a href="/projects/8994/tickets/2227" title= "Ticket #2227">#2227</a></p></div> true 2009-09-11T11:10:17+01:00 44567 --- :state: new 9903 2791 activerecordbasefind_in_batches-puts-a-with_scope-into-the-block-that-is-executed 0 8994 duplicate activerecord batches find_in_batches master 2009-09-11T11:10:28+01:00 7211 Mike Gunderloy Valentin Mihov http://rails.lighthouseapp.com/projects/8994/tickets/2791 2.x 8aa3b39a98443e4f2839114c1ef39ebfaa38e8c5 text/plain 2009-06-11T15:32:29+01:00 0001-Added-a-unit-test-for-catching-the-with_scope-into-t.patch 132112 1332 44567 http://rails.lighthouseapp.com/attachments/132112/0001-Added-a-unit-test-for-catching-the-with_scope-into-t.patch 4a45a1a0e7ebbe76fdf9e3b313e35051cc07fbc5 text/plain 2009-06-11T15:34:47+01:00 0002-Added-with_exclusive_scope-around-the-find_in_batche.patch 132116 1019 44567 http://rails.lighthouseapp.com/attachments/132116/0002-Added-with_exclusive_scope-around-the-find_in_batche.patch a4dcd5163456bdc9b6602c00a67c7585c359d4b1 text/plain 2009-06-11T17:15:25+01:00 removed_with_scope_around_yield.patch 132176 3977 44567 http://rails.lighthouseapp.com/attachments/132176/removed_with_scope_around_yield.patch