ActionView class method to set default order for date and time field helpers
Reported by Adam Meehan | April 21st, 2008 @ 08:28 AM
If you need to explicitly set the date order when using the date and time field helpers, then it is likely you will need to do it everywhere in your app.
This patch adds the class accessor default_date_select_order to ActionView::Base which allows the order to be set once in an initializer file to keep things nice and DRY.
Comments and changes to this ticket
-
Adam Meehan April 24th, 2008 @ 06:08 AM
- → Title changed from “Default order for date and time field helpers” to “Add class method to set default order for date and time field helpers”
-
Adam Meehan May 1st, 2008 @ 01:16 AM
- → Title changed from “Add class method to set default order for date and time field helpers” to “ActionView class method to set default order for date and time field helpers”
-
-
DHH May 1st, 2008 @ 04:56 AM
- → State changed from “new” to “invalid”
I understand the sentiment to why you'd want this, but I don't like the floating, global accessor on AV to control it. I think if you're often using similar defaults in your application, you should probably just wrap the call in a app-specific method.
Thanks for taking the time to work on a ticket, though. Looks like you did a good job with tests and all. I'm sure the next one will make it in ;)
-
Adam Meehan May 1st, 2008 @ 05:45 AM
Understood. I usually do use a method wrapper or a full form builder class for form intensive apps. Just thought it made for a sensible default option.
Thanks for the encouraging words, you're gentleman.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
