1 true 2009-06-24T18:44:12+01:00 46945 2831 activesupportjsondecode-explodes-in-certain-circumstances 1790 8994 resolved 2.3.2 activesupport json [PATCH] ActiveSupport::JSON.decode explodes in certain circumstances 2009-08-08T23:07:59+01:00 7211 Mike Gunderloy Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 ActiveSupport::JSON.decode has problems with JSON strings which include both quoted slashes and dates: @@@ >> ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}') IndexError: index 38 out of string from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `[]=' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `each' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:12:in `decode' @@@ Whether quoted slashes are actually valid JSON is not completely clear, but they are definitely seen in the wild -- the JSON gem's Hash#to_json method produces them, for example. ActiveSupport::JSON.decode has problems with JSON strings which include both quoted slashes and dates: @@@ >> ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}') IndexError: index 38 out of string from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `[]=' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `each' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:12:in `decode' @@@ Whether quoted slashes are actually valid JSON is not completely clear, but they are definitely seen in the wild -- the JSON gem's Hash#to_json method produces them, for example. <div><p>ActiveSupport::JSON.decode has problems with JSON strings which include both quoted slashes and dates:</p> <pre><code> &gt;&gt; ActiveSupport::JSON.decode('{&quot;r&quot;:&quot;http:\/\/foo&quot;,&quot;d&quot;:&quot;2004-06-24&quot;}') IndexError: index 38 out of string from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `[]=' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `each' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:12:in `decode' </code></pre> <p>Whether quoted slashes are actually valid JSON is not completely clear, but they are definitely seen in the wild -- the JSON gem's Hash#to_json method produces them, for example.</p></div> 0 ActiveSupport::JSON.decode has problems with JSON strings which include both quoted slashes and dates: @@@ >> ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}') IndexError: index 38 out of string from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `[]=' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `each' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:12:in `decode' @@@ Whether quoted slashes are actually valid JSON is not completely clear, but they are definitely seen in the wild -- the JSON gem's Hash#to_json method produces them, for example. <div><p>ActiveSupport::JSON.decode has problems with JSON strings which include both quoted slashes and dates:</p> <pre> <code>&gt;&gt; ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}') IndexError: index 38 out of string from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `[]=' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `each' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:75:in `convert_json_to_yaml' from /Library/Ruby/Gems/1.8/gems/activesupport-2.3.2/lib/active_support/json/decoding.rb:12:in `decode'</code> </pre> <p>Whether quoted slashes are actually valid JSON is not completely clear, but they are definitely seen in the wild -- the JSON gem's Hash#to_json method produces them, for example.</p></div> false 2009-06-24T18:44:12+01:00 46945 --- {} 9903 2831 activesupportjsondecode-explodes-in-certain-circumstances 0 8994 new 2.3.2 activesupport json ActiveSupport::JSON.decode explodes in certain circumstances 2009-06-24T18:44:18+01:00 46945 Martin Kleppmann Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 2.x 0 false 2009-07-02T20:16:42+01:00 46945 --- :state: new 9903 2831 activesupportjsondecode-explodes-in-certain-circumstances 0 8994 open 2.3.2 activesupport json ActiveSupport::JSON.decode explodes in certain circumstances 2009-07-02T20:16:45+01:00 12714 Yehuda Katz (wycats) Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 2.x 0 Here is a patch for this bug. I also believe this solves bug #2273. The cause of the bug is that between the moment when the position of the quotes around dates are tracked, and the moment those quotes are removed, the output string has changed size due to removing backslashes and/or decoding unicode sequences. Due to this wrong characters in the string are overwritten, causing Yaml to fail consequently, which causes a ParseError exception. This patch moves the code that replaces the quotes above the code that handles the backslashes and unicode sequences, before the string size changes. <div><p>Here is a patch for this bug. I also believe this solves bug <a href="/projects/8994/tickets/2273" title= "Ticket #2273">#2273</a>.</p> <p>The cause of the bug is that between the moment when the position of the quotes around dates are tracked, and the moment those quotes are removed, the output string has changed size due to removing backslashes and/or decoding unicode sequences. Due to this wrong characters in the string are overwritten, causing Yaml to fail consequently, which causes a ParseError exception.</p> <p>This patch moves the code that replaces the quotes above the code that handles the backslashes and unicode sequences, before the string size changes.</p></div> false 2009-08-01T01:40:11+01:00 46945 --- :title: ActiveSupport::JSON.decode explodes in certain circumstances 9903 2831 activesupportjsondecode-explodes-in-certain-circumstances 0 8994 open 2.3.2 activesupport json [PATCH] ActiveSupport::JSON.decode explodes in certain circumstances 2009-08-01T01:40:19+01:00 64701 Bas van Klinkenberg Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 2.x 1 false 2009-08-08T13:01:19+01:00 46945 --- :tag: 2.3.2 activesupport json 9903 2831 activesupportjsondecode-explodes-in-certain-circumstances 0 8994 open 2.3.2 activesupport bugmash json [PATCH] ActiveSupport::JSON.decode explodes in certain circumstances 2009-08-08T13:01:23+01:00 7211 Mike Gunderloy Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 2.x 1366 1 Patch is verified for above code. Before: <pre> ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}') IndexError: index 38 out of string from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `[]=' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `convert_json_to_yaml' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `each' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `convert_json_to_yaml' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:16:in `decode' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/decoding.rb:11:in `__send__' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/decoding.rb:11:in `decode' from (irb):1 </pre> After patch: <pre>ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}') => {"d"=>Thu, 24 Jun 2004, "r"=>"http://foo"} </pre> <div><p>Patch is verified for above code.</p> <p>Before:</p> <pre> ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}') IndexError: index 38 out of string from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `[]=' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `convert_json_to_yaml' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `each' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:77:in `convert_json_to_yaml' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/backends/yaml.rb:16:in `decode' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/decoding.rb:11:in `__send__' from /opt/rubyee/lib/ruby/gems/1.8/gems/activesupport-2.3.3/lib/active_support/json/decoding.rb:11:in `decode' from (irb):1 </pre> <p>After patch:</p> <pre> ActiveSupport::JSON.decode('{"r":"http:\/\/foo","d":"2004-06-24"}') =&gt; {"d"=&gt;Thu, 24 Jun 2004, "r"=&gt;"http://foo"} </pre></div> false 2009-08-08T13:18:01+01:00 46945 --- :assigned_user: 9903 2831 activesupportjsondecode-explodes-in-certain-circumstances 0 8994 open 2.3.2 activesupport bugmash json [PATCH] ActiveSupport::JSON.decode explodes in certain circumstances 2009-08-08T13:18:04+01:00 64156 Nikolay Petrachkov Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 2.x Pratik 1366 1 verified +1 This patch works perfectly. All tests pass. <div><p>verified</p> <p>+1 This patch works perfectly. All tests pass.</p></div> false 2009-08-08T16:25:44+01:00 46945 --- {} 9903 2831 activesupportjsondecode-explodes-in-certain-circumstances 0 8994 open 2.3.2 activesupport bugmash json [PATCH] ActiveSupport::JSON.decode explodes in certain circumstances 2009-08-08T16:25:48+01:00 65556 Rizwan Reza Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 2.x Pratik 1366 1 (from [0fbeaa98e4e60ca0949be298dae8545807407e1d]) Fixed a bug in JSON decoding with Yaml backend, where a combination of dates, escaped or unicode encoded data and arrays would make the parser fail with a ParseError exception. [#2831 state:resolved] Signed-off-by: Yehuda Katz <wycats@gmail.com> http://github.com/rails/rails/commit/0fbeaa98e4e60ca0949be298dae8545807407e1d <div><p>(from <a href= "/projects/8994/changesets/0fbeaa98e4e60ca0949be298dae8545807407e1d" title= "Changeset [0fbeaa98e4e60ca0949be298dae8545807407e1d]">[0fbeaa98e4e60ca0949be298dae8545807407e1d]</a>) Fixed a bug in JSON decoding with Yaml backend, where a combination of dates, escaped or unicode encoded data and arrays would make the parser fail with a ParseError exception. [<a href= "/projects/8994/tickets/2831" title="Ticket #2831">#2831</a> state:resolved]</p> <p>Signed-off-by: Yehuda Katz <a>wycats@gmail.com</a><br> <a href= "http://github.com/rails/rails/commit/0fbeaa98e4e60ca0949be298dae8545807407e1d"> http://github.com/rails/rails/commit/0fbeaa98e4e60ca0949be298dae854...</a></p></div> true 2009-08-08T16:45:27+01:00 46945 --- :state: open 9903 2831 activesupportjsondecode-explodes-in-certain-circumstances 0 8994 resolved 2.3.2 activesupport bugmash json [PATCH] ActiveSupport::JSON.decode explodes in certain circumstances 2009-08-08T16:45:29+01:00 17393 Repository Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 2.x Pratik 1 true 2009-08-08T23:07:54+01:00 46945 --- :tag: 2.3.2 activesupport bugmash json :assigned_user: 1366 :milestone: 9903 2831 activesupportjsondecode-explodes-in-certain-circumstances 0 8994 resolved 2.3.2 activesupport json [PATCH] ActiveSupport::JSON.decode explodes in certain circumstances 2009-08-08T23:07:59+01:00 7211 Mike Gunderloy Martin Kleppmann http://rails.lighthouseapp.com/projects/8994/tickets/2831 e6d8bb9ae4a6df220afb3a8092126ace79ea97b9 text/plain 2009-08-01T01:40:11+01:00 fix_active_support_json_decode_yaml_dates_and_escaped_data.diff 234122 4075 64701 http://rails.lighthouseapp.com/attachments/234122/fix_active_support_json_decode_yaml_dates_and_escaped_data.diff