1 true 2009-06-29T08:52:01+01:00 17407 9903 2849 encode-json-in-utf-8-instead-of-binary 1942 8994 resolved 3.0 activesupport encoding json ruby1.9 2009-07-02T00:27:46+01:00 17393 Repository Akira Matsuda http://rails.lighthouseapp.com/projects/8994/tickets/2849 2.x Since [default internal and external encodings are set to UTF-8 now](http://github.com/rails/rails/commit/cf3ccd7be0caae67dfddf5bc5056dcfdaab6f369) (IMO, this is quite a good decision), JSON encoding doesn't have to be BINARY [here](http://github.com/rails/rails/commit/30a3b6b4fc56390eec762c879644c95cd09622b0). And, String#encode! is enough for transcoding here because every JSON text is expected to be encoded in Unicode according to [the JSON RFC](http://www.ietf.org/rfc/rfc4627.txt). Attached a patch. Since [default internal and external encodings are set to UTF-8 now](http://github.com/rails/rails/commit/cf3ccd7be0caae67dfddf5bc5056dcfdaab6f369) (IMO, this is quite a good decision), JSON encoding doesn't have to be BINARY [here](http://github.com/rails/rails/commit/30a3b6b4fc56390eec762c879644c95cd09622b0). And, String#encode! is enough for transcoding here because every JSON text is expected to be encoded in Unicode according to [the JSON RFC](http://www.ietf.org/rfc/rfc4627.txt). Attached a patch. <div><p>Since <a href="http://github.com/rails/rails/commit/cf3ccd7be0caae67dfddf5bc5056dcfdaab6f369"> default internal and external encodings are set to UTF-8 now</a> (IMO, this is quite a good decision), JSON encoding doesn't have to be BINARY <a href="http://github.com/rails/rails/commit/30a3b6b4fc56390eec762c879644c95cd09622b0"> here</a>.</p> <p>And, String#encode! is enough for transcoding here because every JSON text is expected to be encoded in Unicode according to <a href="http://www.ietf.org/rfc/rfc4627.txt">the JSON RFC</a>.</p> <p>Attached a patch.</p></div> 0 Since [default internal and external encodings are set to UTF-8 now](http://github.com/rails/rails/commit/cf3ccd7be0caae67dfddf5bc5056dcfdaab6f369) (IMO, this is quite a good decision), JSON encoding doesn't have to be BINARY [here](http://github.com/rails/rails/commit/30a3b6b4fc56390eec762c879644c95cd09622b0). And, String#encode! is enough for transcoding here because every JSON text is expected to be encoded in Unicode according to [the JSON RFC](http://www.ietf.org/rfc/rfc4627.txt). Attached a patch. <div><p>Since <a href= "http://github.com/rails/rails/commit/cf3ccd7be0caae67dfddf5bc5056dcfdaab6f369"> default internal and external encodings are set to UTF-8 now</a> (IMO, this is quite a good decision), JSON encoding doesn't have to be BINARY <a href= "http://github.com/rails/rails/commit/30a3b6b4fc56390eec762c879644c95cd09622b0"> here</a>.</p> <p>And, String#encode! is enough for transcoding here because every JSON text is expected to be encoded in Unicode according to <a href="http://www.ietf.org/rfc/rfc4627.txt">the JSON RFC</a>.</p> <p>Attached a patch.</p></div> false 2009-06-29T08:52:01+01:00 17407 --- {} 9903 2849 encode-json-in-utf-8-instead-of-binary 0 8994 new 3.0 activesupport encoding json ruby1.9 2009-06-29T08:52:05+01:00 17407 Akira Matsuda Akira Matsuda http://rails.lighthouseapp.com/projects/8994/tickets/2849 2.x 1 (from [49824e8ad64be17d6b8a0356bc30342aecc72216]) JSON.escape returns UTF-8 strings [#2849 state:resolved] http://github.com/rails/rails/commit/49824e8ad64be17d6b8a0356bc30342aecc72216 <div><p>(from <a href= "/projects/8994/changesets/49824e8ad64be17d6b8a0356bc30342aecc72216" title= "Changeset [49824e8ad64be17d6b8a0356bc30342aecc72216]">[49824e8ad64be17d6b8a0356bc30342aecc72216]</a>) JSON.escape returns UTF-8 strings</p> <p>[<a href="/projects/8994/tickets/2849" title= "Ticket #2849">#2849</a> state:resolved] <a href= "http://github.com/rails/rails/commit/49824e8ad64be17d6b8a0356bc30342aecc72216"> http://github.com/rails/rails/commit/49824e8ad64be17d6b8a0356bc3034...</a></p></div> true 2009-07-02T00:22:52+01:00 17407 --- :state: new 9903 2849 encode-json-in-utf-8-instead-of-binary 0 8994 resolved 3.0 activesupport encoding json ruby1.9 2009-07-02T00:22:54+01:00 17393 Repository Akira Matsuda http://rails.lighthouseapp.com/projects/8994/tickets/2849 2.x 1 (from [5217c16b094a07919348b52aa164ca2fd26b5d5e]) JSON.escape returns UTF-8 strings [#2849 state:resolved] http://github.com/rails/rails/commit/5217c16b094a07919348b52aa164ca2fd26b5d5e <div><p>(from <a href= "/projects/8994/changesets/5217c16b094a07919348b52aa164ca2fd26b5d5e" title= "Changeset [5217c16b094a07919348b52aa164ca2fd26b5d5e]">[5217c16b094a07919348b52aa164ca2fd26b5d5e]</a>) JSON.escape returns UTF-8 strings</p> <p>[<a href="/projects/8994/tickets/2849" title= "Ticket #2849">#2849</a> state:resolved] <a href= "http://github.com/rails/rails/commit/5217c16b094a07919348b52aa164ca2fd26b5d5e"> http://github.com/rails/rails/commit/5217c16b094a07919348b52aa164ca...</a></p></div> true 2009-07-02T00:27:45+01:00 17407 --- {} 9903 2849 encode-json-in-utf-8-instead-of-binary 0 8994 resolved 3.0 activesupport encoding json ruby1.9 2009-07-02T00:27:46+01:00 17393 Repository Akira Matsuda http://rails.lighthouseapp.com/projects/8994/tickets/2849 2.x 7dc3eef9ff109ed10214b58452d9c16f5d4c43ab text/plain 2009-06-29T08:52:01+01:00 json_binary_encoding_fix.diff 138543 1208 17407 http://rails.lighthouseapp.com/attachments/138543/json_binary_encoding_fix.diff