1 true 2009-06-29T09:38:29+01:00 17407 9903 2850 simplify-regex-for-filtering-non-ascii-chars-in-json-escape 1943 8994 invalid 2.3.x 3.0 active_support encoding escape json regexp 2009-07-02T00:25:14+01:00 12714 Yehuda Katz (wycats) Akira Matsuda http://rails.lighthouseapp.com/projects/8994/tickets/2850 2.x A regex in JSON escape seems to be too much complex. I even can't see whether it works as expected. Attached a patch to simply filter out the non-ASCII chars. Please ignore this patch if I misunderstood the spec, but it seems that the tests passes anyway. A regex in JSON escape seems to be too much complex. I even can't see whether it works as expected. Attached a patch to simply filter out the non-ASCII chars. Please ignore this patch if I misunderstood the spec, but it seems that the tests passes anyway. <div><p>A regex in JSON escape seems to be too much complex. I even can't see whether it works as expected.</p> <p>Attached a patch to simply filter out the non-ASCII chars.</p> <p>Please ignore this patch if I misunderstood the spec, but it seems that the tests passes anyway.</p></div> 0 A regex in JSON escape seems to be too much complex. I even can't see whether it works as expected. Attached a patch to simply filter out the non-ASCII chars. Please ignore this patch if I misunderstood the spec, but it seems that the tests passes anyway. <div><p>A regex in JSON escape seems to be too much complex. I even can't see whether it works as expected.</p> <p>Attached a patch to simply filter out the non-ASCII chars.</p> <p>Please ignore this patch if I misunderstood the spec, but it seems that the tests passes anyway.</p></div> false 2009-06-29T09:38:29+01:00 17407 --- {} 9903 2850 simplify-regex-for-filtering-non-ascii-chars-in-json-escape 0 8994 new 2.3.x 3.0 active_support encoding escape json regexp 2009-06-29T09:38:32+01:00 17407 Akira Matsuda Akira Matsuda http://rails.lighthouseapp.com/projects/8994/tickets/2850 2.x 1 It looks like the original regex was there for a reason. Do you have any reason to believe it's just arbitrary? <div><p>It looks like the original regex was there for a reason. Do you have any reason to believe it's just arbitrary?</p></div> true 2009-07-02T00:25:11+01:00 17407 --- :state: new 9903 2850 simplify-regex-for-filtering-non-ascii-chars-in-json-escape 0 8994 invalid 2.3.x 3.0 active_support encoding escape json regexp 2009-07-02T00:25:14+01:00 12714 Yehuda Katz (wycats) Akira Matsuda http://rails.lighthouseapp.com/projects/8994/tickets/2850 2.x caba84b9208fc008af4868eefc63dccf586e7752 text/plain 2009-06-29T09:38:29+01:00 json_escape_regex_fix.diff 138547 1152 17407 http://rails.lighthouseapp.com/attachments/138547/json_escape_regex_fix.diff