Associations' dynamic finders fail with :order depends on :include
Reported by Brandon Keepers | May 31st, 2008 @ 11:43 PM | in 2.1.1
This ticket was originally submitted on trac
Dynamic finders generate invalid queries when they are called on an association like: has_many :posts, :include => :comments, :order_by => 'comments.position' because :include is getting ignored. (using non-dynamic #find() works correctly)
I've attached test cases that cause this error and a patch to fix it. Tested against Trunk.
Comments and changes to this ticket
-
-
rick June 9th, 2008 @ 04:17 PM
- → Milestone changed from “” to “2.1.1”
- → State changed from “new” to “open”
- → Assigned user changed from “” to “rick”
Can you create a git patch? See the docs on contributing.
-
Brandon Keepers June 9th, 2008 @ 04:33 PM
Updated patch for latest changes in edge rails and exported using git-format-patch
-
Brandon Keepers June 9th, 2008 @ 04:41 PM
Doh, just realized I committed the change to the mysql connection info. Path updated
-
rick June 9th, 2008 @ 05:11 PM
- → State changed from “open” to “committed”
Hey, I've got this pushed to my own fork. I started pushing some config.gem tweaks there so others could play with them, before they were finalized in rails core. If I was smart, I would've put them in a branch so that I don't have other patches like this one stuck in limbo. We'll merge it back in for 2.1.1 though.
Thanks.
-
-
Brandon Keepers June 17th, 2008 @ 07:42 PM
Any way we can get this pushed or cherry-picked into the main repo?
-
-
-
rick June 19th, 2008 @ 06:02 PM
- → State changed from “committed” to “resolved”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
