12714 2 true 2009-07-06T01:34:41+01:00 20836 9903 2870 ruby-19-style-string-interpolation-support-for-lower-ruby-versions 1960 8994 committed 2-3-stable 3.0 patch 2009-07-18T21:11:52+01:00 17393 Repository Lawrence Pit Yehuda Katz (wycats) http://rails.lighthouseapp.com/projects/8994/tickets/2870 2.x Attached patch adds ruby 1.9 style String interpolation support for lower ruby versions. Thanks to code from Masao Mutoh's GetText gem. The reason for including this patch is that for I18n we'd like to switch from "{{arg}}" style named arguments to standard ruby 1.9 syntax, i.e. : "%{arg}". This makes later upgrades to ruby 1.9 easier and it makes string interpolation a lot more powerful/flexible than what is currently possible. Attached patch adds ruby 1.9 style String interpolation support for lower ruby versions. Thanks to code from Masao Mutoh's GetText gem. The reason for including this patch is that for I18n we'd like to switch from "{{arg}}" style named arguments to standard ruby 1.9 syntax, i.e. : "%{arg}". This makes later upgrades to ruby 1.9 easier and it makes string interpolation a lot more powerful/flexible than what is currently possible. <div><p>Attached patch adds ruby 1.9 style String interpolation support for lower ruby versions. Thanks to code from Masao Mutoh's GetText gem.</p> <p>The reason for including this patch is that for I18n we'd like to switch from "{{arg}}" style named arguments to standard ruby 1.9 syntax, i.e. : "%{arg}". This makes later upgrades to ruby 1.9 easier and it makes string interpolation a lot more powerful/flexible than what is currently possible.</p></div> 0 Attached patch adds ruby 1.9 style String interpolation support for lower ruby versions. Thanks to code from Masao Mutoh's GetText gem. The reason for including this patch is that for I18n we'd like to switch from "{{arg}}" style named arguments to standard ruby 1.9 syntax, i.e. : "%{arg}". This makes later upgrades to ruby 1.9 easier and it makes string interpolation a lot more powerful/flexible than what is currently possible. <div><p>Attached patch adds ruby 1.9 style String interpolation support for lower ruby versions. Thanks to code from Masao Mutoh's GetText gem.</p> <p>The reason for including this patch is that for I18n we'd like to switch from "{{arg}}" style named arguments to standard ruby 1.9 syntax, i.e. : "%{arg}". This makes later upgrades to ruby 1.9 easier and it makes string interpolation a lot more powerful/flexible than what is currently possible.</p></div> false 2009-07-06T01:34:41+01:00 20836 --- {} 9903 2870 ruby-19-style-string-interpolation-support-for-lower-ruby-versions 0 8994 new 3.0 patch 2009-07-06T01:34:46+01:00 20836 Lawrence Pit Lawrence Pit http://rails.lighthouseapp.com/projects/8994/tickets/2870 2.x 85 1 +1 this would make our upgrade path to ruby 1.9 much smoother AND add a ton of flexibility to our interpolation api Jeremy, wdyt? :) <div><p>+1 this would make our upgrade path to ruby 1.9 much smoother AND add a ton of flexibility to our interpolation api</p> <p>Jeremy, wdyt? :)</p></div> false 2009-07-06T11:38:38+01:00 20836 --- :assigned_user: 9903 2870 ruby-19-style-string-interpolation-support-for-lower-ruby-versions 0 8994 new 3.0 patch 2009-07-06T11:38:42+01:00 7400 Sven Fuchs Lawrence Pit Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2870 2.x 85 1 (from [da635394c1c3004f4dacf4a35275404e5b1aef43]) Ruby 1.9 style String interpolation support for lower ruby versions. Thanks to code from Masao Mutoh's GetText gem. [#2870 state:resolved] Signed-off-by: Yehuda Katz <wycats@yehuda-katzs-macbookpro41.local> http://github.com/rails/rails/commit/da635394c1c3004f4dacf4a35275404e5b1aef43 <div><p>(from <a href= "/projects/8994/changesets/da635394c1c3004f4dacf4a35275404e5b1aef43" title= "Changeset [da635394c1c3004f4dacf4a35275404e5b1aef43]">[da635394c1c3004f4dacf4a35275404e5b1aef43]</a>) Ruby 1.9 style String interpolation support for lower ruby versions. Thanks to code from Masao Mutoh's GetText gem. [<a href= "/projects/8994/tickets/2870" title="Ticket #2870">#2870</a> state:resolved]</p> <p>Signed-off-by: Yehuda Katz <a>wycats@yehuda-katzs-macbookpro41.local</a><br> <a href= "http://github.com/rails/rails/commit/da635394c1c3004f4dacf4a35275404e5b1aef43"> http://github.com/rails/rails/commit/da635394c1c3004f4dacf4a3527540...</a></p></div> true 2009-07-08T00:22:25+01:00 20836 --- :state: new 9903 2870 ruby-19-style-string-interpolation-support-for-lower-ruby-versions 0 8994 resolved 3.0 patch 2009-07-08T00:22:26+01:00 17393 Repository Lawrence Pit Jeremy Kemper http://rails.lighthouseapp.com/projects/8994/tickets/2870 2.x 12714 1 Thanks for applying, Yehuda :) Couple of things: I noticed the tests don't pass on Ruby 1.9 because Masao's code does not mirror Ruby 1.9's behaviour exactly, but the tests of course specify what the code does. This is true for two situations where Ruby 1.9 raises exceptions while Masao's extension doesn't: * Ruby 1.9 raises a KeyError exception for missing named interpolation args (e.g. "%{foo}" % {:bar => :bar}) * Ruby 1.9 raises an ArgumentError when mixing named and unnamed placeholders (e.g. "%{foo} %f" % [1.0]) Also, we'll only want to include this code when we're on < Ruby 1.9. I'll append a patch that fixes these things and also improves the docs and Rails conventions compliance a little bit. After applying this, can you please also BACKPORT this to 2.3-stable? That'd be great :) I'll reopen the ticket and assign to Yehuda. <div><p>Thanks for applying, Yehuda :)</p> <p>Couple of things:</p> <p>I noticed the tests don't pass on Ruby 1.9 because Masao's code does not mirror Ruby 1.9's behaviour exactly, but the tests of course specify what the code does. This is true for two situations where Ruby 1.9 raises exceptions while Masao's extension doesn't:</p> <ul> <li>Ruby 1.9 raises a KeyError exception for missing named interpolation args (e.g. "%{foo}" % {:bar =&gt; :bar})</li> <li>Ruby 1.9 raises an ArgumentError when mixing named and unnamed placeholders (e.g. "%{foo} %f" % [1.0])</li> </ul> <p>Also, we'll only want to include this code when we're on &lt; Ruby 1.9.</p> <p>I'll append a patch that fixes these things and also improves the docs and Rails conventions compliance a little bit.</p> <p>After applying this, can you please also BACKPORT this to 2.3-stable? That'd be great :)</p> <p>I'll reopen the ticket and assign to Yehuda.</p></div> false 2009-07-08T17:26:08+01:00 20836 --- :tag: 3.0 patch :state: resolved :assigned_user: 85 9903 2870 ruby-19-style-string-interpolation-support-for-lower-ruby-versions 0 8994 open 2-3-stable 3.0 patch 2009-07-08T17:26:14+01:00 7400 Sven Fuchs Lawrence Pit Yehuda Katz (wycats) http://rails.lighthouseapp.com/projects/8994/tickets/2870 2.x 12714 2 (from [17d5cc12b9f8d0d78a081d231e7e0c5ec9df1104]) * don't include String#% for Ruby 1.9 * raise a KeyError exception for missing named interpolation args (like Ruby 1.9 does) * raise an ArgumentError when mixing named and unnamed placeholders (like Ruby 1.9 does) * improve docs and comply a bit more w/ Rails names/conventions [#2870 state:committed] Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net> http://github.com/rails/rails/commit/17d5cc12b9f8d0d78a081d231e7e0c5ec9df1104 <div><p>(from <a href= "/projects/8994/changesets/17d5cc12b9f8d0d78a081d231e7e0c5ec9df1104" title= "Changeset [17d5cc12b9f8d0d78a081d231e7e0c5ec9df1104]">[17d5cc12b9f8d0d78a081d231e7e0c5ec9df1104]</a>) * don't include String#% for Ruby 1.9 * raise a KeyError exception for missing named interpolation args (like Ruby 1.9 does) * raise an ArgumentError when mixing named and unnamed placeholders (like Ruby 1.9 does) * improve docs and comply a bit more w/ Rails names/conventions</p> <p>[<a href="/projects/8994/tickets/2870" title= "Ticket #2870">#2870</a> state:committed]</p> <p>Signed-off-by: Jeremy Kemper <a>jeremy@bitsweat.net</a><br> <a href= "http://github.com/rails/rails/commit/17d5cc12b9f8d0d78a081d231e7e0c5ec9df1104"> http://github.com/rails/rails/commit/17d5cc12b9f8d0d78a081d231e7e0c...</a></p></div> true 2009-07-18T21:11:50+01:00 20836 --- :state: open 9903 2870 ruby-19-style-string-interpolation-support-for-lower-ruby-versions 0 8994 committed 2-3-stable 3.0 patch 2009-07-18T21:11:52+01:00 17393 Repository Lawrence Pit Yehuda Katz (wycats) http://rails.lighthouseapp.com/projects/8994/tickets/2870 2.x f98bb348f9f396f1ebf10742542601a59f22bd4b text/plain 2009-07-06T01:35:37+01:00 string_interpolation.diff 214521 6786 20836 http://rails.lighthouseapp.com/attachments/214521/string_interpolation.diff 3524e55cbe77381962db8e75d98d5aca1bee1d48 text/plain 2009-07-08T17:26:08+01:00 0001-1.-don-t-include-String-for-Ruby-1.9.patch 216587 8349 7400 http://rails.lighthouseapp.com/attachments/216587/0001-1.-don-t-include-String-for-Ruby-1.9.patch