AssetTagHelper should accept a slightly wider range of protocols
Reported by Alex Wayne | April 15th, 2008 @ 04:30 AM
Forgive me if this is the wrong place. I guessed this URL based on recent news and I see little is here yet. Pardon my butting into this transition...
Before, using
image_tag "data:image/jpeg,base64:ABC123"
Would create an image tag like:
<img src="/images/data:image/jpeg,base64:ABC123" alt="data:image/jpeg,base64:ABC123" />
First, the /images prepended to the data: protocol uri completely breaks it. Second the alt attribute is completely useless, and would be better left out.
This patch allows image_tag to work with inline images via the data: protocol. While obviously not a best practice, it has its uses and image_tag shouldn't fail to work with idiom.
<img src="data:image/jpeg,base64:ABC123" />
It includes 1 additional image_tag assertion that proves its all working as expected.
Comments and changes to this ticket
-
Joshua Peek April 20th, 2008 @ 03:12 AM
- → State changed from “new” to “open”
- → Title changed from “[PATCH] AssetTagHelper should accept a slightly wider range of protocols” to “AssetTagHelper should accept a slightly wider range of protocols”
- → Assigned user changed from “” to “Joshua Peek”
I'm not sure this is a good use of the image_tag method. image_tag tag is there to help you expand image paths and provide you with a "useful" alt tag.
If you really just want "img src="data:image/jpeg,base64:ABC123"", isn't hard coding the img tag the simplest thing?
-
Cheah Chu Yeow April 20th, 2008 @ 02:33 AM
Yup I agree that in this case there is no value using image_tag for inline images and in fact it just makes your page slower calling the image_tag helper when you're not really using any of its functionality.
-1 (sorry!)
-
Joshua Peek April 20th, 2008 @ 03:13 AM
- → State changed from “open” to “invalid”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
