SystemStackError with has_one
Reported by Matt Mower | June 2nd, 2008 @ 03:06 PM
Upgrading a project of mine from Rails 2.0.3 to Rails 2.1 I discovered a number of specs started throwing errors like:
Exception raised:
Class:
Message: <"stack level too deep">
---Backtrace---
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:272:in `run_callbacks'
./test/cases/../../lib/active_record/validations.rb:929:in `valid_without_callbacks?'
./test/cases/../../lib/active_record/callbacks.rb:267:in `valid?'
./test/cases/../../lib/active_record/associations/association_proxy.rb:177:in `send'
./test/cases/../../lib/active_record/associations/association_proxy.rb:177:in `method_missing'
./test/cases/../../lib/active_record/associations.rb:1165:in `validate_associated_records_for_inverse'
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:173:in `send'
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:173:in `evaluate_method'
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:161:in `call'
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:90:in `run'
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:90:in `each'
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:90:in `send'
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:90:in `run'
./test/cases/../../lib/../../activesupport/lib/active_support/callbacks.rb:272:in `run_callbacks'
./test/cases/../../lib/active_record/validations.rb:929:in `valid_without_callbacks?'
./test/cases/../../lib/active_record/callbacks.rb:267:in `valid?'
./test/cases/../../lib/active_record/associations/association_proxy.rb:177:in `send'
this relates to an after_create callback on one of the models which has a self-referential association:
class Relationship
has_one :inverse, :class_name => 'Relationship', :foreign_key => 'inverse_id', :dependent => :nullify
def after_create
if !self.inverse
self.inverse = Relationship.find_for( contact_id, user_id )
if self.inverse
self.save!
self.inverse.inverse = self
self.inverse.save!
end
end
end
end
I have reduced the problem to a minimal test case which I have added to the appropriate test case in the ActiveRecord test suite. I enclose a patch that adds the model, fixture, and test.
To recap this behaviour functioned properly in Rails 2.0.3 but is broken in 2.1rc and 2.1final.
end
Comments and changes to this ticket
-

Jan De Poorter June 3rd, 2008 @ 05:27 AM
I added (in collaboration with lifo on IRC) a patch which adds :validate to has_many, has_one, habtm associations, to disable the automatic validation, which is why this problem occurs.
-
Matt Mower June 3rd, 2008 @ 05:31 AM
Thanks Jan.
I would like to mention that Jan also came up with a useful workaround which is to redefine the method that the has_one is generating stubbing it out. In my case this is "validate_associated_records_for_inverse".
Until :validate => false is in place the workaround may help.
-
Pratik June 9th, 2008 @ 05:39 AM
- → Assigned user changed from to Pratik
-
-

Drew Blas June 9th, 2008 @ 04:34 PM
+1
...Although I echo the sentiment of others that this should NOT be enabled by default. There is no proper documentation of it and the expected behavior is to use validates_associated...that's what validations are for.
-
Pratik June 10th, 2008 @ 11:49 AM
A few changes needed :
- It should be possible to use one of the existing table/model.
- Could you please add :validate option to belongs_to as well ?
Catch me on IRC if you have any questions.
Thanks!
-

-

Repository June 11th, 2008 @ 06:28 AM
- → State changed from new to resolved
(from [7f140bbddaf70abc61570f6cfdcbfba5771ffc78]) Add :validate option to associations. [#301 state:resolved]
Signed-off-by: Pratik Naik
-

Repository June 11th, 2008 @ 11:14 AM
(from [23223ce415da13a09287325d114ce2d2e3923edf]) Add :validate option to associations. [#301 state:resolved]
Signed-off-by: Pratik Naik
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
