Size reports incorrectly for collections when more than one item is added with build
Reported by sds | June 2nd, 2008 @ 04:48 PM
Adding more than one item to a collection using collection.build and then subsequently checking the size of the collection with the size method fails to work correctly.
This code from active_record/associations/association_collection.rb:
unsaved_records = Array(@target.detect { |r| r.new_record? })
unsaved_records.size + count_records
should read:
unsaved_records = Array(@target.select { |r| r.new_record? })
unsaved_records.size + count_records
I attach a git diff for patching the code and adding a test for this.
Comments and changes to this ticket
-
sds June 2nd, 2008 @ 05:23 PM
Actually the creation of a new array in the patched version is not needed (select already returns an array), I attach new patch containing this code:
unsaved_records = @target.select { |r| r.new_record? }
unsaved_records.size + count_records
-
Repository July 1st, 2008 @ 09:21 PM
- → Tag changed from “” to “activerecord bug patch”
(from [474d42538269a141687c7c66bef6575b4682b15d]) Ensure AssociationCollection#size considers all unsaved record. [#305 state:resolved] [sds]
Signed-off-by: Pratik Naik
-
Pratik July 1st, 2008 @ 10:21 PM
- → State changed from “new” to “resolved”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
