1 true 2008-06-04T22:03:01+01:00 17057 334 don-t-add-default-null-to-column-definitions 15280 8994 committed activerecord migrations tested 2008-07-15T23:56:07+01:00 17393 Repository Nick Sieger http://rails.lighthouseapp.com/projects/8994/tickets/334 Commit 10ef65a3b054270ed3d458ec8eb7c2b9a3e638f7 introduced a strange side-effect to create table definitions. It causes DEFAULT NULL to be included all the time. Some databases are ok with this, but some are not. Example: `title` varchar(255) DEFAULT NULL NULL Patch attached to omit passing :default option to #add_column_options! if it is nil. Commit 10ef65a3b054270ed3d458ec8eb7c2b9a3e638f7 introduced a strange side-effect to create table definitions. It causes DEFAULT NULL to be included all the time. Some databases are ok with this, but some are not. Example: `title` varchar(255) DEFAULT NULL NULL Patch attached to omit passing :default option to #add_column_options! if it is nil. <div><p> Commit 10ef65a3b054270ed3d458ec8eb7c2b9a3e638f7 introduced a strange side-effect to create table definitions. It causes DEFAULT NULL to be included all the time. Some databases are ok with this, but some are not. Example: </p><p> `title` varchar(255) DEFAULT NULL NULL </p><p> Patch attached to omit passing :default option to #add_column_options! if it is nil. </p></div> 0 Commit 10ef65a3b054270ed3d458ec8eb7c2b9a3e638f7 introduced a strange side-effect to create table definitions. It causes DEFAULT NULL to be included all the time. Some databases are ok with this, but some are not. Example: `title` varchar(255) DEFAULT NULL NULL Patch attached to omit passing :default option to #add_column_options! if it is nil. <div><p> Commit 10ef65a3b054270ed3d458ec8eb7c2b9a3e638f7 introduced a strange side-effect to create table definitions. It causes DEFAULT NULL to be included all the time. Some databases are ok with this, but some are not. Example: </p><p> `title` varchar(255) DEFAULT NULL NULL </p><p> Patch attached to omit passing :default option to #add_column_options! if it is nil. </p></div> false 2008-06-05T02:27:45+01:00 17057 --- {} 334 don-t-add-default-null-to-column-definitions 0 8994 new 2008-06-05T02:27:45+01:00 17057 Nick Sieger Nick Sieger http://rails.lighthouseapp.com/projects/8994/tickets/334 1 (from [30370227890dc950f1544b7b1040aa75e505f877]) Fixed that create database statements would always include "DEFAULT NULL" (Nick Sieger) [#334 status:committed] http://github.com/rails/rails/commit/30370227890dc950f1544b7b1040aa75e505f877 <div><p> (from [30370227890dc950f1544b7b1040aa75e505f877]) Fixed that create database statements would always include "DEFAULT NULL" (Nick Sieger) [#334 status:committed] </p><p> <a href="http://github.com/rails/rails/commit/30370227890dc950f1544b7b1040aa75e505f877">http://github.com/rails/rails/co...</a> </p></div> false 2008-07-14T16:14:42+01:00 17057 --- :tag: 334 don-t-add-default-null-to-column-definitions 0 8994 new activerecord migrations tested 2008-07-14T16:14:42+01:00 17393 Repository Nick Sieger http://rails.lighthouseapp.com/projects/8994/tickets/334 1 true 2008-07-14T16:36:16+01:00 17057 --- :state: new 334 don-t-add-default-null-to-column-definitions 0 8994 committed activerecord migrations tested 2008-07-14T16:36:16+01:00 83 DHH Nick Sieger http://rails.lighthouseapp.com/projects/8994/tickets/334 1 (from [275c3ab2a7aac60ad30ab027d1f0b1f041fb016d]) Fixed that create database statements would always include "DEFAULT NULL" (Nick Sieger) [#334 status:committed] Conflicts: activerecord/CHANGELOG http://github.com/rails/rails/commit/275c3ab2a7aac60ad30ab027d1f0b1f041fb016d <div><p> (from [275c3ab2a7aac60ad30ab027d1f0b1f041fb016d]) Fixed that create database statements would always include "DEFAULT NULL" (Nick Sieger) [#334 status:committed] </p><p> Conflicts: </p><p> activerecord/CHANGELOG </p><p> <a href="http://github.com/rails/rails/commit/275c3ab2a7aac60ad30ab027d1f0b1f041fb016d">http://github.com/rails/rails/co...</a> </p></div> true 2008-07-15T23:56:07+01:00 17057 --- {} 334 don-t-add-default-null-to-column-definitions 0 8994 committed activerecord migrations tested 2008-07-15T23:56:07+01:00 17393 Repository Nick Sieger http://rails.lighthouseapp.com/projects/8994/tickets/334 a1c42433edfd99c90c34a986c3ee1739fa7cb324 text/plain 2008-06-04T22:03:01+01:00 0001-Avoid-creating-column-definition-SQL-like-title-va.patch 25947 3404 17057 http://rails.lighthouseapp.com/attachments/25947/0001-Avoid-creating-column-definition-SQL-like-title-va.patch