#339 √ resolved
Luke Redpath

Calling url_for with no arguments fails if default_url_options is not set

Reported by Luke Redpath | June 5th, 2008 @ 01:31 PM

Whilst upgrading an app from 1.2 to 2.1, one of my controller tests was failing with: 

The error occurred while evaluating nil.[]
method rewrite_url in url_rewriter.rb at line 102
method rewrite in url_rewriter.rb at line 88
method url_for in base.rb at line 621

The reason for this failure is the way the case statement in url_for works: 

### ActionController::Base
def url_for(options = nil) #:doc:
  case options || {}
    when String
      options
    when Hash
      @url.rewrite(rewrite_options(options))
    else
      polymorphic_url(options)
  end
end

If options is nil, it will run the case statement against the empty hash and call the "when Hash" branch, but options will still be nil so the rewrite call fails because it expects a hash.

The fix was quite simple (change the default options argument to {} instead of nil) and I've attached the fix as a patch with a test case.

Comments and changes to this ticket

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Source available from github

Repository is at http://github.com/rails/rails

Check out the development master (Edge Rails):

git clone git://github.com/rails/rails.git

Creating or reviewing a patch

See the contributor guide.

Creating a feature request

Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.

Creating a bug report

When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.

Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.

Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..

Shared Ticket Bins

People watching this ticket

Attachments

Tags