skip_time_zone_conversion_for_attributes does not work
Reported by Ben Johnson | June 5th, 2008 @ 10:12 PM | in 2.2
If I do the following:
class A < ActiveRecord::Base
self.skip_time_zone_conversion_for_attributes = [:field_a]
end
class B < ActiveRecord::Base
self.skip_time_zone_conversion_for_attributes = [:field_b]
end
>> A.skip_time_zone_conversion_for_attributes
=> [:field_b]
Shouldn't it be [:field_a]?
Thanks!
Comments and changes to this ticket
-
Tarmo Tänav August 23rd, 2008 @ 02:14 PM
- → Tag changed from “” to “activerecord bug”
- → State changed from “new” to “invalid”
I can't reproduce this, both on 2.1.0 and on edge. Please provide more info as to the environment or a working testcase.
-
Geoff Buesing August 24th, 2008 @ 05:01 PM
- → State changed from “invalid” to “open”
- → Assigned user changed from “” to “Geoff Buesing”
Actually, this is indeed a bug -- we're using cattr_accessor to define skip_time_zone_conversion_for_attributes, which means that every class that subclasses ActiveRecord::Base is writing to the same class variable.
We should probably be using class_inheritable_array here.
In the meantime, this works:
class A < ActiveRecord::Base def self.skip_time_zone_conversion_for_attributes [:field_a] end end class B < ActiveRecord::Base def self.skip_time_zone_conversion_for_attributes [:field_b] end end >> A.skip_time_zone_conversion_for_attributes => [:field_a] -
Geoff Buesing September 12th, 2008 @ 12:23 AM
- → Milestone changed from “” to “2.2”
-
miloops September 12th, 2008 @ 03:29 PM
- → Tag changed from “activerecord bug” to “activerecord bug patch”
Here is the patch fixing the problem, i also added test to reproduce Ben's issue.
Oh, and it should use class_inheritable_accessor instead of class_inheritable_array or cattr_accessor.
-
Repository September 14th, 2008 @ 11:24 PM
- → State changed from “open” to “resolved”
(from [9c4730d01e892df8d5c5493a08e0cddf0de5d575]) Base.skip_time_zone_conversion_for_attributes uses class_inheritable_accessor, so that subclasses don't overwrite Base [#346 state:resolved] http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
