Allow Infinity to pass validates_numericality_of
Reported by Chris Cherry | June 6th, 2008 @ 07:38 AM
This patch allows a getter method on a model to return infinity and still pass validates_numericality_of.
This patch has been running in a production app since January 2008.
Why is Infinity useful?
Ruby's Infinity (1.0/0.0) can be very useful when implementing "limits" in a model. For example a package for an account might have a page_limit specifying how many pages a user might be able to create. If you wish to support "unlimited" size packages you might allow page_limit to be stored as a NULL in the database, and have a getter method that returns Infinity when the attribute is nil. This allows you to use the attribute directly in comparisons and other kinds of basic math like "remaining pages" without needing conditional logic.
Comments and changes to this ticket
-
shuber June 6th, 2008 @ 10:29 PM
Seems like it could be pretty useful in some situations.
Applied the patch, works as expected and all tests pass.
+1
-
-
Lytol June 18th, 2008 @ 07:45 AM
+1 Putting mathematical debates aside (since infinity is not a number), I can see the usefulness of this functionality. Tests pass... let's see what others have to say. With mathematical theory aside, a pretty clever solution. =)
-
Chris Cherry June 18th, 2008 @ 10:35 PM
- no changes were found...
-
Repository July 9th, 2008 @ 01:25 PM
- → Tag changed from “” to “patch tiny verified”
- → State changed from “new” to “resolved”
(from [124d1016fa212c008e33853912493fa9ac15d086]) Allow Infinity (1.0/0.0) to pass validates_numericality_of. [#354 state:resolved]
Signed-off-by: Pratik Naik
-
Repository July 15th, 2008 @ 11:56 PM
(from [d12660022525b9b1e25b92cd4639e32c8608f729]) Allow Infinity (1.0/0.0) to pass validates_numericality_of. [#354 state:resolved]
Signed-off-by: Pratik Naik
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
