Ruby on Rails

Comments and changes to this ticket

• 

  Jeremy Kemper June 10th, 2008 @ 04:35 PM

  • → Assigned user changed from “” to “Jeremy Kemper”

  I'd love to support savepoints. We've had the discussion regarding the default behavior of nested transactions, though, and it's not the way to go. Nested transactions should be explicit, otherwise we're going to flood the database with junk transactions that really only mean "include me in a transaction" not "start a new transaction". Let's extend the existing semantics instead of stepping on them. And add better test coverage ;)

• 

  Jeremy Kemper June 10th, 2008 @ 04:35 PM

  • → Milestone changed from “” to “2.2”
• 

  Tarmo Tänav June 16th, 2008 @ 02:02 PM

  Jeremy, the plugin by Jonathan Viney actually does make transaction{} only create a nested transaction if an explicit ":force => true" option is passed to it. The only exception being transactional tests where one additional level of non-explicit transactions can be created (because the test class itself uses the first level).

  So these changes should not change rails behavior outside tests.

  This plugin however does not include the ability to configure rails behavior for implicit transactions (those automatically created by save/destroy). Which means that you will not be able to make some activerecord model always create an implicit transaction for saving itself, even if a higher level transaction already exists. But this is a capability not strictly neccessary for the nested transactions feature to be useful, as you can always create an explicit "transaction :force => true" block around a save if you need it.

• 

  jonathan July 3rd, 2008 @ 07:12 AM

  • → Tag changed from “” to “activerecord nested savepoint transaction”

  I'd like to see #533 included first (moving the transaction counter from Thread.current to the connection object), and then I'll add an updated patch for the savepoints.

• 

  Jeremy Kemper August 29th, 2008 @ 11:10 PM

  • → State changed from “new” to “open”

  #533 is in -- interested in porting your work over to Rails master?

• 

  jonathan August 31st, 2008 @ 05:38 AM

  I've attached a patch for master.

  The handling of increment/decrement_open_transactions has been moved to the connection object rather than handling it in AR::Base.transaction, seemed better to me.

  I've added a transactional_fixtures accessor to the connection which is set by the fixtures. Not the nicest, but I wasn't sure what else to do.

  There are some failures for databases that don't support savepoints (eg. sqlite). These are a bit hard to avoid unless we add a supports_savepoints? to the connection.

  Anyway, this should get the ball rolling.

  • savepoints-3.diff 14.6 KB