Non-standard SQL generated in column definition for nullable columns in create table DDL (rails 2.1)
Reported by Praveen Devarao | June 12th, 2008 @ 07:21 AM
In migrations create table generates non-standard SQL which breaks functioning of sql standard compliant databases. The create table method
create_table :accounts, :force => true do |t|
t.integer :firm_id
t.integer :credit_limit
end
generates the sql as below
CREATE TABLE accounts (id ...., firm_id integer DEFAULT NULL NULL, credit_limit integer DEFAULT NULL NULL)
Focussing on 'DEFAULT NULL NULL', the last NULL is not standard SQL syntax compliant and hence will not work for DB2 and Oracle.
This can be tested here
http://developer.mimer.com/valid...
basically compliant sql syntax is 'COLNAME TYPE DEFAULT CONSTRAINTS'. Constraints is category that this falls into. 'NOT NULL' is a valid constraint, 'NULL' is not.
Comments and changes to this ticket
-
Praveen Devarao October 23rd, 2008 @ 04:25 PM
- → Assigned user cleared.
-
Repository August 23rd, 2008 @ 06:22 PM
- → Tag cleared.
- → State changed from “new” to “resolved”
(from [74c3c701f73407a5bb1a11be2b5b221fe39895d3]) Don't set "NULL" as a constraint on nullable columns [#398 state:resolved]
This is already the default and adding it breaks SQL standards compatibility. http://github.com/rails/rails/co...
-
Repository August 25th, 2008 @ 09:26 AM
(from [ddb8c9c92ed09d33ae573891a4ef0d566622f317]) Don't set "NULL" as a constraint on nullable columns [#398 state:resolved]
This is already the default and adding it breaks SQL standards compatibility.
Conflicts:
activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
Jeremy Kemper