#419 √ resolved
Alex

has_many :conditions and named_scope should alter creates from within it

Reported by Alex | June 15th, 2008 @ 02:47 AM | in 2.2

This has been a problem in rails for a very long time and I am shocked that it has not been fixed yet. What I say here about has_many essentially applies just the same to named_scope.

Assume I have a class Post. Post has a boolean field 'published', indicating whether the post has been published or not. I also have another class, Blog. If I want the blog to have many posts, which is just any posts in general, and to also have only posts which have been published: 

class Blog < ActiveRecord::Base
    has_many :posts
    has_many :published_posts, :conditions => {:published => true}, :class_name => 'Post'
end

Blog.published_posts.find(:all) works just as expected. But what if I want to do the following in order to have the blog post it immediately: 

Blog.published_posts.create(:title => 'The Blog Post')

This doesn't automatically alter the condition of to true. This seems odd, and inconsistent since the only way to access this record is from Blog.posts, rather than Blog.published_posts, where I created it from.

The obvious problem that arises is that if the conditions are not exactly specific about which alterations need to be done such as 'date < 2008' the create cannot work with this. I suggest that to patch this, if a hash is being used for conditions it can be used on either a create or a find since the values are specific. Otherwise :conditions only applies to the find and an alternate :create_conditions can be used for creates.

Comments and changes to this ticket

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Source available from github

Repository is at http://github.com/rails/rails

Check out the development master (Edge Rails):

git clone git://github.com/rails/rails.git

Creating or reviewing a patch

See the contributor guide.

Creating a feature request

Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.

Creating a bug report

When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.

Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.

Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..

Shared Ticket Bins

People watching this ticket

Attachments

Tags