Date.at_end_of_week is unpredictable
Reported by Alex | June 15th, 2008 @ 12:29 AM
Date.at_end_of_week does not work as demonstrated by the following examples:
The end of the week is supposed to be Saturday, the 21st.
now = Date.current.at_beginning_of_day
# => Sun Jun 15 00:00:00 -0500 2008
now.at_end_of_week
# => Sun Jun 15 23:59:59 -0500 2008
Adding on to the previous code, the end of the week should also be Saturday, the 21st.
tom = now.tomorrow
# => Mon Jun 16 00:00:00 -0500 2008
tom.at_end_of_week
# => Sun Jun 22 23:59:59 -0500 2008
Comments and changes to this ticket
-
Oscar Del Ben June 15th, 2008 @ 03:34 AM
This depends on where you live. I think it should be added as an option to put in config/environment.rb. I'll try to make a patch for this.
-
Oscar Del Ben June 15th, 2008 @ 04:05 AM
I've seen that this convention is used in a lot of methods, so it's not easy to change.
-
nikz August 7th, 2008 @ 04:46 AM
- → Tag changed from “” to “activesupport bug core_ext date”
Hey there,
This should be easy enough to override if you'd like the week to end on Saturday.
In Ruby core, Sunday is "wday" 0, and Saturday is wday "6".
I'm going to recommend this be closed up, unless you'd really like an option. :)
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
The latest development for the 1.2.x and 2.0.x releases are on the 1-2-stable and 2-0-stable branches.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
