Bind Lambdas in :conditions
Reported by Ben Sandofsky | June 16th, 2008 @ 10:44 AM
Let's say you want to find records based on the current time.
def find_within_last_week(*args)
with_scope(:find => {:conditions => ['assignments.created_at > ?', 7.days.ago.to_s(:db)} do
find(*args)
end
end
Except, that time statement will be evaluated when the class is first loaded, which quickly makes it useless. The less-than-documented solution used to be
['assignments.created_at > ?', '#{7.days.ago.to_s(:db)']
But that's just silly when ruby has lambdas. With this patch, you can write:
def find_within_last_week(*args)
with_scope(:find => {:conditions => ['assignments.created_at > ?', lambda {7.days.ago.to_s(:db)}} do
find(*args)
end
end
Comments and changes to this ticket
-
Alex MacCaw June 16th, 2008 @ 11:42 AM
At the moment you can do:
named_scope :last_week, lambda { ({:conditions => ['assignments.created_at > ?', 7.days.ago.to_s(:db)]}) }
I agree, the normal find should have the same functionality
+1
-
Yaroslav Markin June 16th, 2008 @ 01:45 PM
I am SO +1 on this. As Alex mentioned, named_scope already has this.
Probably it will be possible to merge this stuff on the way to 3.0
-
-
Pratik July 2nd, 2008 @ 02:40 AM
- → Tag changed from “” to “activerecord patch verified”
- → State changed from “new” to “incomplete”
- → Assigned user changed from “” to “Pratik”
Can you please add a test case which will fail for non-lambda version. I tried changing test included in the patch to use "with_scope(:find => {:conditions => ['companies.id = ?', @@count = @@count + 1]})" and the tests passed.
Thanks.
-
Pratik August 3rd, 2008 @ 02:59 PM
- → State changed from “incomplete” to “wontfix”
Closing till further progress.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
