424 4 true 2008-06-17T22:19:24+01:00 23667 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 18675 8994 wontfix actionpack assertions 2008-07-27T22:08:40+01:00 424 Joshua Peek Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 This patch changes ActionView::TestCase to the more appropriate name of ActionView::Helpers::TestCase, it also refactors some code in that file that was unclear. This path also adds 2 assertions "assert_tag_in" and "assert_tag_not_in" to aid in testing helpers. Finally it adds these to the "test_help.rb" file in railities allowing these to be used elsewhere. See: http://github.com/brianjlandau/rails/commits/refactor_action_view_testcase This patch changes ActionView::TestCase to the more appropriate name of ActionView::Helpers::TestCase, it also refactors some code in that file that was unclear. This path also adds 2 assertions "assert_tag_in" and "assert_tag_not_in" to aid in testing helpers. Finally it adds these to the "test_help.rb" file in railities allowing these to be used elsewhere. See: http://github.com/brianjlandau/rails/commits/refactor_action_view_testcase <div><p> This patch changes ActionView::TestCase to the more appropriate name of ActionView::Helpers::TestCase, it also refactors some code in that file that was unclear. </p><p> This path also adds 2 assertions "assert_tag_in" and "assert_tag_not_in" to aid in testing helpers. Finally it adds these to the "test_help.rb" file in railities allowing these to be used elsewhere. </p><p> See: <a href="http://github.com/brianjlandau/rails/commits/refactor_action_view_testcase">http://github.com/brianjlandau/r...</a> </p></div> 0 This patch changes ActionView::TestCase to the more appropriate name of ActionView::Helpers::TestCase, it also refactors some code in that file that was unclear. This path also adds 2 assertions "assert_tag_in" and "assert_tag_not_in" to aid in testing helpers. Finally it adds these to the "test_help.rb" file in railities allowing these to be used elsewhere. See: http://github.com/brianjlandau/rails/commits/refactor_action_view_testcase <div><p> This patch changes ActionView::TestCase to the more appropriate name of ActionView::Helpers::TestCase, it also refactors some code in that file that was unclear. </p><p> This path also adds 2 assertions "assert_tag_in" and "assert_tag_not_in" to aid in testing helpers. Finally it adds these to the "test_help.rb" file in railities allowing these to be used elsewhere. </p><p> See: <a href="http://github.com/brianjlandau/rails/commits/refactor_action_view_testcase">http://github.com/brianjlandau/r...</a> </p></div> false 2008-06-17T22:19:24+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new 2008-06-17T22:19:24+01:00 23667 Brian Landau Brian Landau http://rails.lighthouseapp.com/projects/8994/tickets/442 1 Is assert_tag_in more useful for helpers than assert_select? <div><p> Is assert_tag_in more useful for helpers than assert_select? </p></div> false 2008-06-18T04:13:31+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new 2008-06-18T04:13:31+01:00 14890 Tarmo Tänav Brian Landau http://rails.lighthouseapp.com/projects/8994/tickets/442 1 Yes I feel so. assert_select I feel is more powerful when dealing with a whole page's DOM but when it's a smaller set of tags I feel that assert_tag has a more descriptive and readable syntax. But we could easily add an assert_select_in to the ActionView::Assertions. <div><p> Yes I feel so. assert_select I feel is more powerful when dealing with a whole page's DOM but when it's a smaller set of tags I feel that assert_tag has a more descriptive and readable syntax. </p><p> But we could easily add an assert_select_in to the ActionView::Assertions. </p></div> false 2008-06-18T14:28:45+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new 2008-06-18T14:28:45+01:00 23667 Brian Landau Brian Landau http://rails.lighthouseapp.com/projects/8994/tickets/442 1 Some how I forgot to put my tests in that patch. Here they are. <div><p> Some how I forgot to put my tests in that patch. Here they are. </p></div> false 2008-06-20T21:01:44+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new 2008-06-20T21:01:44+01:00 23667 Brian Landau Brian Landau http://rails.lighthouseapp.com/projects/8994/tickets/442 424 2 false 2008-07-09T13:29:02+01:00 23667 --- :tag: :assigned_user: 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new actionpack assertions enhancement helper patch tested tests 2008-07-09T13:29:02+01:00 1366 Pratik Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 424 2 I agree with Tarmo, should use assert_select. <div><p> I agree with Tarmo, should use assert_select. </p></div> false 2008-07-11T18:02:21+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new actionpack assertions enhancement helper patch tested tests 2008-07-11T18:02:21+01:00 424 Joshua Peek Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 424 3 Here is another patch that creates an "assert_select_in" test assertion method. <div><p> Here is another patch that creates an "assert_select_in" test assertion method. </p></div> false 2008-07-11T22:48:45+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new actionpack assertions enhancement helper patch tested tests 2008-07-11T22:48:45+01:00 23667 Brian Landau Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 424 4 This is a combination of all the previous patches. Also all of these changes are available in the "github branch I created":http://github.com/brianjlandau/rails/commits/refactor_action_view_testcase <div><p> This is a combination of all the previous patches. </p><p> Also all of these changes are available in the <a href="http://github.com/brianjlandau/rails/commits/refactor_action_view_testcase">github branch I created</a> </p></div> false 2008-07-11T22:50:57+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new actionpack assertions enhancement helper patch tested tests 2008-07-11T22:50:57+01:00 23667 Brian Landau Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 424 4 It looks like you totally reimplemented assert_select for assert_select_in. Is there anyway you can piggy back off the original. Not very DRY. Also I'm not sure if I'm down with changing the namespace either. <div><p> It looks like you totally reimplemented assert_select for assert_select_in. Is there anyway you can piggy back off the original. Not very DRY. </p><p> Also I'm not sure if I'm down with changing the namespace either. </p></div> false 2008-07-17T00:21:29+01:00 23667 --- :title: Change ActionView::TestCase to ActionView::Helpers::TestCase and add assertions 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new actionpack assertions enhancement helper patch tested tests 2008-07-17T00:21:29+01:00 424 Joshua Peek Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 424 4 Joshua: 1. It sounds great to DRY it up but what should the namespace be for the common components? Also it's not an exact duplicate of assert_select obviously as we aren't selecting from the response and it requires a target HTML parameter. So any thoughts on where to extract out common code would be appreciated. 2. The reason for the namespace change is that this TestCase is almost entirely for testing the output of helpers. This is supported by the fact that it automatically includes the methods for the helper named as same as the test name. <div><p> Joshua: </p><p> 1. It sounds great to DRY it up but what should the namespace be for the common components? Also it's not an exact duplicate of assert_select obviously as we aren't selecting from the response and it requires a target HTML parameter. </p><p> So any thoughts on where to extract out common code would be appreciated. </p><p> 2. The reason for the namespace change is that this TestCase is almost entirely for testing the output of helpers. This is supported by the fact that it automatically includes the methods for the helper named as same as the test name. </p></div> false 2008-07-18T16:10:43+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new actionpack assertions enhancement helper patch tested tests 2008-07-18T16:10:43+01:00 23667 Brian Landau Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 424 4 1. Yeah, it looks tricky ;) 2. The helpers module is to hold the stuff that gets included into the view. The "TestCase" isn't really to be used in you view. You really are testing the view layer, so I think the name still fits. <div><p> 1. Yeah, it looks tricky ;) </p><p> 2. The helpers module is to hold the stuff that gets included into the view. The "TestCase" isn't really to be used in you view. You really are testing the view layer, so I think the name still fits. </p></div> false 2008-07-19T01:34:52+01:00 23667 --- {} 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 new actionpack assertions enhancement helper patch tested tests 2008-07-19T01:34:52+01:00 424 Joshua Peek Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 424 4 false 2008-07-19T21:08:00+01:00 23667 --- :tag: actionpack assertions enhancement helper patch tested tests :state: new 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 open actionpack assertions patch 2008-07-19T21:08:00+01:00 424 Joshua Peek Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 424 4 Closing until further progress is made. <div><p> Closing until further progress is made. </p></div> true 2008-07-27T22:08:40+01:00 23667 --- :tag: actionpack assertions patch :state: open 442 change-actionview-testcase-to-actionview-helpers-testcase-and-add-assertions 0 8994 wontfix actionpack assertions 2008-07-27T22:08:40+01:00 424 Joshua Peek Brian Landau Joshua Peek http://rails.lighthouseapp.com/projects/8994/tickets/442 abb716ca441a0127f0b721539cc3e5d87d4819e5 text/plain 2008-06-17T22:19:24+01:00 refactor_action_view_test_case.patch 27921 24567 23667 http://rails.lighthouseapp.com/attachments/27921/refactor_action_view_test_case.patch eb5b70c19ac5133b8dff462023f615dcf89f955a text/plain 2008-06-20T21:01:44+01:00 action_view_helpers_test_case_tests.patch 28641 1521 23667 http://rails.lighthouseapp.com/attachments/28641/action_view_helpers_test_case_tests.patch 0ed83122045fa100c1d19241f403f30824f48bca text/plain 2008-07-11T22:48:44+01:00 assert_select_in.patch 32174 11641 23667 http://rails.lighthouseapp.com/attachments/32174/assert_select_in.patch 6f8f361f657ff9bd540eebd074dfdbea81970a91 text/plain 2008-07-11T22:50:57+01:00 complete_refactor_action_view_testcase.patch 32175 37731 23667 http://rails.lighthouseapp.com/attachments/32175/complete_refactor_action_view_testcase.patch