Builder templates should respect mimetypes matching format parameter
Reported by Tom Ward | June 18th, 2008 @ 07:36 AM
What I did:
I added the mimetype "application/vnd.google-earth.kml+xml" mapped to extension .kml, and created a view show.kml.builder
What should happen:
Requests to /show.kml should use the show.kml.builder view, with the response type set to "application/vnd.google-earth.kml+xml"
What does happen:
Requests to /show.kml do use the show.kml.builder view, but the response type is set to "application/xml"
I will look into the best way to fix this evening
Comments and changes to this ticket
-
Tom Ward June 18th, 2008 @ 04:15 PM
FYI: action_view/template_handlers/builder.rb sets the mimetype to XML if it hasn't been set beforehand
-
Pratik July 18th, 2008 @ 07:04 PM
- → Tag changed from “” to “actionpack”
- → Assigned user changed from “” to “Joshua Peek”
-
Tom Ward July 18th, 2008 @ 07:38 PM
I'm working on a fix for this right now. Would have claimed it myself, but can't set anyone other than core team as responsible.
-
Tom Ward July 18th, 2008 @ 08:25 PM
- no changes were found...
-
Tom Ward July 18th, 2008 @ 08:25 PM
- → Tag changed from “actionpack” to “actionpack patch tiny”
Added patch
-
Joshua Peek July 19th, 2008 @ 01:47 AM
This looks good, we should definitely force a content type instead of reverting to html.
-
Repository July 19th, 2008 @ 02:16 AM
- → State changed from “new” to “resolved”
(from [c3d1fda555c4bd5f8821d830c685ae5d0e7e52d0]) Set the response content type to that of found template if not explicitly set elsewhere [#444 state:resolved]
Signed-off-by: Joshua Peek
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
