15783
0
true
2008-06-19T22:30:14+01:00
8163
2009-03-18T00:00:00+00:00
9901
454
activerecord-timezone-issues
2
8994
invalid
activerecord bug timezone
ActiveRecord timezone issues
2009-12-01T21:03:05+00:00
23266
Richie Vos
Eugene Pimenov
Geoff Buesing
http://rails.lighthouseapp.com/projects/8994/tickets/454
2.1.1
@@@ ruby
>> Fileset.find(:all, :conditions => {:created_at => Fileset.last.created_at})
=> [#<Fileset id: 7, name: "Untitled.xls", description: nil, created_at: "2008-06-19 20:31:07", updated_at: "2008-06-19 20:31:07", original_size: 433152>]
>> Fileset.find(:all, :conditions => {:created_at => Time.mktime(2008, 06, 20, 0, 31, 7)})
=> []
>> Time.mktime(2008, 06, 20, 0, 31, 7)
=> Fri Jun 20 00:31:07 +0400 2008
>> Fileset.last.created_at
=> пт, 20 июн 2008 00:31:07 MSD +04:00
#
>> Time.now
=> Fri Jun 20 01:27:26 +0400 2008
>> Time.now.utc
=> Thu Jun 19 21:27:39 UTC 2008
>> Time.now.zone
=> "MSD"
@@@
Since Time.now.zone shows me correct timezone, I do not see the reason why I should pass UTC to ActiveRecord::Base.find
@@@ ruby
>> Fileset.find(:all, :conditions => {:created_at => Fileset.last.created_at})
=> [#<Fileset id: 7, name: "Untitled.xls", description: nil, created_at: "2008-06-19 20:31:07", updated_at: "2008-06-19 20:31:07", original_size: 433152>]
>> Fileset.find(:all, :conditions => {:created_at => Time.mktime(2008, 06, 20, 0, 31, 7)})
=> []
>> Time.mktime(2008, 06, 20, 0, 31, 7)
=> Fri Jun 20 00:31:07 +0400 2008
>> Fileset.last.created_at
=> пт, 20 июн 2008 00:31:07 MSD +04:00
#
>> Time.now
=> Fri Jun 20 01:27:26 +0400 2008
>> Time.now.utc
=> Thu Jun 19 21:27:39 UTC 2008
>> Time.now.zone
=> "MSD"
@@@
Since Time.now.zone shows me correct timezone, I do not see the reason why I should pass UTC to ActiveRecord::Base.find
<div><pre><code class="ruby">>> Fileset.find(:all, :conditions => {:created_at => Fileset.last.created_at})
=> [#<Fileset id: 7, name: "Untitled.xls", description: nil, created_at: "2008-06-19 20:31:07", updated_at: "2008-06-19 20:31:07", original_size: 433152>]
>> Fileset.find(:all, :conditions => {:created_at => Time.mktime(2008, 06, 20, 0, 31, 7)})
=> []
>> Time.mktime(2008, 06, 20, 0, 31, 7)
=> Fri Jun 20 00:31:07 +0400 2008
>> Fileset.last.created_at
=> пт, 20 июн 2008 00:31:07 MSD +04:00
#
>> Time.now
=> Fri Jun 20 01:27:26 +0400 2008
>> Time.now.utc
=> Thu Jun 19 21:27:39 UTC 2008
>> Time.now.zone
=> "MSD"
</code></pre>
<p>
Since Time.now.zone shows me correct timezone, I do not see the reason why I should pass UTC to ActiveRecord::Base.find
</p></div>
0
@@@ ruby
>> Fileset.find(:all, :conditions => ["created_at >= ?", Fileset.last.created_at])
=> [#<Fileset id: 7, name: "Untitled.xls", description: nil, created_at: "2008-06-19 20:31:07", updated_at: "2008-06-19 20:31:07", original_size: 433152>]
>> Fileset.find(:all, :conditions => ["created_at >= ?", Time.mktime(2008, 06, 20, 0, 31, 7)])
=> []
>> Fileset.find(:all, :conditions => {:created_at => Time.now.midnight..Time.now})
=> []
>> Fileset.find(:all, :conditions => {:created_at => Time.now.midnight.utc..Time.now})
=> [#<Fileset id: 7, name: "Untitled.xls", description: nil, created_at: "2008-06-19 20:31:07", updated_at: "2008-06-19 20:31:07", original_size: 433152>]
>> Time.mktime(2008, 06, 20, 0, 31, 7)
=> Fri Jun 20 00:31:07 +0400 2008
>> Fileset.last.created_at
=> пт, 20 июн 2008 00:31:07 MSD +04:00
#
>> Time.now
=> Fri Jun 20 01:27:26 +0400 2008
>> Time.now.utc
=> Thu Jun 19 21:27:39 UTC 2008
>> Time.now.zone
=> "MSD"
@@@
Since Time.now.zone shows me correct timezone, I do not see the reason why I should pass UTC to ActiveRecord::Base.find
<div><pre><code class="ruby">>> Fileset.find(:all, :conditions => ["created_at >= ?", Fileset.last.created_at])
=> [#<Fileset id: 7, name: "Untitled.xls", description: nil, created_at: "2008-06-19 20:31:07", updated_at: "2008-06-19 20:31:07", original_size: 433152>]
>> Fileset.find(:all, :conditions => ["created_at >= ?", Time.mktime(2008, 06, 20, 0, 31, 7)])
=> []
>> Fileset.find(:all, :conditions => {:created_at => Time.now.midnight..Time.now})
=> []
>> Fileset.find(:all, :conditions => {:created_at => Time.now.midnight.utc..Time.now})
=> [#<Fileset id: 7, name: "Untitled.xls", description: nil, created_at: "2008-06-19 20:31:07", updated_at: "2008-06-19 20:31:07", original_size: 433152>]
>> Time.mktime(2008, 06, 20, 0, 31, 7)
=> Fri Jun 20 00:31:07 +0400 2008
>> Fileset.last.created_at
=> пт, 20 июн 2008 00:31:07 MSD +04:00
#
>> Time.now
=> Fri Jun 20 01:27:26 +0400 2008
>> Time.now.utc
=> Thu Jun 19 21:27:39 UTC 2008
>> Time.now.zone
=> "MSD"
</code></pre>
<p>
Since Time.now.zone shows me correct timezone, I do not see the reason why I should pass UTC to ActiveRecord::Base.find
</p></div>
false
2008-06-19T22:55:04+01:00
8163
--- {}
454
activerecord-timezone-issues
0
8994
new
ActiveRecord timezone issues
2008-06-19T22:55:04+01:00
8163
Eugene Pimenov
Eugene Pimenov
http://rails.lighthouseapp.com/projects/8994/tickets/454
0
sorry, it's already fixed
<div><p>
sorry, it's already fixed
</p></div>
false
2008-06-19T22:31:54+01:00
8163
--- {}
454
activerecord-timezone-issues
0
8994
new
ActiveRecord timezone issues
2008-06-19T22:31:54+01:00
8163
Eugene Pimenov
Eugene Pimenov
http://rails.lighthouseapp.com/projects/8994/tickets/454
0
okay, hash conditions works, but string do not.
edge rails, installed via rake rails:freeze:edge today (20 jun 2008)
<div><p>
okay, hash conditions works, but string do not.
</p><p>
edge rails, installed via rake rails:freeze:edge today (20 jun 2008)
</p></div>
false
2008-06-19T22:55:55+01:00
8163
--- {}
454
activerecord-timezone-issues
0
8994
new
ActiveRecord timezone issues
2008-06-19T22:55:55+01:00
8163
Eugene Pimenov
Eugene Pimenov
http://rails.lighthouseapp.com/projects/8994/tickets/454
15783
0
false
2008-06-19T23:45:19+01:00
8163
---
:state: new
:assigned_user:
:milestone:
9901
454
activerecord-timezone-issues
0
8994
open
ActiveRecord timezone issues
2008-06-19T23:45:19+01:00
85
Jeremy Kemper
Eugene Pimenov
Geoff Buesing
http://rails.lighthouseapp.com/projects/8994/tickets/454
2.1.1
15783
0
Time#to_s(:db) ignores Time#zone -- example:
@@@ ruby
>> Time.mktime(2008, 06, 20, 0, 31, 7).to_s(:db)
=> "2008-06-20 00:31:07"
>> Time.utc(2008, 06, 20, 0, 31, 7).to_s(:db)
=> "2008-06-20 00:31:07"
@@@
...therefore, AR will treat Time.mktime values as if they were Time.utc values.
@@@ ruby
>> Comment.find(:all, :conditions => {:created_at => Time.local(2008,1,1)})
June 19, 2008 21:18 -- Comment Load (0.001406) SELECT * FROM "comments" WHERE ("comments"."created_at" = '2008-01-01 00:00:00')
@@@
However, if you're setting config.time_zone, you should be able to specify a local time with Time.zone.local() for :conditions, and the correct time value will be sent to the db:
@@@ ruby
>> Comment.find(:all, :conditions => ['created_at > ?', Time.zone.local(2008,1,1)])
June 19, 2008 21:23 -- Comment Load (0.001179) SELECT * FROM "comments" WHERE (created_at > '2008-01-01 06:00:00')
@@@
<div><p>
Time#to_s(:db) ignores Time#zone -- example:
</p>
<pre><code class="ruby">>> Time.mktime(2008, 06, 20, 0, 31, 7).to_s(:db)
=> "2008-06-20 00:31:07"
>> Time.utc(2008, 06, 20, 0, 31, 7).to_s(:db)
=> "2008-06-20 00:31:07"
</code></pre>
<p>
...therefore, AR will treat Time.mktime values as if they were Time.utc values.
</p>
<pre><code class="ruby">>> Comment.find(:all, :conditions => {:created_at => Time.local(2008,1,1)})
June 19, 2008 21:18 -- Comment Load (0.001406) SELECT * FROM "comments" WHERE ("comments"."created_at" = '2008-01-01 00:00:00')
</code></pre>
<p>
However, if you're setting config.time_zone, you should be able to specify a local time with Time.zone.local() for :conditions, and the correct time value will be sent to the db:
</p>
<pre><code class="ruby">>> Comment.find(:all, :conditions => ['created_at > ?', Time.zone.local(2008,1,1)])
June 19, 2008 21:23 -- Comment Load (0.001179) SELECT * FROM "comments" WHERE (created_at > '2008-01-01 06:00:00')
</code></pre></div>
false
2008-06-20T03:34:02+01:00
8163
--- {}
9901
454
activerecord-timezone-issues
0
8994
open
ActiveRecord timezone issues
2008-06-20T03:34:02+01:00
15783
Geoff Buesing
Eugene Pimenov
Geoff Buesing
http://rails.lighthouseapp.com/projects/8994/tickets/454
2.1.1
15783
0
I'm setting config.time_zone…
I think you should consider automatic conversation to UTC…
Because of midnight (and similar) functions. It simply do not point to midnight.
Of course if there're some issues with it, simply close this ticket…
<div><p>
I'm setting config.time_zone…
</p><p>
I think you should consider automatic conversation to UTC…
</p><p>
Because of midnight (and similar) functions. It simply do not point to midnight.
</p><p>
Of course if there're some issues with it, simply close this ticket…
</p></div>
false
2008-06-20T03:46:06+01:00
8163
--- {}
9901
454
activerecord-timezone-issues
0
8994
open
ActiveRecord timezone issues
2008-06-20T03:46:06+01:00
8163
Eugene Pimenov
Eugene Pimenov
Geoff Buesing
http://rails.lighthouseapp.com/projects/8994/tickets/454
2.1.1
15783
0
true
2008-06-20T04:03:51+01:00
8163
---
:state: open
9901
454
activerecord-timezone-issues
0
8994
invalid
ActiveRecord timezone issues
2008-06-20T04:03:51+01:00
85
Jeremy Kemper
Eugene Pimenov
Geoff Buesing
http://rails.lighthouseapp.com/projects/8994/tickets/454
2.1.1
15783
0
Jeremy, I know it's been awhile, but can you explain why this is invalid?
It seems like an inconsistent api that the following doesn't work:
@@@ ruby {
time = Time.mktime(2000, 1, 1)
Model.create!(:occurred_at => time)
Model.find(:first, :conditions => { :occurred_at => time)
}
<div><p>Jeremy, I know it's been awhile, but can you explain why this is
invalid?</p>
<p>It seems like an inconsistent api that the following doesn't
work:</p>
<p>@@@ ruby { time = Time.mktime(2000, 1, 1)<br>
Model.create!(:occurred_at => time)<br>
Model.find(:first, :conditions => { :occurred_at => time)<br>
}</p></div>
true
2009-12-01T20:48:57+00:00
8163
---
:tag:
9901
454
activerecord-timezone-issues
0
8994
invalid
activerecord bug
ActiveRecord timezone issues
2009-12-01T20:49:01+00:00
23266
Richie Vos
Eugene Pimenov
Geoff Buesing
http://rails.lighthouseapp.com/projects/8994/tickets/454
2.1.1
15783
0
I am confident I will never properly format a lighthouse post.
<div><p>I am confident I will never properly format a lighthouse
post.</p></div>
true
2009-12-01T20:50:03+00:00
8163
--- {}
9901
454
activerecord-timezone-issues
0
8994
invalid
activerecord bug
ActiveRecord timezone issues
2009-12-01T20:50:06+00:00
23266
Richie Vos
Eugene Pimenov
Geoff Buesing
http://rails.lighthouseapp.com/projects/8994/tickets/454
2.1.1
15783
0
Sorry, for 3 separate comments, but I think I should clarify, since I had too much timezone info in my brain and didn't properly say it (will be quite happy when lighthouse gets that edit/preview button).
My environment has my local box's timezone as Central. In my environment.rb I have:
config.time_zone = "Eastern Time (US & Canada)"
So when I do
time = Time.mktime(2000, 1, 1)
model = Model.create!(:occurred_at => time)
model = Model.find(model.id) # just to get it clean from the AR/DB point of view
I end up with a model in the db with the time as
model.occurred_at.to_s: "2000-01-01 01:00:00 -0500"
model.occurred_at_before_type_cast: "2000-01-01 06:00:00"
This makes complete sense, since my time was created with an implicit timezone and AR respected that. However, right after doing that, if I do my find, AR doesn't do a conversion, leading to the find not finding anything.
Model.first(:conditions => { :occurred_at => model.occurred_at }) !=
Model.first(:conditions => { :occurred_at => time })
That seems really confusing to me. I can't really think of a reason why that'd be desired behavior.
So I'm thinking I'm misunderstanding something, and would appreciate some clarification.
<div><p>Sorry, for 3 separate comments, but I think I should clarify,
since I had too much timezone info in my brain and didn't properly
say it (will be quite happy when lighthouse gets that edit/preview
button).</p>
<p>My environment has my local box's timezone as Central. In my
environment.rb I have:<br></p>
<pre>
<code>config.time_zone = "Eastern Time (US & Canada)"</code>
</pre>
<p>So when I do<br></p>
<pre>
<code>time = Time.mktime(2000, 1, 1)
model = Model.create!(:occurred_at => time)
model = Model.find(model.id) # just to get it clean from the AR/DB point of view</code>
</pre>
<p>I end up with a model in the db with the time as<br>
model.occurred_at.to_s: "2000-01-01 01:00:00 -0500"<br>
model.occurred_at_before_type_cast: "2000-01-01 06:00:00"</p>
<p>This makes complete sense, since my time was created with an
implicit timezone and AR respected that. However, right after doing
that, if I do my find, AR doesn't do a conversion, leading to the
find not finding anything.</p>
<pre>
<code>Model.first(:conditions => { :occurred_at => model.occurred_at }) !=
Model.first(:conditions => { :occurred_at => time })</code>
</pre>
<p>That seems really confusing to me. I can't really think of a
reason why that'd be desired behavior.</p>
<p>So I'm thinking I'm misunderstanding something, and would
appreciate some clarification.</p></div>
true
2009-12-01T21:03:00+00:00
8163
---
:tag: activerecord bug
9901
454
activerecord-timezone-issues
0
8994
invalid
activerecord bug timezone
ActiveRecord timezone issues
2009-12-01T21:03:05+00:00
23266
Richie Vos
Eugene Pimenov
Geoff Buesing
http://rails.lighthouseapp.com/projects/8994/tickets/454
2.1.1