PostgreSQL: name in CREATE DATABASE is not properly escaped
Reported by Roel van der Hoorn | June 20th, 2008 @ 09:06 AM | in 2.1.1
The name of the new database is not properly escaped on line 509 of the postgresql_adapter.rb. This gives problems when for example your database name contains dots. Changing the line to the following fixes the problem (single quotes do not fix the problem):
execute "CREATE DATABASE \"#{name}\"#{option_string}"
Comments and changes to this ticket
-
Jeremy Kemper June 20th, 2008 @ 09:43 AM
- → Milestone changed from “” to “2.1.1”
- → State changed from “new” to “incomplete”
Please extract to quote_database_name and add a test case.
-
Roel van der Hoorn June 20th, 2008 @ 10:13 AM
I'm unable to find existing tests relating to this functionality, but the following should test it I guess.
def test_should_create_database_with_dot assert_nothing_raised do create_database("r.vanderhoorn") end end -
Irene August 20th, 2008 @ 06:14 PM
- → Tag changed from “” to “2.1 postgresql quoting”
Same with the drop database:
def drop_database(name) #:nodoc: execute "DROP DATABASE IF EXISTS #{name}" endShould be:
def drop_database(name) #:nodoc: execute "DROP DATABASE IF EXISTS \"#{name}\"" end -
-
Jeremy Kemper September 11th, 2008 @ 04:52 PM
- → State changed from “incomplete” to “duplicate”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
