Full class name STI not included in eager loading
Reported by Christian Weyer | June 21st, 2008 @ 02:15 PM
When eager loading a polymorphic association, it does not care about the full class name (with module) in the associated type column (attached_type in the following example).
Example:
class Shared::Address
belongs_to :attached, :polymorphic => true
end
class Company::Base
has_one :address, :as => :attached, :class_name => 'Shared::Address'
end
When saving the association the attached_type column in the addresses table says correctly Company::Base.
Eager loading the company's address however produces this query: Shared::Address::Load (0.000539) SELECT "addresses".* FROM "addresses" WHERE ("addresses"."attached_id" IN (1) and "addresses"."attached_type" = 'Base')
Attached_type is incorrectly set as "Base" where it should be "Company::Base". Therefore this results in company.address being nil.
Note that only eager load is affected. Loading the association on demand works.
Comments and changes to this ticket
-
Joachim Garth June 26th, 2008 @ 06:18 PM
- → Tag changed from to 2.1 activerecord bug eager_loading patch tested
Confirmed; "Wrote a patch" for it... could anybody confirm this?
-
Pratik June 27th, 2008 @ 04:11 PM
- → Tag changed from 2.1 activerecord bug eager_loading patch tested to 2.1 activerecord bug eager_loading patch
- → State changed from new to incomplete
Could you please generate the patch using git-format-patch ? Also, the patch is missing tests.
Thanks.
-
Joachim Garth June 27th, 2008 @ 07:08 PM
Done and done. :) It's a git format-patch now. Tests are included now, as well.
-
Pratik June 27th, 2008 @ 07:27 PM
- → State changed from incomplete to open
-

Christian Weyer June 28th, 2008 @ 04:43 PM
This bug seems to be bigger than I first thought. When checking http://rails.lighthouseapp.com/a... I could not find any code changes for eager loading at all?
I still encounter this bug after applying Josch's patch in other scenarios, not related to polymorphic associations. How comes nobody noticed that? Am I the only one using namespaces?
-

Christian Weyer June 28th, 2008 @ 09:14 PM
- → Title changed from Polymorphic eager load does not care about full class name in <assoc_name>_type column to Full class name STI not included in eager loading
-

Christian Weyer June 28th, 2008 @ 11:00 PM
Fixed both of the bugs, attached a test. This test does not include tests since Josch's test are already there and working
-

Christian Weyer June 28th, 2008 @ 11:01 PM
Should not work late a night :)
I attached a patch, not a test. And this patch does not include tests since Josch's tests are working
-
-
-
Pratik July 17th, 2008 @ 01:47 PM
- → Assigned user changed from to Pratik
-

Repository July 18th, 2008 @ 03:47 AM
- → State changed from open to Resolved
(from [a1fcbd971d681e44de5ea33e6a8470ff8b8144c0]) Make sure association preloading works with full STI class name [#465 state:Resolved]
Signed-off-by: Pratik Naik
-

Repository August 25th, 2008 @ 09:28 AM
(from [c3aad223321d1897c9e2269b32c3c2da7af814d1]) Make sure association preloading works with full STI class name [#465 state:Resolved]
Signed-off-by: Pratik Naik pratiknaik@gmail.com http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
