Automatic validation on has_many should not be performed twice
Reported by wildchild | June 25th, 2008 @ 10:51 AM
I found that has_many performs automatic validation of associated records and if "validates_associated" declared then validation performed twice.
This is very painful if different error message needed (eg. other language), also this behavior will produce many similar error messages if more then 1 associated records are invalid (don't think that it's useful).
I see different ways to workaround:
1) Check that associated object already validated (new property needed)
2) Check that validates_associated performed (don't know how to check this)
3) Check for record.errors.any? before calling record.valid? but for valid records validation will be performed again (possible overhead for complicated validations)
Any ideas, guys?
Comments and changes to this ticket
-
Jan De Poorter June 25th, 2008 @ 11:51 AM
- → Tag changed from “” to “activerecord bug has_many”
As discussed on IRC, you can use
has_many :things, :validate => falseand then add the validation, or least you will be able to do this once this patch makes it into core ;-)
-
Tarmo Tänav September 18th, 2008 @ 08:10 AM
- → Tag changed from “activerecord bug has_many” to “activerecord bug has_many”
- → State changed from “new” to “resolved”
As already pointed out, ":validate => false" can now be used to counter this problem.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
DHH
Jean-Baptiste Escoyez