#483 Automatic validation on has_many should not be performed twice - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#483 ✓resolved

Automatic validation on has_many should not be performed twice

Reported by wildchild | June 25th, 2008 @ 10:51 AM

I found that has_many performs automatic validation of associated records and if "validates_associated" declared then validation performed twice.

This is very painful if different error message needed (eg. other language), also this behavior will produce many similar error messages if more then 1 associated records are invalid (don't think that it's useful).

I see different ways to workaround:

1) Check that associated object already validated (new property needed)

2) Check that validates_associated performed (don't know how to check this)

3) Check for record.errors.any? before calling record.valid? but for valid records validation will be performed again (possible overhead for complicated validations)

Any ideas, guys?

Comments and changes to this ticket

You flagged this item as spam.
Jan De Poorter June 25th, 2008 @ 11:51 AM
- Tag set to “activerecord, bug, has_many”
As discussed on IRC, you can use
```
has_many :things, :validate => false
```
and then add the validation, or least you will be able to do this once this patch makes it into core ;-)
Tarmo Tänav September 18th, 2008 @ 08:10 AM
- State changed from “new” to “resolved”
- Tag changed from “activerecord, bug, has_many” to “activerecord, bug, has_many”
As already pointed out, ":validate => false" can now be used to counter this problem.