Racing Inside ActiveSupport::Dependencies
Reported by skibumsworld | June 27th, 2008 @ 02:10 AM | in 2.1.3
I'm working on a project that uses mongrel handlers to service requests. We use ActiveRecord but not ActionController. We've been seeing weird errors which look like:
#<LoadError: Expected ./my_model.rb to define MyModel>
the file does define the class but an exception is thrown. After some digging we found that the problem is in dependencies.rb in the require_or_load method.
If a thread is interrupted right after:
loaded << expanded
then any other threads that attempt to load the same file will get the error above, because the file hasn't been loaded yet even though it's name already appears in the loaded list.
I've included a test to reproduce this. The test only works against the development version of rails. If you want you can run it against other version but you will need to change the way Dependencies module is declared since it didn't used to be inside the ActiveSupport module.
I'm working on a patch right now, but any suggestions on how to fix this issue are more then welcome.
One last thing. When running the test please don't forget to change the first require to point at the correct location for activerecord.
Comments and changes to this ticket
-
-
Jeremy Kemper June 27th, 2008 @ 08:53 AM
- → Milestone changed from “” to “2.1.1”
- → State changed from “new” to “open”
- → Assigned user changed from “” to “Jeremy Kemper”
-
DrMark June 27th, 2008 @ 09:07 AM
Jeremy,
While you are working in there, would you fix the typo in will_unload?. It is currently:
def will_unload?(const_desc)
autoloaded?(desc) ||
explicitly_unloadable_constants.include?(to_constant_name(const_desc))
end
but should be:
def will_unload?(const_desc)
autoloaded?(const_desc) ||
explicitly_unloadable_constants.include?(to_constant_name(const_desc))
end
Note the autoloaded line. I will make a separate ticket if necessary.
Thanks!
DrMark
-
-
Jeremy Kemper June 28th, 2008 @ 01:15 AM
- → Tag changed from “activesupport dependencies” to “activesupport dependencies patch”
skibumsworld, could you use a Mutex instead? Thread.critical has issues on jruby so other synchronization primitives are preferred.
-
Jeremy Kemper June 28th, 2008 @ 01:16 AM
DrMark, will_unload? appears to be completely unused. Do you use it?
-
DrMark October 23rd, 2008 @ 04:24 PM
Hi Jeremy,
Yes. The benchmarkforrails plugin uses it (among others). I thought that it was odd that a bug that obvious could get through :)
If you could fix it or remove it that would be great. That would save me having to monkey patch it all the time :)
Thanks!
-
Jeremy Kemper June 28th, 2008 @ 05:09 AM
Quite so, DrMark. I fixed it in master, 2-1-stable, and 2-0-stable. How odd.
-
Jeremy Kemper July 30th, 2008 @ 10:06 AM
- → Milestone changed from “2.1.1” to “2.2”
- → State changed from “open” to “stale”
- → Assigned user changed from “Jeremy Kemper” to “Joshua Peek”
-
Jeremy Kemper October 24th, 2008 @ 03:19 AM
- → Milestone changed from “2.2” to “2.1.3”
- → State changed from “stale” to “open”
- → Assigned user changed from “Joshua Peek” to “Jeremy Kemper”
-
Stephen Bannasch December 27th, 2008 @ 04:23 PM
Here are links to two related bugs in ruby's implementation of require when used with threads:
require is not thread-safe http://redmine.ruby-lang.org/iss...
autoload is not thread-safe http://redmine.ruby-lang.org/iss...
Basically there does not appear to be a safe way for require to work in a multi-threaded application unless the first use of require locks until the require is complete.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
Joshua Peek