FormBuilder date helpers ignore html_options
Reported by Pascal Ehlert | June 28th, 2008 @ 04:15 PM | in 2.x
It turned out that the form builder (f.) helpers of date_select, datetime_select and time_select ignore the html_options you pass to it.
They do work for the normal helper from DateHelpers class however, the problem is that the html_options hash simply gets not passed through to them in their form builder definitions.
Some Rails developers apparently need more coffee. ;-)
Comments and changes to this ticket
-
Pratik June 28th, 2008 @ 06:59 PM
- → State changed from “new” to “incomplete”
Hey Pascal,
Could you please add tests as well ?
Thanks.
-
Pascal Ehlert June 28th, 2008 @ 07:43 PM
- → Tag changed from “2.1 actionpack forms helper patch” to “2.1 actionpack forms helper patch tests”
Sorry for not including them in the first patch, I was a bit in a hurry earlier.
I have attached an updated version with tests. Hope this makes it into trunk soon.
-
Pratik June 28th, 2008 @ 08:24 PM
- → State changed from “incomplete” to “open”
-
Repository June 29th, 2008 @ 12:51 AM
(from [029a7455846cde2654958358a6fe354f236ade35]) Ensure FormBuilder date helpers respects html_options. [#506 state:resolved] [Pascal Ehlert]
Signed-off-by: Pratik Naik
-
Repository June 29th, 2008 @ 12:52 AM
(from [b416c6880bba538799513f4afd4125a0be8c2fb5]) Ensure FormBuilder date helpers respects html_options. [#506 state:resolved] [Pascal Ehlert]
Signed-off-by: Pratik Naik
Conflicts:
actionpack/test/template/date_helper_test.rb
-
Pascal Ehlert July 2nd, 2008 @ 10:43 AM
Thanks for fixing, Pratik!
Shouldn't this ticket be closed now?
-
Pratik July 2nd, 2008 @ 12:50 PM
- → State changed from “open” to “resolved”
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
