Make Request#remote_ip handle edge case with REMOTE_ADD being a comma-separated list
Reported by Michael Klishin (antares) | July 1st, 2008 @ 10:05 AM | in 2.x
I found out that Request#remote_ip fails with ArgumentError when REMOTE_ADDR is a comma-separated list.
In some particular cases with Nginx and some ISPs REMOTE_ADDR happens to be a comma-separated list of IP addresses so checking for local request passes a string with commas to IPAddr.new and causes exceptions. Exception notifier plugin does such checks in production environment, for instance. Semantics of REMOTE_ADDR being a list is unclear and probably an edge case but it happens and is painful to track down.
This patch makes Request#remote_ip gracefully handle cases when REMOTE_ADDR is a comma-separated list of IPs.
Comments and changes to this ticket
-
-
-
Michael Klishin (antares) July 1st, 2008 @ 10:16 AM
Here is a blog post on this topic, it also may happen to HTTP_X_FORWARDED_FOR.
-
Pratik July 4th, 2008 @ 01:07 AM
- → Title changed from “[PATCH] make Request#remote_ip handle edge case with REMOTE_ADD being a comma-separated list” to “Make Request#remote_ip handle edge case with REMOTE_ADD being a comma-separated list”
- → Assigned user changed from “Pratik” to “Jeremy Kemper”
-
-
Repository August 28th, 2008 @ 07:03 AM
- → State changed from “new” to “resolved”
(from [e42a235dd18a39ccc83382365088de96f24fa236]) Request#remote_ip handles the uncommon case that REMOTE_ADDR is a comma-separated list.
[#523 state:resolved]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...
-
Repository August 28th, 2008 @ 07:03 AM
(from [e21ed3e45429cf4a7ee4f5b6b550f457f0c4c313]) Request#remote_ip handles the uncommon case that REMOTE_ADDR is a comma-separated list.
[#523 state:resolved]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
The Git repository resides at http://github.com/rails
Check out the current development trunk (Edge Rails) with:
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".
Jeremy Kemper