link_to with single string argument
Reported by David Eisinger | July 7th, 2008 @ 06:11 PM | in 2.x
Currently, calling the link_to helper method with a single string argument generates a link with the given string as the link text and the current URL as the linked URL. This patch makes it so that the given string is used as both the link text and the link URL. In other words,
link_to("http://www.rubyonrails.org")
will now generate the following link:
Comments and changes to this ticket
-
Ryan Bates July 7th, 2008 @ 09:48 PM
You can use auto_link for this.
auto_link "http://www.rubyonrails.org"That probably isn't as efficient performance wise, so I would still like to see this patch accepted.
-
Chris Barnett July 8th, 2008 @ 04:58 AM
I think this is a good idea, but I'm not sure about the implementation.
I've always been able to do
<%= link_to "Somewhere" %>To create a placeholder for a real link which will be added later. It renders as:
<a href="/path/to/the/current/page">Somewhere</a>This is great for mocking up a page; but with this patch applied, the same link_to becomes:
<a href="Somewhere">Somewhere</a>Placeholder links will now give 404 errors instead of just reloading the page.
Is anyone else using link_to this way?
-
Pratik August 3rd, 2008 @ 02:31 PM
- → State changed from “new” to “wontfix”
Should just use auto_link.
Please Login or create a free account to add a new comment.
You can update this ticket by sending an email to from your email client. (help)
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
Source available from github
Repository is at http://github.com/rails/rails
Check out the development master (Edge Rails):
git clone git://github.com/rails/rails.git
Creating or reviewing a patch
See the contributor guide.
Creating a feature request
Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.
Creating a bug report
When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.
Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.
Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too"..
