#570 √ incomplete
tmtysk

Failed to create error_path on failsafe_response_body

Reported by tmtysk | July 8th, 2008 @ 04:25 AM | in 2.x

In ActionController::Dispatcher,

It cannot get correct error_page_path such as "#{RAILS_ROOT}/public/500.html", if it occurred some errors in dispatching.

Comments and changes to this ticket

  • Pratik

    Pratik July 8th, 2008 @ 01:08 PM

    • → State changed from “new” to “incomplete”

    Could you please add a failing test case to your patch ?

    Thanks.

  • tmtysk

    tmtysk July 8th, 2008 @ 03:56 PM

    Hi, Pratik.

    I don't know how to write a test-case for Dispatcher, but I could confirm a failing case by following procedures below.

    1) Set using MemCacheStore as SessionStorage.

    2) Start rails application by 'script/server -p3000'

    3) Run a following rspec examples:

    describe "ActionController::Dispatcher" do

    it "should render a text in '/public/500.html' when specified invalid session_id" do

    `curl "http://localhost:3000/?_sess='"`.include?("We're sorry, but something went wrong (500)").should be_true

    end

    end

    Before patched, Dispatcher could NOT get '500.html' as error_path, got '500 .html', so it failed test case.

    Thanks.

  • Kieran P

    Kieran P July 23rd, 2008 @ 10:59 PM

    We've encountered this problem ourselves. After a little research, a ticket relating to this problem was found on the old bug tracker. See

    http://dev.rubyonrails.org/ticke...

    Basically, its looking for '500 .html' rather than '500.html'. Changing [0..3] to [0...3] has fixed the problem.

Please Login or create a free account to add a new comment.

You can update this ticket by sending an email to from your email client. (help)

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

Source available from github

The Git repository resides at http://github.com/rails

Check out the current development trunk (Edge Rails) with:

git clone git://github.com/rails/rails.git

Creating or reviewing a patch

See the contributor guide.

Creating a feature request

Please don't. If you want a new feature in Rails, you'll have to pull up your sleeves and get busy yourself. Or convince someone else to do it. See the contributor guide on how to get going. But posting them here is just going to lead to ticket root.

Creating a bug report

When creating a bug report, be sure to include as much relevant information as possible. Post the code sample that causes the problem. Preferably, alter the unit tests and show through either changed or added tests how the expected behavior is not occuring.

Security vulnerabilities should be reported via an email to security@rubyonrails.org, do not use trac for reporting security vulnerabilities. All content in trac is publicly available as soon as it is posted.

Then don't get your hopes up. Unless you have a "Code Red, Mission Critical, The World is Coming to an End" kinda bug, you're creating this ticket in the hope that others with the same problem will be able to collaborate with you on solving it. Do not expect that the ticket automatically will see any activity or that others will jump to fix it. Creating a ticket like this is mostly to help yourself start on the path of fixing the problem and for others to sign on to with a "I'm having this problem too".

Shared Ticket Bins

People watching this ticket